Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Nov 23, 2011
  1. @Seldaek
Commits on Nov 22, 2011
  1. @fabpot

    merged branch hlecorche/valid-form-w3c (PR #2676)

    fabpot authored
    Commits
    -------
    
    78e9b2f [Form] Fixed textarea_widget (W3C standards)
    
    Discussion
    ----------
    
    [Form] Fixed textarea_widget (W3C standards)
    
    Textarea widget included the "pattern" attribute but is not valid by W3C standards.
    
    (See PR 2666 - New PR because rebase inside the 2.0 branch)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/18 09:01:41 -0800
    
    @hlecorche: Thanks for your work on this issue. Can you update the unit tests to be sure that this case is covered? If you're not comfortable with this, just tell me and I will do it myself
    
    ---------------------------------------------------------------------------
    
    by hlecorche at 2011/11/19 02:51:06 -0800
    
    @fabpot: I did'nt commited because I am not sure. I changed the "tests/Symfony/Tests/Component/Form/AbstractLayoutTest.php" file :
    
        public function testTextarea()
        {
            $form = $this->factory->createNamed('textarea', 'na&me', 'foo&bar', array(
                'property_path' => 'name',
                'pattern' => 'foo',
            ));
    
            $this->assertWidgetMatchesXpath($form->createView(), array(),
        '/textarea
        [@name="na&me"]
        [not(@pattern)]
        [.="foo&bar"]
        '
            );
        }
    
    Is it correct?
  2. @fabpot
  3. @fabpot

    merged branch canni/throw_exception_on_form_name_circulal_ref (PR #2675)

    fabpot authored
    Commits
    -------
    
    36cebf0 Fix infinite loop on circullar reference in form factory
    
    Discussion
    ----------
    
    [BugFix][Form]Throw exception on form name circulal ref
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Closes: #2673
    
    When FormType method `getName()` returns the same value as `getParent()` we're asking about trouble, and land into infinite loop.
  4. @fabpot

    merged branch willdurand/undefined-value-property-path (PR #2266)

    fabpot authored
    Commits
    -------
    
    57e1aeb Fixed undefined index notice in readProperty() method (PropertyPath)
    
    Discussion
    ----------
    
    Fixed undefined index notice in readProperty() method (PropertyPath)
    
    Hi,
    
    For some reasons, I get `notice` errors on `readProperty()` with Propel:
    
        Notice: Undefined index: 0 in /Users/william/projects/Propel/testProjects/symfony2/vendor/symfony/src/Symfony/Component/Form/Util/PropertyPath.php line 284
    
    The `PropelObjectCollection` implements `ArrayAccess`, the `readProperty()` method does not check if the given `index` exists so the `notice` error is thrown. I suppose to check whether the index exists or not has to be added.
    
    Regards,
    William
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/27 23:42:07 -0700
    
    The patch is probably not what we want to do. First, I suppose that you are not creating the propertyPath by hand. If that is the case, we need to understand why the property path does not exist. Then, even if we might want to check the existence of the index, if it does not exist, we should probably throw an exception instead of just ignoring the problem.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/28 01:14:49 -0700
    
    My bad. This is a Propel bug due to `ArrayObject`. It throws a notice error if the index is not found in `offsetGet()` which is wrong according to the `ArrayAccess` interface. If the index is not found, we have to return `null`.
    
    @fabpot Are you agree with that (for the `null` value) ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/28 01:17:09 -0700
    
    My point is that it should never happen under normal circumstances.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/28 01:23:55 -0700
    
    @fabpot Not sure to get it.
    
    The fact is that it tries to get the value (`getValue()`) of a fresh object, just added to the `collection` when I'm submitting a form with a `CollectionType` and a new entry in it.
    I mean it tries to get this new object (not yet persisted, not yet in the collection) in the collection (`getValue()` -> `readProperty()`) which implements `ArrayAccess` but this object cannot be in the collection at this time.
    
    Am I wrong ?
    
    And, without this notice error thrown by Propel, I probably never opened this issue...
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/29 06:40:34 -0700
    
    @fabpot: you can try this example: http://www.propelorm.org/cookbook/symfony2/mastering-symfony2-forms-with-propel.html#manytomany_relations in order to make your own tests. Will it be enough?
    As I said, it throws a weird notice for the reasons above.
    
    ---------------------------------------------------------------------------
    
    by jaugustin at 2011/10/04 12:58:10 -0700
    
    any news on this ?
    @fabpot did you have time to look at the test case ?
    
    ---------------------------------------------------------------------------
    
    by cedriclombardot at 2011/11/09 14:29:42 -0800
    
    @fabpot: can we have news about this ?
Commits on Nov 18, 2011
  1. @hlecorche
  2. @canni

    Fix infinite loop on circullar reference in form factory

    canni authored
    When `->getName()` returns the same as `getParent()` we're going to infinite loop.
Commits on Nov 17, 2011
  1. @fabpot

    merged branch kriswallsmith/form/checkbox-view (PR #2661)

    fabpot authored
    Commits
    -------
    
    79ae3fc [Form] fixed radio and checkbox when data is not bool
    
    Discussion
    ----------
    
    [Form] fixed checkbox view
    
    The checkbox view was being built based on app data, not client data. This fixes it.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/16 13:31:09 -0800
    
    `RadioType` suffers from the same problem, no?
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2011/11/16 13:32:50 -0800
    
    Yeah, I'll fix that too.
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2011/11/16 13:43:29 -0800
    
    Updated to include `RadioType`.
  2. @fabpot
Commits on Nov 16, 2011
  1. @kriswallsmith
Commits on Nov 11, 2011
  1. @ManuelAC
  2. @ManuelAC

    [Form] Replace `an` with `is`

    ManuelAC authored
  3. @fabpot

    [Form] fixed previous merge

    fabpot authored
  4. @fabpot
  5. @ondrowan

    Added check for array fields to be integers in reverseTransform metho…

    ondrowan authored
    …d. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609
Commits on Nov 2, 2011
  1. @fabpot

    merged branch mrtorrent/integer_transformer_cast_fix (PR #2520)

    fabpot authored
    Commits
    -------
    
    c9d05d7 Let NumberFormatter handle integer type casting
    
    Discussion
    ----------
    
    Let NumberFormatter handle integer type casting
    
    The integer to localised string transformer is currently casting everything it gets to an integer, even if it is not a number. This responsibility should be passed off to NumberFormatter.
    
    Partially addresses #2389 by not mistakenly typecasting a boolean false into an integer 0
    
    ---------------------------------------------------------------------------
    
    by mrtorrent at 2011/10/30 15:04:28 -0700
    
    Apologies, forgot the template:
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #2389 (partial)
  2. @fabpot
  3. @fabpot
Commits on Nov 1, 2011
  1. @fabpot
Commits on Oct 30, 2011
  1. @mrtorrent

    Let NumberFormatter handle integer type casting

    mrtorrent authored
    Partially addresses #2389 by not mistakenly typecasting a boolean false into
    an integer 0
Commits on Oct 29, 2011
  1. @fabpot

    removed unused use statements

    fabpot authored
Commits on Oct 7, 2011
  1. @fabpot

    merged branch stloyd/form_texttypes (PR #2343)

    fabpot authored
    Commits
    -------
    
    8bd0e42 [Form] Use proper parent (text) for EmailType and TextareaType
    
    Discussion
    ----------
    
    [2.0][Form] Use proper parent (text) for EmailType and TextareaType
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
  2. @fabpot

    merged branch stloyd/ScalarTransformer (PR #2341)

    fabpot authored
    Commits
    -------
    
    95049ef [Form] Added type check to `ScalarToChoiceTransformer`
    
    Discussion
    ----------
    
    [2.0][Form] Added type check to ScalarToChoiceTransformer
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
  3. @stloyd
  4. @stloyd
  5. @stloyd
Commits on Oct 5, 2011
  1. @fivestar
Commits on Sep 26, 2011
  1. @igorw

    [composer] add composer.json

    igorw authored
  2. @willdurand
Commits on Sep 14, 2011
  1. @fabpot

    [Form] fixed error bubbling for Date and Time types when rendering as…

    fabpot authored
    … multiple choices (closes #2062)
Commits on Aug 23, 2011
  1. @fabpot

    merged branch stloyd/issue_1986 (PR #2000)

    fabpot authored
    Commits
    -------
    
    c29fa9d [Form] Fix for treatment zero as empty data. Closes #1986
    
    Discussion
    ----------
    
    [Form] Fix for treatment zero as empty data. Closes #1986
    
    For more info please read #1986.
Commits on Aug 22, 2011
  1. @fabpot

    [Form] added missing DelegatingValidator registration in the Form Ext…

    fabpot authored
    …ension class (used when using the Form component outside a Symfony2 project where the validation.xml is used instead)
  2. @weaverryan
  3. @stloyd
Commits on Aug 19, 2011
  1. @fabpot

    merged branch stloyd/form_datetime_transformer (PR #1851)

    fabpot authored
    Commits
    -------
    
    d880db2 [Form] Test covered fix for invalid date (13 month/31.02.2011 etc.) send to transformer. Closes #1755
    df74f49 Patched src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToArrayTransformer.php to throw an exception when an invalid date is passed for transformation (e.g. 31st February)
    
    Discussion
    ----------
    
    [Form] Fix for "DateTimeToArrayTransformer" with invalid dates
    
    Hey,
    
    this is test covered fix from @mdavis1982 (closes #1755)
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/08/16 01:31:32 -0700
    
    @fabpot Can we have this fix merged ?
Something went wrong with that request. Please try again.