Permalink
Commits on Sep 19, 2012
Commits on Sep 10, 2012
Commits on Aug 31, 2012
Commits on Aug 30, 2012
  1. merged branch mpiecko/master (PR #5280)

    Commits
    -------
    
    58ebd1b [Form] Fixed error bubbling from DateTime widget - Issue #5270
    8ea1607 Update src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
    
    Discussion
    ----------
    
    [Form] Fixed error bubbling from DateTime widget - Issue #5270
    
    This is related to symfony/symfony#5270
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-16T19:37:45Z
    
    Travisbot shows something like this in it's log:
    
        [Composer\Downloader\TransportException] The "http://nodeload.github.com/phingofficial/phing/zipball/2.4.12" file could not be downloaded (HTTP/1.1 500 Internal Server Error)
    
    So is it my PR ot Travis CI who fails ... ? I saw this error in some other PR's ...
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-08-16T20:40:39Z
    
    It's GitHub =)
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T09:36:31Z
    
    Bad GitHub :)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-17T11:21:39Z
    
    Could you please add a test to DateTimeTypeTest?
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T12:23:40Z
    
    Sure!
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-30T08:20:08Z
    
    👍
    fabpot committed Aug 30, 2012
Commits on Aug 29, 2012
  1. merged branch Tobion/formexception (PR #5337)

    Commits
    -------
    
    eb2eba1 [Form] don't allow users to force exceptions by submitting unexpected data
    
    Discussion
    ----------
    
    [Form] don't allow users to force exceptions by submitting unexpected data
    
    fix #5334
    
    This makes it more fault-tolerant by simply ignoring wrong stuff from hackers.
    
    @bschussek: I didn't find any other UnexpectedTypeExceptions that could be invoked by simply submitting unexpected data. But I'm not 100% sure that there aren't any indirectly invokeable, e.g. in some listeners.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T22:34:52Z
    
    a test is missing for this.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-24T23:02:26Z
    
    @stof true, I will add one
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-25T13:51:23Z
    
    Added test.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:07:37Z
    
    👍
    
    Could you please squash the commits?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-29T13:43:52Z
    
    Done.
    fabpot committed Aug 29, 2012
  2. [Form] don't allow users to force exceptions by submitting unexpected…

    … data
    
    this makes it more fault-tolerant by simply ignoring wrong stuff from hackers
    
    [Form] added test to ensure binding of wrong data is ignored
    Tobion committed Aug 24, 2012
  3. merged branch Tobion/formincon (PR #5355)

    Commits
    -------
    
    7e8ab54 [Form] raise OutOfBoundsException instead of InvalidArgumentException for inexistent form childs to be in line with PropertyPath
    
    Discussion
    ----------
    
    [Form] raise OutOfBoundsException instead of InvalidArgumentException in Form::get
    
    BC break: yes
    
    Raise OutOfBoundsException instead of InvalidArgumentException in Form::get for inexistent form childs to be in line with PropertyPath, which also uses OutOfBoundsException for invalid indexes. OutOfBoundsException fits much better as it extends RuntimeException instead of LogicException and this error can typically not be detected at compile time.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:01:01Z
    
    👍
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-08-29T11:07:51Z
    
    Shouldn't this change be noted in upgrade file ?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-29T11:23:04Z
    
    it should (and in the changelog of the component)
    fabpot committed Aug 29, 2012
  4. merged branch Tobion/formguess (PR #5361)

    Commits
    -------
    
    e7e39e0 [Form] refactor Guess
    dcbeeb1 [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess
    
    Discussion
    ----------
    
    [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess
    
    BC break: yes
    
    this is a better fit because the error is a logic exception (that can be detected at compile time, i.e. when writing the code) instead of a runtime exception
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T10:51:54Z
    
    👍
    fabpot committed Aug 29, 2012
  5. merged branch Tobion/formhasparent (PR #5360)

    Commits
    -------
    
    0186731 [Form] removed hasParent from FormInterface and deprecated its use
    
    Discussion
    ----------
    
    [Form] removed hasParent from FormInterface and deprecated its use
    
    There are already 2 alternatives with getParent() and isRoot(), so a third one with similar semantics is confusing and unneeded.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:11:11Z
    
    👍
    fabpot committed Aug 29, 2012
  6. merged branch Tobion/formrefactor (PR #5338)

    Commits
    -------
    
    492c990 [Form] optimized PropertyPathMapper to invoke the expensive property path less often
    47a8bbd [Form] optimized the binding of child forms and calculation of extra data
    8d45539 [Form] refactor Form::bind to save 7 assignments
    
    Discussion
    ----------
    
    [Form] refactor Form::bind to save 7 assignments and a complete loop
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T23:45:18Z
    
    the new code is not equivalent. See travis for the proof.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-25T01:50:41Z
    
    @stof fixed, I had to reduce the refactoring a little
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:05:52Z
    
    👍
    fabpot committed Aug 29, 2012
  7. merged branch Tobion/formhaserrors (PR #5356)

    Commits
    -------
    
    d5eb4f7 [Form] fix phpdoc of Form::hasErrors
    5cb8264 [Form] deprecated Form::hasErrors that isn't part of the Interface
    
    Discussion
    ----------
    
    [Form] deprecated Form::hasErrors that isn't part of the Interface
    
    This method is not part of FormInterface, so I deprecated it as it cannot be used reliably. This is consistent with other hassers that were deprecated like `hasChildren` where one should use `count` instead.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-26T19:11:19Z
    
    You should deprecate it, not remove it
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-26T19:17:35Z
    
    oh right. I thought it was added in 2.1 and thus can be removed but it's also in 2.0.
    Done.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:00:32Z
    
    👍
    fabpot committed Aug 29, 2012
  8. merged branch Tobion/formparent (PR #5357)

    Commits
    -------
    
    30c1457 [Form] fixed Form::setParent(null)
    214f0de [Form] added test with null parent
    
    Discussion
    ----------
    
    [Form] fixed Form::setParent(null)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T10:58:20Z
    
    👍
    fabpot committed Aug 29, 2012
  9. minor correction

    dcsg committed Aug 29, 2012
Commits on Aug 28, 2012
  1. merged branch pitiflautico/patch-1 (PR #5372)

    Commits
    -------
    
    7fc8fc0 [Form] Fix double semicolon
    
    Discussion
    ----------
    
    [Form] Fix double semicolon
    fabpot committed Aug 28, 2012
  2. [Form] Fix double semicolon

    pitiflautico committed Aug 28, 2012
  3. [Form] raise OutOfBoundsException instead of InvalidArgumentException…

    … for inexistent form childs to be in line with PropertyPath
    Tobion committed Aug 26, 2012
  4. [Form] removed hasParent from FormInterface and deprecated its use

    There are already 2 alternatives with getParent() and isRoot(), so a third one with similar semantics is confusing and unneeded.
    Tobion committed Aug 26, 2012
  5. [Form] refactor Guess

    Tobion committed Aug 27, 2012
  6. [Form] replaced UnexpectedValueException by InvalidArgumentException …

    …in Guess
    
    this is a better fit because the error is a logic exception instead of a runtime exception
    Tobion committed Aug 27, 2012
  7. merged branch Tobion/formdoc (PR #5350)

    Commits
    -------
    
    83dc966 [Form] Fixed some PHPDoc
    596bbb1 [Form] fixed FormConfigBuilder to use PropertyPathInterface
    a523823 [Form] fixed and added phpDoc
    
    Discussion
    ----------
    
    [Form] fixed and added phpDoc
    
    [ci skip]
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-08-26T08:11:01Z
    
    Some descriptions don''t seem to be properly aligned, use the CS-fixer.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-26T17:02:25Z
    
    @sstok This is more about manual fixes concerning forgotten exceptions or wrong data type. The cs fixer gives many false positives and can be applied later.
    fabpot committed Aug 28, 2012
Commits on Aug 27, 2012
  1. [Form] Fixed some PHPDoc

    pborreli committed with Tobion Aug 27, 2012
  2. [Form] fixed and added phpDoc

    Tobion committed Aug 26, 2012
Commits on Aug 26, 2012
Commits on Aug 25, 2012
  1. merged branch Tobion/patch-2 (PR #5240)

    Commits
    -------
    
    9e5d5a4 [Form] fix static method call
    
    Discussion
    ----------
    
    [Form] fix static method call
    
    `allowDataWalking` was called statically, but wasnt defined as such.
    fabpot committed Aug 25, 2012
  2. merged branch willdurand/fix-composer-components (PR #5318)

    Commits
    -------
    
    933e821 Add minimum-stability (dev) in each component
    
    Discussion
    ----------
    
    Add minimum-stability (dev) in each component
    
    This fixes the ability to run the test suite in each component if a `composer install` is needed.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T13:57:14Z
    
    If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great.
    Anyway, 👍 for this
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-08-22T13:59:15Z
    
    Yes I already did that once. I'll try to fix more components later.
    
    On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet <
    notifications@github.com> wrote:
    
    > If you really want to run the testsuite standalone, some dev requirements
    > are missing (SecurityBundle needs the FrameworkBundle for its functional
    > tests for instance). If you have some time to check the missing dev
    > requirement, it would be great.
    > Anyway, [image: 👍] for this
    >
    > —
    > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>.
    >
    >
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:02:23Z
    
    Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle)
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:14:00Z
    
    what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-22T14:30:13Z
    
    please, don't add more travis files. The main already tests everything, and that's all we need.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:33:46Z
    
    @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps).
    Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis.
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:42:30Z
    
    ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook
    
    ---------------------------------------------------------------------------
    
    by hason at 2012-08-24T13:12:04Z
    
    @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T13:35:07Z
    
    @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
    fabpot committed Aug 25, 2012
Commits on Aug 22, 2012
  1. merged branch bschussek/issue5221 (PR #5319)

    Commits
    -------
    
    a38232a [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
    
    Discussion
    ----------
    
    [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5221
    Todo: -
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:14:55Z
    
    the return value of the getParent method should be updated in the phpdoc of the FormTypeInterface to mention the FormTypeInterface .And the description of the method should be updated to explain than returning an instance is discouraged as it implies a performance penalty and does not support using type extensions (if the comment in the factory also applies to the unregistered parent)
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2012-08-22T14:22:00Z
    
    Wasn't TypeExtensions supported before? This means that Csrf will not be applied?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:23:50Z
    
    @henrikbjorn the csrf extension is targeting the FormType, which is registered in the form registry. What is not supported is having a type extension targeting an unregistered type
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-22T14:39:53Z
    
    @stof Exactly. I find it a bit unlogical to register an extension for something that is not registered.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2012-08-22T14:39:57Z
    
    Okay. That wasn't what i got from reading the comment :)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-22T14:44:27Z
    
    @stof Updated.
    fabpot committed Aug 22, 2012
  2. merged branch goohib/fix-form-component-typo (PR #5323)

    Commits
    -------
    
    bca68ca Fixed a typo
    
    Discussion
    ----------
    
    Fixed a typo
    
    The CSRF error message won't be translated due to this typo even if the translator is enabled.
    fabpot committed Aug 22, 2012