Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 22, 2012
  1. @nomack84

    Code cleanup

    nomack84 authored
Commits on Oct 20, 2012
  1. @fabpot

    Nsdocblocks

    Drak authored fabpot committed
Commits on Oct 18, 2012
  1. @fabpot

    Merge branch '2.0' into 2.1

    fabpot authored
    * 2.0:
      [Form] Fixed creation of multiple money fields with different currencies
      Fixed IPv6 Check in RequestMatcher
      fixed DomCrwaler/Form to handle <button> when submitted
    
    Conflicts:
    	tests/Symfony/Tests/Component/DomCrawler/FormTest.php
    	tests/Symfony/Tests/Component/Form/Extension/Core/Type/MoneyTypeTest.php
  2. @ErikSaunier @fabpot

    Delete use of CreationExeption

    ErikSaunier authored fabpot committed
    CreationException not used
  3. @fabpot

    merged branch bschussek/issue5388 (PR #5778)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    bda29b3 [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature
    
    Discussion
    ----------
    
    [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5388
    Todo: -
    License of the code: MIT
    Documentation PR: -
  4. @webmozart
  5. @webmozart
  6. @webmozart
Commits on Oct 10, 2012
  1. @marekkalnik
Commits on Oct 4, 2012
  1. @igorw
Commits on Oct 3, 2012
  1. @fabpot

    merged branch bschussek/issue5578 (PR #5655)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    2568432 [Form] Hardened code of ViolationMapper against errors
    
    Discussion
    ----------
    
    [Form] Hardened code of ViolationMapper against errors
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    This ticket improves the code of ViolationMapper to reduce the risk of bugs and in order to make further bug fixing easier. It was implemented while trying to solve #5578 and is semantically equivalent to the previous version.
  2. @webmozart
Commits on Oct 2, 2012
  1. @webmozart
Commits on Sep 25, 2012
  1. @stof
Commits on Sep 19, 2012
  1. @fabpot
Commits on Sep 10, 2012
  1. @fabpot
Commits on Aug 31, 2012
  1. @webmozart
Commits on Aug 30, 2012
  1. @fabpot

    merged branch mpiecko/master (PR #5280)

    fabpot authored
    Commits
    -------
    
    58ebd1b [Form] Fixed error bubbling from DateTime widget - Issue #5270
    8ea1607 Update src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
    
    Discussion
    ----------
    
    [Form] Fixed error bubbling from DateTime widget - Issue #5270
    
    This is related to symfony/symfony#5270
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-16T19:37:45Z
    
    Travisbot shows something like this in it's log:
    
        [Composer\Downloader\TransportException] The "http://nodeload.github.com/phingofficial/phing/zipball/2.4.12" file could not be downloaded (HTTP/1.1 500 Internal Server Error)
    
    So is it my PR ot Travis CI who fails ... ? I saw this error in some other PR's ...
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-08-16T20:40:39Z
    
    It's GitHub =)
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T09:36:31Z
    
    Bad GitHub :)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-17T11:21:39Z
    
    Could you please add a test to DateTimeTypeTest?
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T12:23:40Z
    
    Sure!
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-30T08:20:08Z
    
    :+1:
Commits on Aug 29, 2012
  1. @fabpot

    merged branch Tobion/formexception (PR #5337)

    fabpot authored
    Commits
    -------
    
    eb2eba1 [Form] don't allow users to force exceptions by submitting unexpected data
    
    Discussion
    ----------
    
    [Form] don't allow users to force exceptions by submitting unexpected data
    
    fix #5334
    
    This makes it more fault-tolerant by simply ignoring wrong stuff from hackers.
    
    @bschussek: I didn't find any other UnexpectedTypeExceptions that could be invoked by simply submitting unexpected data. But I'm not 100% sure that there aren't any indirectly invokeable, e.g. in some listeners.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T22:34:52Z
    
    a test is missing for this.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-24T23:02:26Z
    
    @stof true, I will add one
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-25T13:51:23Z
    
    Added test.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:07:37Z
    
    :+1:
    
    Could you please squash the commits?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-29T13:43:52Z
    
    Done.
  2. @Tobion

    [Form] don't allow users to force exceptions by submitting unexpected…

    Tobion authored
    … data
    
    this makes it more fault-tolerant by simply ignoring wrong stuff from hackers
    
    [Form] added test to ensure binding of wrong data is ignored
  3. @fabpot

    merged branch Tobion/formincon (PR #5355)

    fabpot authored
    Commits
    -------
    
    7e8ab54 [Form] raise OutOfBoundsException instead of InvalidArgumentException for inexistent form childs to be in line with PropertyPath
    
    Discussion
    ----------
    
    [Form] raise OutOfBoundsException instead of InvalidArgumentException in Form::get
    
    BC break: yes
    
    Raise OutOfBoundsException instead of InvalidArgumentException in Form::get for inexistent form childs to be in line with PropertyPath, which also uses OutOfBoundsException for invalid indexes. OutOfBoundsException fits much better as it extends RuntimeException instead of LogicException and this error can typically not be detected at compile time.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:01:01Z
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-08-29T11:07:51Z
    
    Shouldn't this change be noted in upgrade file ?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-29T11:23:04Z
    
    it should (and in the changelog of the component)
  4. @fabpot

    merged branch Tobion/formguess (PR #5361)

    fabpot authored
    Commits
    -------
    
    e7e39e0 [Form] refactor Guess
    dcbeeb1 [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess
    
    Discussion
    ----------
    
    [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess
    
    BC break: yes
    
    this is a better fit because the error is a logic exception (that can be detected at compile time, i.e. when writing the code) instead of a runtime exception
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T10:51:54Z
    
    :+1:
  5. @fabpot

    merged branch Tobion/formhasparent (PR #5360)

    fabpot authored
    Commits
    -------
    
    0186731 [Form] removed hasParent from FormInterface and deprecated its use
    
    Discussion
    ----------
    
    [Form] removed hasParent from FormInterface and deprecated its use
    
    There are already 2 alternatives with getParent() and isRoot(), so a third one with similar semantics is confusing and unneeded.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:11:11Z
    
    :+1:
  6. @fabpot

    merged branch Tobion/formrefactor (PR #5338)

    fabpot authored
    Commits
    -------
    
    492c990 [Form] optimized PropertyPathMapper to invoke the expensive property path less often
    47a8bbd [Form] optimized the binding of child forms and calculation of extra data
    8d45539 [Form] refactor Form::bind to save 7 assignments
    
    Discussion
    ----------
    
    [Form] refactor Form::bind to save 7 assignments and a complete loop
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T23:45:18Z
    
    the new code is not equivalent. See travis for the proof.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-25T01:50:41Z
    
    @stof fixed, I had to reduce the refactoring a little
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:05:52Z
    
    :+1:
  7. @fabpot

    merged branch Tobion/formhaserrors (PR #5356)

    fabpot authored
    Commits
    -------
    
    d5eb4f7 [Form] fix phpdoc of Form::hasErrors
    5cb8264 [Form] deprecated Form::hasErrors that isn't part of the Interface
    
    Discussion
    ----------
    
    [Form] deprecated Form::hasErrors that isn't part of the Interface
    
    This method is not part of FormInterface, so I deprecated it as it cannot be used reliably. This is consistent with other hassers that were deprecated like `hasChildren` where one should use `count` instead.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-26T19:11:19Z
    
    You should deprecate it, not remove it
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-26T19:17:35Z
    
    oh right. I thought it was added in 2.1 and thus can be removed but it's also in 2.0.
    Done.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T11:00:32Z
    
    :+1:
  8. @fabpot

    merged branch Tobion/formparent (PR #5357)

    fabpot authored
    Commits
    -------
    
    30c1457 [Form] fixed Form::setParent(null)
    214f0de [Form] added test with null parent
    
    Discussion
    ----------
    
    [Form] fixed Form::setParent(null)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-29T10:58:20Z
    
    :+1:
  9. @dcsg

    minor correction

    dcsg authored
Commits on Aug 28, 2012
  1. @fabpot

    merged branch pitiflautico/patch-1 (PR #5372)

    fabpot authored
    Commits
    -------
    
    7fc8fc0 [Form] Fix double semicolon
    
    Discussion
    ----------
    
    [Form] Fix double semicolon
  2. @pitiflautico
  3. @acasademont
  4. @Tobion

    [Form] raise OutOfBoundsException instead of InvalidArgumentException…

    Tobion authored
    … for inexistent form childs to be in line with PropertyPath
  5. @Tobion

    [Form] removed hasParent from FormInterface and deprecated its use

    Tobion authored
    There are already 2 alternatives with getParent() and isRoot(), so a third one with similar semantics is confusing and unneeded.
  6. @Tobion

    [Form] refactor Guess

    Tobion authored
  7. @Tobion

    [Form] replaced UnexpectedValueException by InvalidArgumentException …

    Tobion authored
    …in Guess
    
    this is a better fit because the error is a logic exception instead of a runtime exception
  8. @fabpot

    merged branch Tobion/formdoc (PR #5350)

    fabpot authored
    Commits
    -------
    
    83dc966 [Form] Fixed some PHPDoc
    596bbb1 [Form] fixed FormConfigBuilder to use PropertyPathInterface
    a523823 [Form] fixed and added phpDoc
    
    Discussion
    ----------
    
    [Form] fixed and added phpDoc
    
    [ci skip]
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-08-26T08:11:01Z
    
    Some descriptions don''t seem to be properly aligned, use the CS-fixer.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-26T17:02:25Z
    
    @sstok This is more about manual fixes concerning forgotten exceptions or wrong data type. The cs fixer gives many false positives and can be applied later.
Something went wrong with that request. Please try again.