Permalink
Commits on Nov 29, 2012
  1. @fabpot

    Merge branch '2.0' into 2.1

    * 2.0:
      [DependencyInjection] fixed composer.json
      [Form] Updated checks for the ICU version from 4.5+ to 4.7+ due to test failures with ICU 4.6
      fixed CS
      small fix of #5984 when the container param is not set
      fixed CS
      Use better default ports in urlRedirectAction
      Add tests for urlRedirectAction
      Update src/Symfony/Component/DomCrawler/Tests/FormTest.php
      Update src/Symfony/Component/DomCrawler/Form.php
      [Security] remove escape charters from username provided by Digest DigestAuthenticationListener
      [Security] added test extra for digest authentication
      fixed CS
      [Security] Fixed digest authentication
      [Security] Fixed digest authentication
      [SecurityBundle] Convert Http method to uppercase in the config
      Use Norm Data instead of Data
    
    Conflicts:
    	src/Symfony/Bridge/Doctrine/Form/EventListener/MergeCollectionListener.php
    	src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
    	src/Symfony/Component/DependencyInjection/composer.json
    fabpot committed Nov 29, 2012
Commits on Nov 25, 2012
  1. @fabpot

    merged branch bicpi/add_hasser_hint (PR #6110)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    06ee53b [Form] improve error message with a "hasser" hint for PropertyAccessDeniedException
    
    Discussion
    ----------
    
    [Form] improve error msg w/ a "hasser" hint for PropertyAccessDeniedException
    
    "Hasser" support was added under the 2.1 branch of the Form component
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: no, but fails exactly the same as without this fix
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: symfony/symfony-docs#1958
    fabpot committed Nov 25, 2012
Commits on Nov 24, 2012
  1. @RoumenDamianoff

    Updated Bulgarian translation

    Added Bulgarian translation for form component.
    Updated Bulgarian translation for validator messages.
    RoumenDamianoff committed Nov 24, 2012
  2. @bicpi

    [Form] improve error message with a "hasser" hint for PropertyAccessD…

    …eniedException
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: no, but fails exactly the same as without this fix
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: symfony/symfony-docs#1958
    bicpi committed Nov 24, 2012
  3. @fabpot
  4. @stfalcon @fabpot
  5. @fabpot

    merged branch bamarni/preloaded-extension (PR #5479)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    84635bd [Form] allowed no type guesser to be registered
    
    Discussion
    ----------
    
    [Form] made the factory builder pass null when no type guesser registered
    
    reopened #5422 against 2.1 as it's a bug fix
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-10-13T21:23:34Z
    
    @fabpot anything left for this PR ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-10-14T09:41:29Z
    
    @bamarni Can you add some unit tests and also update the FormExtensionInterface interface phpdoc as `getTypeGuesser` can now return `null`? Thanks. ping @bschussek
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-10-14T17:10:27Z
    
    I've added a few tests covering this.
    
    @fabpot : the phpdoc is already correct, it currently can return null, this only occurs with this convenient class.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-10-16T07:43:41Z
    
    This PR breaks FormFactory::createBuilderForProperty(), which expects a guesser to be present. Can you check the component for other uses of the guesser and add a null-check there?
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-10-16T10:57:54Z
    
    I cannot find other places than the factory (searching for 'getTypeGuesser').
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-11-08T16:58:37Z
    
    You should also adapt `FormRegistry::getTypeGuesser()` not to build a `FormTypeGuesserChain` if the array of guessers is empty. In that case it will return now `null` (adapt the doc block). We also need a different was of checking if the type guessers have already been parsed in FormRegistry. Otherwise the first if condition in `FormRegistry::getTypeGuesser()` will never become false. You could for example initialize the property `$guesser` to `false` and only set it to `null` after the first run of `getTypeGuesser()`.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-11-08T18:40:00Z
    
    good catch I had missed it! I've applied your suggestion in the latest commit. Do you see anything else before I squash?
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-11-08T18:45:15Z
    
    A test for `FormRegistry::getTypeGuesser()` would of course be awesome.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-11-08T18:52:13Z
    
    Then it was already awesome! (see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Tests/FormRegistryTest.php#L252)
    
    I've also added one for the null case if it's what you meant.
    fabpot committed Nov 24, 2012
Commits on Nov 10, 2012
  1. @pvanliefland @fabpot
Commits on Nov 9, 2012
  1. @webmozart

    [Form] Removed an exception that prevented valid formats from being p…

    …assed, e.g. "h" for the hour, "L" for the month etc.
    webmozart committed Nov 9, 2012
  2. @bamarni
  3. @fabpot

    merged branch gajdaw/gitattributes-windows (PR #5938)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    646a714 Fix export-ignore on Windows
    
    Discussion
    ----------
    
    Fix export-ignore on Windows
    
    Rules:
    
        Tests/ export-ignore
    
    don't work on Windows. My proposition is:
    
        /Tests export-ignore
    fabpot committed Nov 9, 2012
  4. @fabpot

    merged branch bschussek/issue4359 (PR #5947)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    4909bc3 [Form] Fixed forms not to be marked invalid if their children are already marked invalid
    
    Discussion
    ----------
    
    [Form] Fixed forms not to be marked invalid if their children are already marked invalid
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4359
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    This PR prevents unsynchronized forms from being marked invalid if any of their children is also unsynchronized (and thus also marked invalid). Displaying an invalid message twice does not help the user and, if used in conjunction with error bubbling, may lead to duplicate errors (see #4359).
    fabpot committed Nov 9, 2012
Commits on Nov 8, 2012
  1. @webmozart
  2. @fabpot

    Merge branch '2.0' into 2.1

    * 2.0:
      [Form] Excluded some tests in NumberToLocalizedStringTransformerTest which fail on ICU 4.4, but work on ICU 4.8
    fabpot committed Nov 8, 2012
  3. @fabpot
  4. @fabpot

    Merge branch '2.0' into 2.1

    * 2.0:
      [Form] Fixed NumberToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible
      Show correct class name InputArgument in error message
      shows correct class name InputOption in error message
      The exception message should say which field is not mapped
      [HttpFoundation] Fix name sanitization after perfoming move
      Add check to Store::unlock to ensure file exists
    
    Conflicts:
    	src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
    	src/Symfony/Component/HttpFoundation/File/UploadedFile.php
    	tests/Symfony/Tests/Component/Console/Input/InputArgumentTest.php
    	tests/Symfony/Tests/Component/Console/Input/InputOptionTest.php
    	tests/Symfony/Tests/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
    	tests/Symfony/Tests/Component/HttpFoundation/File/FileTest.php
    	tests/Symfony/Tests/Component/HttpKernel/HttpCache/StoreTest.php
    fabpot committed Nov 8, 2012
  5. @webmozart

    [Form] Fixed NumberToLocalizedStringTransformer to accept both comma …

    …and dot as decimal separator, if possible
    webmozart committed Nov 8, 2012
  6. @gajdaw

    Fix export-ignore on Windows

    gajdaw committed Nov 8, 2012
Commits on Nov 4, 2012
  1. @fabpot

    removed unused use statements

    fabpot committed Nov 4, 2012
Commits on Nov 2, 2012
  1. @webmozart
Commits on Oct 22, 2012
  1. @alvarezmario

    Code cleanup

    alvarezmario committed Oct 22, 2012
Commits on Oct 20, 2012
  1. @fabpot

    Nsdocblocks

    Drak committed with fabpot Oct 19, 2012
Commits on Oct 18, 2012
  1. @fabpot

    Merge branch '2.0' into 2.1

    * 2.0:
      [Form] Fixed creation of multiple money fields with different currencies
      Fixed IPv6 Check in RequestMatcher
      fixed DomCrwaler/Form to handle <button> when submitted
    
    Conflicts:
    	tests/Symfony/Tests/Component/DomCrawler/FormTest.php
    	tests/Symfony/Tests/Component/Form/Extension/Core/Type/MoneyTypeTest.php
    fabpot committed Oct 18, 2012
  2. @ErikSaunier @fabpot

    Delete use of CreationExeption

    CreationException not used
    ErikSaunier committed with fabpot Oct 18, 2012
  3. @fabpot

    merged branch bschussek/issue5388 (PR #5778)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    bda29b3 [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature
    
    Discussion
    ----------
    
    [Form] Fixed error message in PropertyPath to not advice to use a non-existing feature
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5388
    Todo: -
    License of the code: MIT
    Documentation PR: -
    fabpot committed Oct 18, 2012
  4. @webmozart
  5. @webmozart
  6. @webmozart
Commits on Oct 10, 2012
  1. @marekkalnik
Commits on Oct 4, 2012
  1. @igorw
Commits on Oct 3, 2012
  1. @fabpot

    merged branch bschussek/issue5578 (PR #5655)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    2568432 [Form] Hardened code of ViolationMapper against errors
    
    Discussion
    ----------
    
    [Form] Hardened code of ViolationMapper against errors
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    This ticket improves the code of ViolationMapper to reduce the risk of bugs and in order to make further bug fixing easier. It was implemented while trying to solve #5578 and is semantically equivalent to the previous version.
    fabpot committed Oct 3, 2012
  2. @webmozart
Commits on Oct 2, 2012
  1. @webmozart
Commits on Sep 25, 2012
  1. @stof
Commits on Sep 19, 2012
  1. @fabpot