Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Dec 15, 2012
  1. @webmozart @fabpot

    Fixed failing test

    webmozart authored fabpot committed
Commits on Dec 14, 2012
  1. @webmozart
Commits on Dec 13, 2012
  1. @webmozart

    [Form] Fixed reverse transformation of values in DateTimeToStringTran…

    webmozart authored
    …sformer
    
    The parts not given in the format are reset to the corresponding values of
    the UNIX base timestamp. For example, when parsing with the format "Y-m-d",
    parsing
    
        "2012-05-18"
    
    now results in the date
    
        "2012-05-18 00:00:00 UTC"
    
    instead of
    
        "2012-05-18 12:58:27 UTC"
    
    as before, where the time part corresponded to the local server time.
    
    Another example: When parsing with the format "H:i:s", parsing
    
        "12:58:27"
    
    now results in
    
        "1970-01-01 12:58:27 UTC"
    
    instead of
    
        "2012-12-13 12:58:27 UTC"
    
    as before, where again the date part corresponded to the local server time.
    
    This behavior is now consistent with DateTimeToArrayTransformer and
    DateTimeToLocalizedStringTransformer.
  2. @webmozart
  3. @webmozart
Commits on Dec 11, 2012
  1. @fabpot

    fixed CS

    fabpot authored
  2. @fabpot

    removed unneeded comment

    fabpot authored
  3. @kaywalker @fabpot

    Fix to allow null values in labels array

    kaywalker authored fabpot committed
Commits on Dec 9, 2012
  1. @franmomu
Commits on Dec 7, 2012
  1. @fabpot

    merged branch bschussek/issue6141_2 (PR #6217)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    6e7e08f [Form] Fixed the default value of "format" in DateType to DateType::DEFAULT_FORMAT if "widget" is not "single_text"
    
    Discussion
    ----------
    
    [Form] Fixed the "format" option in DateType
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #6141
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    This PR fixes a regression introduced in #4839. To quote that PR:
    
    > This PR changes DateType and DateTimeType to support HTML5 by default when setting the option "widget" to "single_text".
    
    In reality, the "format" option now defaults to the HTML5 format always, not just when "widget" is "single_text". This is fixed here.
    
    The second commit in this PR removes special characters between select/text fields. What, with German locale, was
    
    ```
    <day input>.<month input>.<year input>
    ```
    
    before is now
    
    ```
    <day input><month input><year input>
    ```
    
    This is the way date fields are represented on the majority of websites. If you *need* separators, you can have them by setting the "format" option to a custom value:
    
    ```php
    $builder->add('myDate', 'date', array(
        'format' => 'dd.MM.yyyy',
    ));
    ```
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-12-07T08:52:21Z
    
    The second commit should probably be done on master and it changes the behavior.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-12-07T12:23:22Z
    
    Ok, I removed the second commit now and removed the entries from the CHANGELOG.
  2. @webmozart

    [Form] Fixed the default value of "format" in DateType to DateType::D…

    webmozart authored
    …EFAULT_FORMAT if "widget" is not "single_text"
Commits on Dec 6, 2012
  1. @hason
Commits on Nov 29, 2012
  1. @fabpot

    Merge branch '2.0' into 2.1

    fabpot authored
    * 2.0:
      [DependencyInjection] fixed composer.json
      [Form] Updated checks for the ICU version from 4.5+ to 4.7+ due to test failures with ICU 4.6
      fixed CS
      small fix of #5984 when the container param is not set
      fixed CS
      Use better default ports in urlRedirectAction
      Add tests for urlRedirectAction
      Update src/Symfony/Component/DomCrawler/Tests/FormTest.php
      Update src/Symfony/Component/DomCrawler/Form.php
      [Security] remove escape charters from username provided by Digest DigestAuthenticationListener
      [Security] added test extra for digest authentication
      fixed CS
      [Security] Fixed digest authentication
      [Security] Fixed digest authentication
      [SecurityBundle] Convert Http method to uppercase in the config
      Use Norm Data instead of Data
    
    Conflicts:
    	src/Symfony/Bridge/Doctrine/Form/EventListener/MergeCollectionListener.php
    	src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
    	src/Symfony/Component/DependencyInjection/composer.json
Commits on Nov 25, 2012
  1. @fabpot

    merged branch bicpi/add_hasser_hint (PR #6110)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    06ee53b [Form] improve error message with a "hasser" hint for PropertyAccessDeniedException
    
    Discussion
    ----------
    
    [Form] improve error msg w/ a "hasser" hint for PropertyAccessDeniedException
    
    "Hasser" support was added under the 2.1 branch of the Form component
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: no, but fails exactly the same as without this fix
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: symfony/symfony-docs#1958
Commits on Nov 24, 2012
  1. @RoumenDamianoff

    Updated Bulgarian translation

    RoumenDamianoff authored
    Added Bulgarian translation for form component.
    Updated Bulgarian translation for validator messages.
  2. @bicpi

    [Form] improve error message with a "hasser" hint for PropertyAccessD…

    bicpi authored
    …eniedException
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: no, but fails exactly the same as without this fix
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: symfony/symfony-docs#1958
  3. @fabpot
  4. @stfalcon @fabpot
  5. @fabpot

    merged branch bamarni/preloaded-extension (PR #5479)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    84635bd [Form] allowed no type guesser to be registered
    
    Discussion
    ----------
    
    [Form] made the factory builder pass null when no type guesser registered
    
    reopened #5422 against 2.1 as it's a bug fix
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-10-13T21:23:34Z
    
    @fabpot anything left for this PR ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-10-14T09:41:29Z
    
    @bamarni Can you add some unit tests and also update the FormExtensionInterface interface phpdoc as `getTypeGuesser` can now return `null`? Thanks. ping @bschussek
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-10-14T17:10:27Z
    
    I've added a few tests covering this.
    
    @fabpot : the phpdoc is already correct, it currently can return null, this only occurs with this convenient class.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-10-16T07:43:41Z
    
    This PR breaks FormFactory::createBuilderForProperty(), which expects a guesser to be present. Can you check the component for other uses of the guesser and add a null-check there?
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-10-16T10:57:54Z
    
    I cannot find other places than the factory (searching for 'getTypeGuesser').
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-11-08T16:58:37Z
    
    You should also adapt `FormRegistry::getTypeGuesser()` not to build a `FormTypeGuesserChain` if the array of guessers is empty. In that case it will return now `null` (adapt the doc block). We also need a different was of checking if the type guessers have already been parsed in FormRegistry. Otherwise the first if condition in `FormRegistry::getTypeGuesser()` will never become false. You could for example initialize the property `$guesser` to `false` and only set it to `null` after the first run of `getTypeGuesser()`.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-11-08T18:40:00Z
    
    good catch I had missed it! I've applied your suggestion in the latest commit. Do you see anything else before I squash?
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-11-08T18:45:15Z
    
    A test for `FormRegistry::getTypeGuesser()` would of course be awesome.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-11-08T18:52:13Z
    
    Then it was already awesome! (see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Tests/FormRegistryTest.php#L252)
    
    I've also added one for the null case if it's what you meant.
Commits on Nov 10, 2012
  1. @pvanliefland @fabpot

    Fixed singularization of "prices"

    pvanliefland authored fabpot committed
Commits on Nov 9, 2012
  1. @webmozart

    [Form] Removed an exception that prevented valid formats from being p…

    webmozart authored
    …assed, e.g. "h" for the hour, "L" for the month etc.
  2. @bamarni
  3. @fabpot

    merged branch gajdaw/gitattributes-windows (PR #5938)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    646a714 Fix export-ignore on Windows
    
    Discussion
    ----------
    
    Fix export-ignore on Windows
    
    Rules:
    
        Tests/ export-ignore
    
    don't work on Windows. My proposition is:
    
        /Tests export-ignore
  4. @fabpot

    merged branch bschussek/issue4359 (PR #5947)

    fabpot authored
    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    4909bc3 [Form] Fixed forms not to be marked invalid if their children are already marked invalid
    
    Discussion
    ----------
    
    [Form] Fixed forms not to be marked invalid if their children are already marked invalid
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4359
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    This PR prevents unsynchronized forms from being marked invalid if any of their children is also unsynchronized (and thus also marked invalid). Displaying an invalid message twice does not help the user and, if used in conjunction with error bubbling, may lead to duplicate errors (see #4359).
Commits on Nov 8, 2012
  1. @webmozart
  2. @fabpot

    Merge branch '2.0' into 2.1

    fabpot authored
    * 2.0:
      [Form] Excluded some tests in NumberToLocalizedStringTransformerTest which fail on ICU 4.4, but work on ICU 4.8
  3. @fabpot
  4. @fabpot

    Merge branch '2.0' into 2.1

    fabpot authored
    * 2.0:
      [Form] Fixed NumberToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible
      Show correct class name InputArgument in error message
      shows correct class name InputOption in error message
      The exception message should say which field is not mapped
      [HttpFoundation] Fix name sanitization after perfoming move
      Add check to Store::unlock to ensure file exists
    
    Conflicts:
    	src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
    	src/Symfony/Component/HttpFoundation/File/UploadedFile.php
    	tests/Symfony/Tests/Component/Console/Input/InputArgumentTest.php
    	tests/Symfony/Tests/Component/Console/Input/InputOptionTest.php
    	tests/Symfony/Tests/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
    	tests/Symfony/Tests/Component/HttpFoundation/File/FileTest.php
    	tests/Symfony/Tests/Component/HttpKernel/HttpCache/StoreTest.php
  5. @webmozart

    [Form] Fixed NumberToLocalizedStringTransformer to accept both comma …

    webmozart authored
    …and dot as decimal separator, if possible
  6. @gajdaw

    Fix export-ignore on Windows

    gajdaw authored
Commits on Nov 4, 2012
  1. @fabpot

    removed unused use statements

    fabpot authored
Commits on Nov 2, 2012
  1. @webmozart
Commits on Oct 22, 2012
  1. @nomack84

    Code cleanup

    nomack84 authored
Commits on Oct 20, 2012
  1. @fabpot

    Nsdocblocks

    Drak authored fabpot committed
Commits on Oct 18, 2012
  1. @fabpot

    Merge branch '2.0' into 2.1

    fabpot authored
    * 2.0:
      [Form] Fixed creation of multiple money fields with different currencies
      Fixed IPv6 Check in RequestMatcher
      fixed DomCrwaler/Form to handle <button> when submitted
    
    Conflicts:
    	tests/Symfony/Tests/Component/DomCrawler/FormTest.php
    	tests/Symfony/Tests/Component/Form/Extension/Core/Type/MoneyTypeTest.php
Something went wrong with that request. Please try again.