Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Apr 18, 2014

  1. Fabien Potencier

    Merge branch '2.4'

    * 2.4:
      unified return null usages
      [Validator] added Japanese translation
      Textarea value should default to empty string instead of null.
      Fix doc blocks
      [Process] Fix #10681, process are failing on Windows Server 2003
      updated doc
      [Security] fix DBAL connection typehint
      [HttpFoundation] status 201 is allowed to have a body
      unified return null usages
    
    Conflicts:
    	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
    	src/Symfony/Component/DomCrawler/Crawler.php
    	src/Symfony/Component/Security/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
    authored April 18, 2014
  2. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      Textarea value should default to empty string instead of null.
      Fix doc blocks
      [Process] Fix #10681, process are failing on Windows Server 2003
      [Security] fix DBAL connection typehint
      [HttpFoundation] status 201 is allowed to have a body
      unified return null usages
    
    Conflicts:
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php
    authored April 18, 2014

Apr 17, 2014

  1. Romain Neutron

    [Process] Fix #10681, process are failing on Windows Server 2003

    authored April 17, 2014

Apr 16, 2014

  1. Fabien Potencier

    fixed types in phpdocs

    authored April 16, 2014
  2. Fabien Potencier

    Merge branch '2.4'

    * 2.4:
      fixed types in phpdocs
      fixed types in phpdocs
    
    Conflicts:
    	src/Symfony/Component/Security/Core/Encoder/BasePasswordEncoder.php
    	src/Symfony/Component/Security/Http/RememberMe/TokenBasedRememberMeServices.php
    	src/Symfony/Component/Serializer/Encoder/JsonEncoder.php
    	src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
    	src/Symfony/Component/Validator/Mapping/ClassMetadata.php
    	src/Symfony/Component/Validator/Mapping/ElementMetadata.php
    	src/Symfony/Component/Validator/Mapping/MemberMetadata.php
    	src/Symfony/Component/Validator/MetadataFactoryInterface.php
    authored April 16, 2014
  3. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      fixed types in phpdocs
    
    Conflicts:
    	src/Symfony/Bridge/Twig/TwigEngine.php
    	src/Symfony/Bundle/FrameworkBundle/Templating/Loader/FilesystemLoader.php
    	src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
    	src/Symfony/Component/Form/Extension/Core/ChoiceList/SimpleChoiceList.php
    	src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
    	src/Symfony/Component/HttpKernel/Controller/ControllerResolverInterface.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessorBuilder.php
    	src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
    	src/Symfony/Component/Stopwatch/StopwatchEvent.php
    	src/Symfony/Component/Templating/PhpEngine.php
    authored April 16, 2014
  4. Fabien Potencier

    fixed types in phpdocs

    authored April 16, 2014
  5. Fabien Potencier

    made types consistent with those defined in Hack

    authored April 16, 2014
  6. Fabien Potencier

    Merge branch '2.4'

    * 2.4:
      made types consistent with those defined in Hack
      made {@inheritdoc} annotations consistent across the board
      made {@inheritdoc} annotations consistent across the board
      fixed types in phpdocs
      [Debug] Fixed ClassNotFoundFatalErrorHandler on windows.
      made phpdoc types consistent with those defined in Hack
      Add support Thai translations
      [Validator] Add missing czech translations
      made types consistent with those defined in Hack
      removed extra/unsupported arguments
      [HttpKernel] fixed an error message
      [TwigBundle] removed undefined argument
      [Translation] Make IcuDatFileLoader/IcuResFileLoader::load invalid resource compatible with HHVM.
    
    Conflicts:
    	src/Symfony/Component/Console/Helper/TableHelper.php
    	src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
    	src/Symfony/Component/Form/FormError.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/Process/ProcessPipes.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessor.php
    	src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php
    	src/Symfony/Component/Security/Http/RememberMe/TokenBasedRememberMeServices.php
    	src/Symfony/Component/Translation/Dumper/FileDumper.php
    	src/Symfony/Component/Validator/ConstraintViolation.php
    	src/Symfony/Component/Validator/Constraints/EmailValidator.php
    	src/Symfony/Component/Validator/ExecutionContextInterface.php
    	src/Symfony/Component/Validator/Mapping/BlackholeMetadataFactory.php
    authored April 16, 2014
  7. Fabien Potencier

    made types consistent with those defined in Hack

    authored April 16, 2014
  8. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      made {@inheritdoc} annotations consistent across the board
      fixed types in phpdocs
      made phpdoc types consistent with those defined in Hack
      Add support Thai translations
      made types consistent with those defined in Hack
      removed extra/unsupported arguments
      [HttpKernel] fixed an error message
      [TwigBundle] removed undefined argument
      [Translation] Make IcuDatFileLoader/IcuResFileLoader::load invalid resource compatible with HHVM.
    
    Conflicts:
    	src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Fixtures/php/lazy_service.php
    	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Templating/Loader/FilesystemLoader.php
    	src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php
    	src/Symfony/Component/Config/Definition/ReferenceDumper.php
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/Debug/ErrorHandler.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataMapper/PropertyPathMapperTest.php
    	src/Symfony/Component/HttpFoundation/Response.php
    	src/Symfony/Component/HttpFoundation/StreamedResponse.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
    	src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
    	src/Symfony/Component/HttpKernel/Fragment/RoutableFragmentRenderer.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
    	src/Symfony/Component/Stopwatch/StopwatchPeriod.php
    	src/Symfony/Component/Translation/TranslatorInterface.php
    	src/Symfony/Component/Validator/ConstraintValidatorFactory.php
    authored April 16, 2014
  9. Fabien Potencier

    fixed types in phpdocs

    authored April 16, 2014

Apr 15, 2014

  1. Fabien Potencier

    made phpdoc types consistent with those defined in Hack

    authored April 12, 2014

Apr 13, 2014

  1. Fabien Potencier

    made types consistent with those defined in Hack

    authored April 12, 2014

Apr 03, 2014

  1. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      Revert PHPUnit version, revert APC configuration
      removed APC on the CLI for Travis as it does not work well with PHPUnit and Composer anyway
      [Security] Replace exception mocks with actual exception instances.
      Remove an unused argument.
      Use `Filesystem::chmod` instead of `chmod` when dumping file
      [Form] Added test for disabling buttons
      [Form] Added check for parent disabled status in Button form elements
      Fixes URL validator to accept single part urls
      tweaked Travis configuration to get more tests running
      fixed float comparison in unit tests for HHVM
      upgraded PHPUnit to version 4 for better HHVM support
      [Process] fixed HHVM usage on the CLI
      Fix class names in ApcUniversalClassLoader tests.
      fixed the profiler when an uncalled listener throws an exception when instantiated
      fixed CS
      Added test case for 4c6a2d1
      Fixed bug in ChoiceType triggering a warning when not using utf-8
      fixed CS
      Avoid levenshtein comparison when using ContainerBuilder.
    
    Conflicts:
    	src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    authored April 03, 2014

Mar 31, 2014

  1. Romain Neutron

    [Process] Fix Process test suite

    authored March 31, 2014

Mar 30, 2014

  1. Fabien Potencier

    [Process] fixed HHVM usage on the CLI

    authored March 29, 2014

Mar 26, 2014

  1. Fabien Potencier

    Merge branch '2.4'

    * 2.4: (52 commits)
      Fix #8205 : Deprecate file mode update when calling dumpFile
      Fix #10437: Catch exceptions when reloading a no-cache request
      Fix libxml_use_internal_errors and libxml_disable_entity_loader usage
      removed ini check to make uploadedfile work on gae
      Update OptionsResolver.php
      fixed comment in forms.xml file
      Clean KernelInterface docblocks
      Cast the group name as a string
      Fixed doc of InitAclCommand
      [Form] Fix "Array was modified outside object" in ResizeFormListener.
      Fix IBAN validator
      [Process] Remove unreachable code + avoid skipping tests in sigchild environment
      Fixed bug that incorrectly causes the "required" attribute to be omitted from select even though it contains the "multiple" attribute
      Added travis_retry to .travis.yml
      [Process] fix some typos and refactor some code
      [Process] Fix unit tests in sigchild disabled environment
      [Process] Trow exceptions in case a Process method is supposed to be called after termination
      fixed typo
      [Process] fixed fatal errors in getOutput and getErrorOutput when process was not started
      [Process] Fix escaping on Windows
      ...
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
    	src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
    	src/Symfony/Component/Process/Process.php
    	src/Symfony/Component/Process/ProcessPipes.php
    	src/Symfony/Component/Process/Tests/AbstractProcessTest.php
    authored March 26, 2014
  2. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3: (34 commits)
      Fix #8205 : Deprecate file mode update when calling dumpFile
      Fix #10437: Catch exceptions when reloading a no-cache request
      Fix libxml_use_internal_errors and libxml_disable_entity_loader usage
      removed ini check to make uploadedfile work on gae
      Update OptionsResolver.php
      fixed comment in forms.xml file
      Clean KernelInterface docblocks
      Cast the group name as a string
      Fixed doc of InitAclCommand
      [Form] Fix "Array was modified outside object" in ResizeFormListener.
      Fix IBAN validator
      [Process] Remove unreachable code + avoid skipping tests in sigchild environment
      Fixed bug that incorrectly causes the "required" attribute to be omitted from select even though it contains the "multiple" attribute
      Added travis_retry to .travis.yml
      [Process] fix some typos and refactor some code
      [Process] Fix unit tests in sigchild disabled environment
      [Process] Trow exceptions in case a Process method is supposed to be called after termination
      fixed typo
      [Process] fixed fatal errors in getOutput and getErrorOutput when process was not started
      [Process] Fix escaping on Windows
      ...
    
    Conflicts:
    	src/Symfony/Component/DomCrawler/Crawler.php
    	src/Symfony/Component/Filesystem/Filesystem.php
    	src/Symfony/Component/Process/Process.php
    authored March 26, 2014

Mar 25, 2014

  1. Baptiste Clavié

    When a process fails, check if the output is enabled

    With the recent addition of the ability to disable the output, it was
    not taken into account within the `ProcessFailedException`.
    
    So, if the output was indeed disabled, and the process returns an
    error (i.e via a `mustRun`) we could have another LogicException which
    is not expected.
    authored March 25, 2014 fabpot committed March 25, 2014

Mar 19, 2014

  1. Fabien Potencier

    minor #10492 [2.3][Process] Remove unreachable code + avoid skipping …

    …tests in sigchild environment (romainneutron)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3][Process] Remove unreachable code + avoid skipping tests in sigchild environment
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    As mentioned by @Tobion in symfony/symfony#10480 (comment), I removed the dead code. I also fixed/updated the test suite on PHP compiled with `--enable-sigchild`.
    
    Commits
    -------
    
    d52dd32 [Process] Remove unreachable code + avoid skipping tests in sigchild environment
    authored March 19, 2014
  2. Romain Neutron

    [Process] Remove unreachable code + avoid skipping tests in sigchild …

    …environment
    authored March 19, 2014
  3. Fabien Potencier

    minor #10484 [Process] fix some typos and refactor some code (Tobion)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Process] fix some typos and refactor some code
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    
    Commits
    -------
    
    b422613 [Process] fix some typos and refactor some code
    authored March 19, 2014
  4. Fabien Potencier

    bug #10479 [2.3][Process] Fix escaping on Windows (romainneutron)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3][Process] Fix escaping on Windows
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    Windows escaping is broken since the last merges.
    
    After digging more on Windows escaping, I realised some things:
     - We forbid environment variable expansion by escaping `%APPDATA%` to `^%"APPDATA"^%`
     - We explicitly ask for variable expansion at runtime (running the command line with the [`/V:ON`](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Process/Process.php#L235) flag). Running a command containing `!APPDATA!` will be escaped and expanded (our previous rule is easily overriden)
     - On platform that are not windows, we use strong escaping that prevents any variable expansion (`$PATH` will be escaped to `'$PATH'` that is not interpreted as the current PATH)
    
    We have three possibilities:
     - Keep this behavior as this.
     - Prefer a consistent API and use a strong escaping strategy everywhere, but it would result in a BC break (see #8975).
     - Allow environment variable expansion and escape `%APPDATA%` to `"%APPDATA%"`
    
    Any thoughts about this ?
    
    Commits
    -------
    
    0f65f90 [Process] Fix escaping on Windows
    authored March 19, 2014

Mar 18, 2014

  1. Tobias Schultze

    [Process] fix some typos and refactor some code

    authored March 18, 2014
  2. Romain Neutron

    [Process] Fix unit tests in sigchild disabled environment

    authored March 18, 2014
  3. Fabien Potencier

    bug #10480 [Process] Fixed fatal errors in getOutput and getErrorOutp…

    …ut when process was not started (romainneutron)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Process] Fixed fatal errors in getOutput and getErrorOutput when process was not started
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #10022
    | License       | MIT
    
    This PR replaces #9452 and address the latest changes.
    Side note : I've not updated `getExitCode`, `getExitCodeText` and `isSuccessful` as they were explicitly tested to return null in case the process is not started or terminated. I think it would be a BC break to do that.
    
    Commits
    -------
    
    449fe01 [Process] Trow exceptions in case a Process method is supposed to be called after termination
    0ae6858 [Process] fixed fatal errors in getOutput and getErrorOutput when process was not started
    authored March 18, 2014
  4. Romain Neutron

    [Process] Trow exceptions in case a Process method is supposed to be …

    …called after termination
    authored March 18, 2014
  5. Max Voloshin

    [Process] fixed fatal errors in getOutput and getErrorOutput when pro…

    …cess was not started
    authored November 06, 2013 romainneutron committed March 18, 2014
  6. Romain Neutron

    [Process] Fix escaping on Windows

    Windows escaping is broken since the last merges.
    authored March 18, 2014
  7. Romain Neutron

    [Process] Make Process::start non-blocking on Windows platform

    authored March 11, 2014

Mar 14, 2014

  1. Romain Neutron

    [Process] Avoid failures because of slow IOs

    authored March 14, 2014
  2. Romain Neutron

    [Process] Increase tests speed

    authored March 14, 2014
  3. Romain Neutron

    [Process] Handle idle timeout and disable output conflict

    authored March 14, 2014
  4. Romain Neutron

    [Process] Avoid failure because of a slow process

    authored March 14, 2014
Something went wrong with that request. Please try again.