Permalink
Commits on Mar 4, 2017
  1. Merge branch '2.8' into 3.2

    * 2.8:
      [Security] fix Composer constraint
      Provide less state in getRequestFormat
      fix test class location
      Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed
    nicolas-grekas committed Mar 4, 2017
  2. Merge branch '2.7' into 2.8

    * 2.7:
      [Security] fix Composer constraint
      Provide less state in getRequestFormat
      fix test class location
      Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed
    nicolas-grekas committed Mar 4, 2017
Commits on Mar 3, 2017
  1. Static code analysis with Php Inspections (EA Extended): dead code dr…

    …opped, couple bugs fixed
    kalessil committed Mar 3, 2017
Commits on Feb 28, 2017
Commits on Feb 27, 2017
  1. Merge branch '3.2'

    * 3.2:
      [Process] Fix ignoring of bad env var names
    nicolas-grekas committed Feb 27, 2017
Commits on Feb 21, 2017
  1. Merge branch '3.2'

    * 3.2:
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
Commits on Feb 18, 2017
  1. Merge branch '3.2'

    * 3.2:
      Fix typo in process error message
      Update to PHPUnit namespaces
      Minor typo fix messsagesData -> messagesData
      remove translation data collector when not usable
    nicolas-grekas committed Feb 18, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      Update to PHPUnit namespaces
      Minor typo fix messsagesData -> messagesData
      remove translation data collector when not usable
    nicolas-grekas committed Feb 18, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Update to PHPUnit namespaces
      remove translation data collector when not usable
    nicolas-grekas committed Feb 18, 2017
  4. Fix typo in process error message

    kelunik committed with fabpot Feb 18, 2017
  5. Update to PHPUnit namespaces

    peterrehm committed with fabpot Feb 8, 2017
Commits on Feb 16, 2017
  1. Merge branch '3.2'

    * 3.2:
      Permit empty suffix on Windows
      fixed CS
      [FrameworkBundle] Remove unused import
      [Console][Table] fixed render when using multiple rowspans.
      add docblocks for Twig url and path function to improve ide completion
      check for circular refs caused by method calls
      [Serializer] fix upper camel case conversion (see #21399)
      [DI] Auto register extension configuration classes as a resource
      [Console] Updated phpdoc on return types
    fabpot committed Feb 16, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      Permit empty suffix on Windows
      [Console][Table] fixed render when using multiple rowspans.
      add docblocks for Twig url and path function to improve ide completion
      check for circular refs caused by method calls
      [Serializer] fix upper camel case conversion (see #21399)
      [DI] Auto register extension configuration classes as a resource
      [Console] Updated phpdoc on return types
    fabpot committed Feb 16, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Permit empty suffix on Windows
      [Console][Table] fixed render when using multiple rowspans.
      add docblocks for Twig url and path function to improve ide completion
      check for circular refs caused by method calls
      [Serializer] fix upper camel case conversion (see #21399)
      [DI] Auto register extension configuration classes as a resource
      [Console] Updated phpdoc on return types
    fabpot committed Feb 16, 2017
  4. Permit empty suffix on Windows

    Bilge committed with fabpot Feb 14, 2017
Commits on Feb 8, 2017
  1. feature #21474 [Process] Accept command line arrays and per-run env v…

    …ars, fixing signaling and escaping (nicolas-grekas)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [Process] Accept command line arrays and per-run env vars, fixing signaling and escaping
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #12488, #11972, #10025, #11335, #5759, #5030, #19993, #10486
    | License       | MIT
    | Doc PR        | -
    
    I think I found a way to fix this network of issues once for all.
    Of all the linked ones, only the last two are still open: the remaining were closed in dead ends.
    
    Instead of trying to make `ProcessUtil::escapeArgument` work correctly on Windows - which is impossible as discussed in #21347 - this PR deprecates it in favor of a more powerful approach.
    
    Depending on the use case:
    
    - when a simple command should be run, `Process` now accepts an array of arguments (the "binary" being the first arg). Making this the responsibility of `Process` (instead of `ProcessBuilder`) gives two benefits:
      - escape becomes an internal detail that doesn't leak - thus can't be misused ([see here](symfony/symfony#21347 (comment)))
      - since we know we're running a single command, we can prefix it automatically by "exec" - thus fixing a long standing issue with signaling
    
    ```php
            $p = new Process(array('php', '-r', 'echo 123;'));
            echo $p->getCommandLine();
            // displays on Linux:
            // exec 'php' '-r' 'echo 123;'
    ```
    
    - when a shell expression is required, passing a string is still allowed. To make it easy and look-like sql prepared statements, env vars can be used when running the command. Since the shell is OS-specific (think Windows vs Linux) - this PR assumes no portability, so one should just use each shell's specific syntax.
    
    From the fixtures:
    ```php
            $env = array('FOO' => 'Foo', 'BAR' => 'Bar');
            $cmd = '\\' === DIRECTORY_SEPARATOR ? 'echo !FOO! !BAR! !BAZ!' : 'echo $FOO $BAR $BAZ';
            $p = new Process($cmd, null, $env);
            $p->run(null, array('BAR' => 'baR', 'BAZ' => 'baZ'));
    
            $this->assertSame('Foo baR baZ', rtrim($p->getOutput()));
            $this->assertSame($env, $p->getEnv());
    ```
    
    Commits
    -------
    
    330b61fecb [Process] Accept command line arrays and per-run env vars, fixing signaling and escaping
    fabpot committed Feb 8, 2017
Commits on Feb 3, 2017
  1. Merge branch '3.2'

    * 3.2:
      [FrameworkBundle][Console] JsonDescriptor: Respect original output
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      [FrameworkBundle][Console] JsonDescriptor: Respect original output
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
Commits on Feb 2, 2017
Commits on Feb 1, 2017
Commits on Jan 31, 2017
Commits on Jan 21, 2017
  1. Merge branch '3.2'

    * 3.2:
      fixed CS
      fixed CS
    fabpot committed Jan 21, 2017
  2. Merge branch '3.1' into 3.2

    * 3.1:
      fixed CS
    fabpot committed Jan 21, 2017
  3. fixed CS

    fabpot committed Jan 21, 2017
  4. Merge branch '3.2'

    * 3.2: (40 commits)
      fixed CS
      fixed CS
      fixed CS fixer config
      fixed typo
      Revert "fixed typo"
      fixed typo
      fixed CS
      Avoid setting request attributes from signature arguments in AnnotationClassLoader
      [DependencyInjection] Add some missing typehints in YamlFileLoader
      [DependencyInjection] minor: Fix a DocBlock
      [HttpKernel] Give higher priority to adding request formats
      [Cache] Fix tags expiration
      [PhpUnit] Blacklist DeprecationErrorHandler in stack traces
      [PropertyInfo] Don't try to access a property thru a static method
      [PropertyInfo] Exclude static methods form properties guessing
      [Workflow] Added new validator to make sure each place has unique translation names
      [Cache] [PdoAdapter] Fix MySQL 1170 error (blob as primary key)
      [FrameworkBundle] Fix third level headers for MarkdownDescriptor
      [Ldap] Using Ldap stored username instead of form submitted one
      [Ldap] load users with the good username case
      ...
    fabpot committed Jan 21, 2017
  5. Merge branch '3.1' into 3.2

    * 3.1: (31 commits)
      fixed CS
      fixed CS
      fixed CS fixer config
      fixed typo
      Revert "fixed typo"
      fixed typo
      fixed CS
      Avoid setting request attributes from signature arguments in AnnotationClassLoader
      [DependencyInjection] Add some missing typehints in YamlFileLoader
      [DependencyInjection] minor: Fix a DocBlock
      [HttpKernel] Give higher priority to adding request formats
      [PropertyInfo] Don't try to access a property thru a static method
      [PropertyInfo] Exclude static methods form properties guessing
      [FrameworkBundle] Fix third level headers for MarkdownDescriptor
      [Ldap] Using Ldap stored username instead of form submitted one
      [Ldap] load users with the good username case
      [DoctrineBridge] Fixed invalid unique value as composite key
      [Doctrine Bridge] fix UniqueEntityValidator for composite object primary keys
      [TwigBundle] do not lose already set method calls
      #20411 fix Yaml parsing for very long quoted strings
      ...
    fabpot committed Jan 21, 2017
  6. Merge branch '2.8' into 3.1

    * 2.8: (26 commits)
      fixed CS
      fixed CS
      fixed CS fixer config
      fixed typo
      Revert "fixed typo"
      fixed typo
      fixed CS
      Avoid setting request attributes from signature arguments in AnnotationClassLoader
      [DependencyInjection] Add some missing typehints in YamlFileLoader
      [DependencyInjection] minor: Fix a DocBlock
      [HttpKernel] Give higher priority to adding request formats
      [PropertyInfo] Don't try to access a property thru a static method
      [PropertyInfo] Exclude static methods form properties guessing
      [FrameworkBundle] Fix third level headers for MarkdownDescriptor
      [TwigBundle] do not lose already set method calls
      #20411 fix Yaml parsing for very long quoted strings
      CS: apply is_null
      DX: remove invalid inheritdoc
      bumped Symfony version to 2.8.17
      updated VERSION for 2.8.16
      ...
    fabpot committed Jan 21, 2017
  7. Merge branch '2.7' into 2.8

    * 2.7:
      fixed typo
      Revert "fixed typo"
      fixed typo
      fixed CS
      Avoid setting request attributes from signature arguments in AnnotationClassLoader
      [DependencyInjection] Add some missing typehints in YamlFileLoader
      [DependencyInjection] minor: Fix a DocBlock
      [HttpKernel] Give higher priority to adding request formats
      [FrameworkBundle] Fix third level headers for MarkdownDescriptor
      [TwigBundle] do not lose already set method calls
      #20411 fix Yaml parsing for very long quoted strings
      CS: apply is_null
      DX: remove invalid inheritdoc
      bumped Symfony version to 2.7.24
      updated VERSION for 2.7.23
      update CONTRIBUTORS for 2.7.23
      updated CHANGELOG for 2.7.23
      [FrameworkBundle] Skip test if xdebug.file_link_format is defined.
    fabpot committed Jan 21, 2017
  8. Revert "fixed typo"

    This reverts commit 6830d9f4c904d74020d2619fae990670edb3c3de.
    fabpot committed Jan 21, 2017
  9. fixed typo

    fabpot committed Jan 21, 2017