Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 3, 2012
  1. @Tobion
Commits on Dec 2, 2012
  1. @fabpot

    merged branch Tobion/patch-2 (PR #6166)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    57edf56 removed wrong routing xsd statement `mixed="true"`
    
    Discussion
    ----------
    
    removed wrong routing xsd statement `mixed="true"`
    
    mixed="true" means that the element could contain both text and other elements, e.g.
    `<requirement key="_locale">text <subelement /></requirement>`
    But this wrong and such a definition would not even validate against the scheme as the xsd does not define which elements would be expected inside.
Commits on Dec 1, 2012
  1. @Tobion

    removed wrong routing xsd statement `mixed="true"`

    Tobion authored
    mixed="true" means that the element could contain both text and other elements, e.g.
    `<requirement key="_locale">text <subelement /></requirement>`
    But this wrong and such a definition would not even validate against the scheme as the xsd does not define which elements would be expected inside.
  2. @Tobion
Commits on Aug 28, 2012
  1. @fabpot
  2. @fabpot
  3. @fabpot
  4. @fabpot
Commits on Jul 13, 2012
  1. @hhamon

    [Routing] fixed ApacheUrlMatcher and ApachMatcherDumper classes that …

    hhamon authored
    …did not take care of default parameters in urls.
Commits on Jul 9, 2012
  1. @fabpot
Commits on Jun 12, 2012
  1. @fabpot
Commits on May 21, 2012
  1. @fabpot

    fixed CS

    fabpot authored
Commits on May 19, 2012
  1. @fabpot

    removed unused use statements

    fabpot authored
Commits on May 18, 2012
  1. @fabpot

    removed empty files

    fabpot authored
  2. @fabpot

    fixed CS

    fabpot authored
  3. @fabpot

    added missing LICENSE files

    fabpot authored
Commits on May 15, 2012
  1. @fabpot

    fixed phpdoc @param alignment

    fabpot authored
Commits on May 14, 2012
  1. @sstok
Commits on Apr 23, 2012
  1. http_build_query fix

    Ziumin authored
Commits on Apr 18, 2012
  1. @fabpot

    fixed CS

    fabpot authored
Commits on Apr 11, 2012
  1. @fabpot

    merged branch vicb/routing_dumpers (PR #3858)

    fabpot authored
    Commits
    -------
    
    77185e0 [Routing] Allow spaces in the script name for the apache dumper
    6465a69 [Routing] Fixes to handle spaces in route pattern
    
    Discussion
    ----------
    
    [Routing] Handling of space characters in the dumpers
    
    The compiler was using the 'x' modifier in order to ignore extra spaces and line feeds but the code was flawed:
    
    - it was actually ignoring all the spaces, not only the extra ones added by the compiler,
    - all the spaces were stripped in the php and apache matchers.
    
    The proposed fix:
    
    - do not use the 'x' modifier any more (and then do no add extra spaces / line feeds),
    - do not strip the spaces in the matchers,
    - escapes the spaces (both in regexs and script name) for the apache matcher.
    
    It also include [a small optimization](https://github.com/vicb/symfony/pull/new#L9L89) when the only token of a route is an optional variable token - the idea is to make the regex easier to read.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-10T13:59:45Z
    
    @Baachi fixed now. Thanks.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-10T16:01:31Z
    
    +1, I saw no reason for pretty printing the regex in the first place (just for debugging I guess).
    @vicb since you want to make the regex easier to read, I propose the remove the `P` from the variable regex `?P<bar>`, which is not needed anymore in PHP 5.3 (and we only support PHP 5.3+ anyway).
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-10T16:08:36Z
    
    @Tobion could you make a PR to this branch for the named parameters ?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-10T16:12:34Z
    
    I can include it in #3754 because I'm about the add 2 more fixes to it anyway.
    But when I proposed to apply these fixes to 2.0 Fabien rejected it. So not sure what branch you want me to apply this.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-10T16:25:38Z
    
    May be the best is to put it on hold while I am reviewing your PRs. There are already enough changes, we'll make an other PR after all have been sorted out.
    
    What's the difference between 3754 and 3810 ? (3810 + 3763 = 3754 ?)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-10T16:39:32Z
    
    Lol you forget to link the PR numbers. At first sight I thought it's some sort of mathematical riddle. Haha
    #3810 is for 2.0 =  #3763 (already merged) + #3754 for master
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-10T16:52:18Z
    
    I didn't link on purpose... the question is if '=' means strictly or loosely equal (any diffs - beside master vs 2.0) ?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-10T17:06:04Z
    
    It just applies my changes to 2.0. Nothing more. So master still differs from 2.0 by the addional features that were already implemented (e.g. `RouteCollection->addCollection` with optional requirements and options). But since my changes are bug fixes (except the performance improvement in #3763 but that doesn't break anything and makes 2.0 easier to maintain) I thought they should go into 2.0 as well.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-10T17:14:27Z
    
    @Tobion only bug fixes mean "only bug fixes". You should re-open a PR for 2.0 with "only bug fixes", you might want to wait for me to review 3754.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-10T17:21:00Z
    
    Without #3763 it's much harder to apply the bug fixes. And now that I found 2 more bugs which requiresome rewriting of the PhpMatcherDumper, I don't want to apply all the commits by hand again for 2.0...
Commits on Apr 10, 2012
  1. @vicb

    [Routing] Fixes to handle spaces in route pattern

    vicb authored
    - The route compiler does not add extra space or line-feed,
    - The generated regex does not use the 'x' modified any more,
    - The PHP and apache matchers do not need to strip any chars (vs space and line feed before),
    - The space characters are escaped according to the apache format
Commits on Apr 6, 2012
  1. @hhamon
  2. @hhamon
Commits on Feb 22, 2012
  1. Updated LICENSE files copyright

    marc.weistroff authored
Commits on Feb 16, 2012
  1. @vicb @fabpot

    [Routing] Added a missing property declaration

    vicb authored fabpot committed
Commits on Feb 14, 2012
  1. @fabpot

    [Routing] added a proper exception when a route pattern references th…

    fabpot authored
    …e same variable more than once (closes #3344)
Commits on Jan 11, 2012
  1. @fabpot

    fixed some phpdoc

    fabpot authored
Commits on Jan 5, 2012
  1. @fabpot
Commits on Dec 18, 2011
  1. @fabpot

    tweaked the README files

    fabpot authored
  2. @fabpot

    merged branch lsmith77/component_readmes (PR #2561)

    fabpot authored
    Commits
    -------
    
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    
    Discussion
    ----------
    
    added basic README files for all components and bridges
    
    heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2011/11/03 13:36:07 -0700
    
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:41:29 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by stealth35 at 2011/11/03 13:49:31 -0700
    
    Nice job, but you also need to add `<?php`
    
    ex :
    
    ``` php
    <?php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    
    print $crawler->filter('body > p')->text();
    ```
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:56:57 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by ericclemmons at 2011/11/03 19:57:57 -0700
    
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/04 01:18:23 -0700
    
    ok .. fixed the issues you mentioned @fabpot
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/11 15:00:27 -0800
    
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    
    ---------------------------------------------------------------------------
    
    by drak at 2011/11/11 18:54:13 -0800
    
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/12 00:59:14 -0800
    
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:
    
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > symfony/symfony#2561 (comment)
    
    ---------------------------------------------------------------------------
    
    by breerly at 2011/11/21 10:28:36 -0800
    
    Pretty excited with this.
    
    ---------------------------------------------------------------------------
    
    by dbu at 2011/11/24 00:02:50 -0800
    
    is there anything we can help with to make this ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/18 02:39:23 -0800
    
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
Commits on Dec 13, 2011
  1. @fabpot

    [DoctrineBridge] fixed some CS

    fabpot authored
Commits on Dec 12, 2011
  1. @jpauli
Commits on Nov 24, 2011
  1. @fabpot

    removed unused use statements

    fabpot authored
Commits on Nov 23, 2011
  1. @Seldaek
Something went wrong with that request. Please try again.