Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Sep 10, 2012
  1. @fabpot
Commits on Sep 5, 2012
  1. @fabpot

    Revert "merged branch Tobion/strictrequirements (PR #5181)"

    fabpot authored
    This reverts commit 2da2a44382af2b9af85354ae5a381216534283d2, reversing
    changes made to 58855475c6c6879ee796d95cc522a74250ce5abb.
  2. @fabpot

    Revert "merged branch Tobion/requirementscheck (PR #5187)"

    fabpot authored
    This reverts commit 2cf50b78017b805c75f8ba134925e3e71d2fea50, reversing
    changes made to 569e29d91fd35e91acc2dbcf490ad0f645eecd6d.
  3. @fabpot

    Revert "merged branch Tobion/uselessparamdefaults (PR #5400)"

    fabpot authored
    This reverts commit 0f61b2eb90f40e0665aed9ce82b94e6cfee7f07e, reversing
    changes made to 5e7723fcbb1232f6324312975f21a7d37243b785.
Commits on Aug 31, 2012
  1. @Tobion

    [Routing] added route compile check to identify a default value of a …

    Tobion authored
    …required variable that does not match the requirement
Commits on Aug 30, 2012
  1. @Tobion
  2. @Tobion
  3. @Tobion
  4. @fabpot

    merged branch Tobion/strictrequirements (PR #5181)

    fabpot authored
    Commits
    -------
    
    0706d18 [Routing] fixed 4 bugs in the UrlGenerator
    
    Discussion
    ----------
    
    [Routing] UrlGenerator: fixed missing query param and some ignored requirements
    
    This was pretty hard to figure out. I could fix 4 bugs and refactor the code to safe 2 variables and several assignments. Sorry for doing this in one commit, but they were highly interdependent.
    See the added tests for what was fixed. The most obvious bug was that a query param was ignored if it had by accident the same name as a default param (but wasn't used in the path).
    In 3 cases it generated the wrong URL that wouldn't match this route. The generator wrongly ignored either the requirements or the passed parameter. I had to adjust one test that was asserting something wrong (see comments).
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-13T14:22:35Z
    
    ping @fabpot
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-29T17:53:07Z
    
    @fabpot I think it's important to merge this before 2.1 final.
Commits on Aug 29, 2012
  1. @Tobion
Commits on Aug 28, 2012
  1. @fabpot

    [Routing] fixed a test

    fabpot authored
  2. @fabpot

    Merge branch '2.0'

    fabpot authored
    * 2.0:
      updated VERSION for 2.0.17
      updated CHANGELOG for 2.0.17
      updated vendors for 2.0.17
      fixed XML decoding attack vector through external entities
      prevents injection of malicious doc types
      disabled network access when loading XML documents
      refined previous commit
      prevents injection of malicious doc types
      standardized the way we handle XML errors
      Redirects are now absolute
    
    Conflicts:
    	CHANGELOG-2.0.md
    	src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
    	src/Symfony/Component/DomCrawler/Crawler.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	tests/Symfony/Tests/Component/DependencyInjection/Loader/XmlFileLoaderTest.php
    	tests/Symfony/Tests/Component/Routing/Loader/XmlFileLoaderTest.php
    	tests/Symfony/Tests/Component/Serializer/Encoder/XmlEncoderTest.php
    	tests/Symfony/Tests/Component/Translation/Loader/XliffFileLoaderTest.php
    	tests/Symfony/Tests/Component/Validator/Mapping/Loader/XmlFileLoaderTest.php
    	vendors.php
  3. @fabpot
  4. @fabpot
  5. @fabpot
  6. @fabpot
Commits on Aug 25, 2012
  1. @fabpot

    merged branch willdurand/fix-composer-components (PR #5318)

    fabpot authored
    Commits
    -------
    
    933e821 Add minimum-stability (dev) in each component
    
    Discussion
    ----------
    
    Add minimum-stability (dev) in each component
    
    This fixes the ability to run the test suite in each component if a `composer install` is needed.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T13:57:14Z
    
    If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great.
    Anyway, :+1: for this
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-08-22T13:59:15Z
    
    Yes I already did that once. I'll try to fix more components later.
    
    On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet <
    notifications@github.com> wrote:
    
    > If you really want to run the testsuite standalone, some dev requirements
    > are missing (SecurityBundle needs the FrameworkBundle for its functional
    > tests for instance). If you have some time to check the missing dev
    > requirement, it would be great.
    > Anyway, [image: :+1:] for this
    >
    > —
    > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>.
    >
    >
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:02:23Z
    
    Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle)
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:14:00Z
    
    what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-22T14:30:13Z
    
    please, don't add more travis files. The main already tests everything, and that's all we need.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:33:46Z
    
    @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps).
    Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis.
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:42:30Z
    
    ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook
    
    ---------------------------------------------------------------------------
    
    by hason at 2012-08-24T13:12:04Z
    
    @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T13:35:07Z
    
    @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
Commits on Aug 23, 2012
  1. @Tobion
Commits on Aug 22, 2012
  1. @willdurand
Commits on Aug 5, 2012
  1. @Tobion
Commits on Jul 31, 2012
  1. @vicb
Commits on Jul 28, 2012
  1. @pborreli

    Fixed typos

    pborreli authored
  2. @pborreli

    Fixed Phpdoc

    pborreli authored
Commits on Jul 27, 2012
  1. @pborreli
Commits on Jul 19, 2012
  1. @fabpot

    [Routing] fixed typo

    fabpot authored
Commits on Jul 15, 2012
  1. @fabpot

    Revert "raised the minimum version of PHP to 5.3.4 (closes #3856)"

    fabpot authored
    This reverts commit 2dcc44897ef1ceec2721bbf616c4744131340657.
Commits on Jul 13, 2012
  1. @fabpot

    raised the minimum version of PHP to 5.3.4 (closes #3856)

    fabpot authored
    We've raised the minimum version of PHP because of a PHP
    bug before 5.3.4:
    
    https://bugs.php.net/bug.php?id=52083
    https://bugs.php.net/bug.php?id=50027
  2. @fabpot

    merged 2.0

    fabpot authored
  3. @hhamon

    [Routing] fixed ApacheUrlMatcher and ApachMatcherDumper classes that …

    hhamon authored
    …did not take care of default parameters in urls.
Commits on Jul 10, 2012
  1. @Crell
Commits on Jul 9, 2012
  1. @fabpot

    fixed CS

    fabpot authored
  2. @fabpot
Commits on Jul 3, 2012
  1. @Tobion

    [Routing] use faster approach for encoding rel segments

    Tobion authored
    replaced the preg_replace code that was 1.4 times slower than the new code (verified with benchmark
  2. @Tobion
  3. @fabpot

    merged branch Tobion/4166 (PR #4530)

    fabpot authored
    Commits
    -------
    
    3466896 [Routing] fix encoding of static static, so UrlGenerator produces valid URLs
    
    Discussion
    ----------
    
    [Routing] fix encoding of static text
    
    Fixes #4166
    
    As requested by Fabien, I split #4205 into multiple PRs.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-06-09T12:49:32Z
    
    github tells me this PR cannot be merged automatically. Could you rebase it ?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-06-09T13:12:55Z
    
    Done
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-09T13:18:18Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1576266) (merged 3466896a into 15b5aa4f).
Something went wrong with that request. Please try again.