Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 23, 2013
  1. @schmittjoh
Commits on Mar 14, 2013
  1. @Tobion
Commits on Mar 11, 2013
  1. @fabpot

    Merge branch '2.1' into 2.2

    fabpot authored
    * 2.1:
      [FrameworkBundle] Fix code status in dockblock
      Fixed test to use Reflection
      [Finder] fixed a potential issue on Solaris where INF value is wrong (refs #7269)
      Update RouteCompiler.php
      [FrameworkBundle] avoids cache:clear to break if new/old folders already exist
      [HttpKernel] Fixed possible profiler token collision (closes #7272, closes #7171)
      [ClassLoader] tweaked test
      [ClassLoader] made DebugClassLoader idempotent
      [DomCrawler] Fix relative path handling in links
    
    Conflicts:
    	src/Symfony/Component/DomCrawler/Link.php
    	src/Symfony/Component/Finder/Iterator/DepthRangeFilterIterator.php
    	src/Symfony/Component/Routing/RouteCompiler.php
Commits on Mar 6, 2013
  1. @fabpot

    merged branch Tobion/scheme-method-def-tolerance (PR #7268)

    fabpot authored
    This PR was merged into the 2.2 branch.
    
    Commits
    -------
    
    54c333d [Routing] unify and fix the loader tests
    41ad9d8 [Routing] make xml loader more tolerant
    
    Discussion
    ----------
    
    [Routing] make xml loader more tolerant
    
    schemes and methods may also be delimited by whitespace, comma or pipe.
    Fixes symfony/symfony#6049 (comment)
    this eases migration as now `methods="GET|POST"` also works
    the second commit unifies the tests and fixes some strange assertions that were useless
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [yes]
    | New feature?  | [yes but not really]
    | BC breaks?    | [no]
    | Deprecations? | [no]
    | Tests pass?   | [yes]
    | License       | MIT
  2. @sualko @fabpot

    Update RouteCompiler.php

    sualko authored fabpot committed
    Fixes INF problem on solaris.
Commits on Mar 5, 2013
  1. @Tobion
  2. @Tobion
  3. @Tobion
  4. @Tobion
  5. @Tobion

    adjust RouteCollectionTest for the addCollection change and refactor …

    Tobion authored
    …the tests to only skip the part that really needs the config component
  6. @Tobion
  7. @Tobion
  8. @Tobion
  9. @Tobion
  10. @Tobion
  11. @Tobion
  12. @Tobion

    [Routing] make xml loader more tolerant

    Tobion authored
    schemes and methods may also be delimited by whitespace, comma or pipe.
    this eases migration as now schemes="GET|POST" also works
Commits on Feb 22, 2013
  1. @guilhermeblanco
Commits on Feb 11, 2013
  1. @hason @fabpot

    Fixed XmlFileLoaderTest::testLoadThrowsExceptionWithInvalidFileEvenWi…

    hason authored fabpot committed
    …thoutSchemaValidation
  2. @fabpot

    merged branch fabpot/pattern-fix (PR #6998)

    fabpot authored
    This PR was merged into the 2.2 branch.
    
    Commits
    -------
    
    73aa7d1 replaced usage of the deprecated pattern routing key (replaced with path)
    
    Discussion
    ----------
    
    replaced usage of the deprecated pattern routing key (replaced with path)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2013-02-07T13:35:54Z
    
    do we have tests to cover the BC behavior?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-02-07T16:30:31Z
    
    I've just added some tests for the legacy way.
  3. @fabpot
Commits on Feb 8, 2013
  1. @fabpot
  2. @fabpot
  3. @fabpot

    updated required versions when depending on the Yaml component

    fabpot authored
    The API has not changed since 2.0 and won't until 3.0.
Commits on Feb 7, 2013
  1. @fabpot

    [Routing] fixed previous merge

    fabpot authored
  2. @canni
  3. @fabpot
Commits on Feb 1, 2013
  1. @stloyd @fabpot

    Update `composer.json` files: - to allow versions ~2.2 (>=2.2,<3.0) o…

    stloyd authored fabpot committed
    …f Doctrine DBAL, ORM & Common - fixed Propel1 versions difference between main and bridge files - fixed Twig versions difference between main and bridge files - to allow versions ~1.11 (>=1.11,<2.0) of Twig - fixed Locale ext-intl version to accept all, not non-existing version
Commits on Jan 28, 2013
  1. @franzliedke @fabpot

    [Routing] Improve RouteNotFoundException messages

    franzliedke authored fabpot committed
Commits on Jan 21, 2013
  1. @fabpot

    renamed hostname to host in the routing system (closes #6775)

    fabpot authored
    As explained in #6775, this has been done for the following reasons:
    
    1. It's also Request::getHost()
    2. The term hostname has been obsoleted in
    http://tools.ietf.org/html/rfc3986#appendix-D.2 and uses the host only
    3. hostname in the RFC was defined as the registered domain name, but we
    probably also want to match IP-Adresses with the pattern which is the
    host = IP-literal / IPv4address / reg-name for.
Commits on Jan 17, 2013
  1. @fabpot

    Merge branch '2.1'

    fabpot authored
    * 2.1:
      [Yaml] fixed default value
      Added Yaml\Dumper::setIndentation() method to allow a custom indentation level of nested nodes.
      added a way to enable/disable object support when parsing/dumping
      added a way to enable/disable PHP support when parsing a YAML input via Yaml::parse()
      fixed CS
      [Process] Fix docblocks, remove `return` from `PhpProcess#start()` as parent returns nothing, cleaned up `ExecutableFinder`
      fixes a bug when output/error output contains a % character
      [Console] fixed input bug when the value of an option is empty (closes #6649, closes #6689)
      [Profiler] [Redis] Fix sort of profiler rows.
      Fix version_compare() calls for PHP 5.5.
      Removed underscores from test method names to be consistent with other components.
      [Process] In edge cases `getcwd()` can return `false`, then `proc_open()` should get `null` to use default value (the working dir of the current PHP process)
      Fix version_compare() calls for PHP 5.5.
      Handle the deprecation of IntlDateFormatter::setTimeZoneId() in PHP 5.5.
      removed the .gitattributes files (closes #6605, reverts #5674)
      [HttpKernel] Clarify misleading comment in ExceptionListener
    
    Conflicts:
    	src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_style.html.twig
    	src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php
    	src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php
    	src/Symfony/Component/Form/Tests/Util/PropertyPathTest.php
    	src/Symfony/Component/HttpKernel/Profiler/RedisProfilerStorage.php
    	src/Symfony/Component/Process/Process.php
Commits on Jan 15, 2013
  1. @Tobion
  2. @fabpot

    merged branch fabpot/routing-options (PR #6738)

    fabpot authored
    This PR was merged into the master branch.
    
    Commits
    -------
    
    9fc7def added the UPGRADE file for Symfony 3.0
    e84cad2 [Routing] updated CHANGELOG
    65eca8a [Routing] added new schemes and methods options to the annotation loader
    5082994 [Routing] renamed pattern to path
    b357caf [Routing] renamed hostname pattern to just hostname
    e803f46 made schemes and methods available in XmlFileLoader
    d374e70 made schemes and methods available in YamlFileLoader
    2834e7e added scheme and method setter in RouteCollection
    10183de make scheme and method requirements first-class citizen in Route
    
    Discussion
    ----------
    
    Routing options
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #5989, #5990, #6049
    | License       | MIT
    
    In #5989, it has unanimously been decided to renamed `hostname_pattern` to `hostname` and `pattern` to `path`. That makes a lot of sense and I would like to do the renaming now as `hostname_pattern` is new in Symfony 2.2, so I'd like to avoid breaking BC just after the release. As we are modifying the route options, I've also included changes introduced by @Tobion in #6049 which were discussed in #5990.
    
    As everything is BC, I think it's wise to include that in 2.2. What do you think?
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2013-01-14T18:25:53Z
    
    I agree it should be done in 2.2. Thanks for working on it.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-01-14T23:11:12Z
    
    @fabpot "Everything is BC" until it breaks BC in 3.0, that's why I'd like to see [deprecations in PR summary](symfony/symfony-docs#2116) what do you think ?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-01-14T23:16:40Z
    
    it would also be great to update the CHANGELOG with deprecations (it could also help people answering your question)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-15T07:07:03Z
    
    @vicb: I've just updated the CHANGELOG and created the UPGRADE file for 3.0.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-01-15T07:15:32Z
    
    @fabpot thanks.
  3. @fabpot

    [Routing] updated CHANGELOG

    fabpot authored
  4. @fabpot
Something went wrong with that request. Please try again.