Permalink
Commits on Sep 24, 2016
  1. Merge branch '3.1'

    * 3.1:
      expectedException expects FQCN
      Fixed expectedException annotations
      [Cache] Fix password used to make the redis connection.
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
      Fixed issue with legacy find() method not working as expected
    fabpot committed Sep 24, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      expectedException expects FQCN
      Fixed expectedException annotations
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
    fabpot committed Sep 24, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Fixed expectedException annotations
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
    fabpot committed Sep 24, 2016
Commits on Sep 22, 2016
Commits on Sep 19, 2016
Commits on Sep 17, 2016
  1. feature #19745 [Validator] Added context object method callback to ch…

    …oice validator (Peter Bouwdewijn)
    
    This PR was squashed before being merged into the 3.2-dev branch (closes #19745).
    
    Discussion
    ----------
    
    [Validator] Added context object method callback to choice validator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | "master"
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    835dcf3 [Validator] Added context object method callback to choice validator
    fabpot committed Sep 17, 2016
Commits on Sep 14, 2016
  1. feature #19257 [Validator][Choice] Make strict the default option for…

    … choice validation (peterrehm)
    
    This PR was squashed before being merged into the 3.2-dev branch (closes #19257).
    
    Discussion
    ----------
    
    [Validator][Choice] Make strict the default option for choice validation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #18973
    | License       | MIT
    | Doc PR        | -
    
    This is just the WIP as there are two options.
    
    1. Just change default which would only possible to introduce in 4.x or in 3.2 if this BC break is considered as acceptable
    
    2. Add a new option e.g. `strictComparison` which defaults to true in 4.x and deprecate the usage of the strict option for 3.2.
    
    3. Just deprecate strict = false and remove the option but I would be against that as we remove flexibility which might be wanted.
    
    As per discussion I went ahead with option 3. We can then still decide if we want to remove the option entirely or eventually reenable setting strict to false in a later release.
    
    Commits
    -------
    
    177c513 [Validator][Choice] Make strict the default option for choice validation
    fabpot committed Sep 14, 2016
  2. feature #19485 [FrameworkBundle] Introduce a cache warmer for Validat…

    …or based on PhpArrayAdapter (tgalopin)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Introduce a cache warmer for Validator based on PhpArrayAdapter
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | -
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Following the cache warmer for annotations PR (symfony/symfony#18533), this PR introduces a cache warmer for YAML and XML Validator configuration.
    
    Based on the PhpArrayAdapter, it uses the naming conventions (`Resources/config/validation`) to find the files and compile them into a single PHP file stored in the cache directory. This file uses shared memory on PHP 7.
    
    The benefit of this PR are the same than the ones of the annotations PR:
    
    - validation configuration can be warmed up offline
    - on PHP 7, there is no need for user extension to get maximum performances (ie. if you use this PR and the other one, you probably won't need to enable APCu to have great performances)
    - on PHP 7 again, we are not sensitive to APCu memory fragmentation
    - last but not least, global performance is slightly better (I get 30us per class gain in Blackfire)
    
    This PR also deprecates the framework.validator.cache key in favor of the cache pool introduced in symfony/symfony#18544.
    
    Commits
    -------
    
    6bdaf0b [FrameworkBundle] Introduce a cache warmer for Validator based on PhpArrayAdapter
    fabpot committed Sep 14, 2016
Commits on Sep 13, 2016
  1. Merge branch '3.1'

    * 3.1:
      [ci] Fix build-packages.php
      [Validator] Update IpValidatorTest data set with a valid reserved IP
    nicolas-grekas committed Sep 13, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [ci] Fix build-packages.php
      [Validator] Update IpValidatorTest data set with a valid reserved IP
    nicolas-grekas committed Sep 13, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [ci] Fix build-packages.php
      [Validator] Update IpValidatorTest data set with a valid reserved IP
    nicolas-grekas committed Sep 13, 2016
  4. bug #19928 [Validator] Update IpValidatorTest data set with a valid r…

    …eserved IP (jakzal)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] Update IpValidatorTest data set with a valid reserved IP
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19885
    | License       | MIT
    | Doc PR        | -
    
    The validator uses PHP filter which was recently fixed (see https://bugs.php.net/bug.php?id=72972).
    
    Commits
    -------
    
    86a151c [Validator] Update IpValidatorTest data set with a valid reserved IP
    nicolas-grekas committed Sep 13, 2016
  5. [Validator] Update IpValidatorTest data set with a valid reserved IP

    The validator uses PHP filter which was recently fixed (see https://bugs.php.net/bug.php?id=72972).
    jakzal committed Sep 13, 2016
Commits on Sep 6, 2016
  1. Merge branch '3.1'

    * 3.1:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [Form] Fix transformer tests after the ICU update
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      bumped Symfony version to 3.1.5
      updated VERSION for 3.1.4
      updated CHANGELOG for 3.1.4
      bumped Symfony version to 2.8.11
      updated VERSION for 2.8.10
      updated CHANGELOG for 2.8.10
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [Form] Fix transformer tests after the ICU update
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      bumped Symfony version to 2.8.11
      updated VERSION for 2.8.10
      updated CHANGELOG for 2.8.10
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  4. minor #19862 Update GroupSequence.php (vudaltsov)

    This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #19862).
    
    Discussion
    ----------
    
    Update GroupSequence.php
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | no
    
    Corrected the docblock example
    
    Commits
    -------
    
    c8f3741 Update GroupSequence.php
    nicolas-grekas committed Sep 6, 2016
  5. Update GroupSequence.php

    Corrected the docblock example
    vudaltsov committed with nicolas-grekas Sep 5, 2016
Commits on Aug 26, 2016
  1. Merge branch '3.1'

    * 3.1:
      fix typo
      add "provides" for psr/cache-implementation
      [Validator][GroupSequence] fixed GroupSequence validation ignores PropertyMetadata of parent classes
      [FrameworkBundle][Security] Remove useless mocks
      Add symfony/inflector to composer.json "replaces"
      [DoctrineBridge] Enhance exception message in EntityUserProvider
      added friendly exception when constraint validator does not exist or it is not enabled
      remove duplicate instruction
      [FrameworkBundle] Remove TranslatorBagInterface check
      [FrameworkBundle] Remove duplicated code in RouterDebugCommand
      [Validator] fixed duplicate constraints with parent class interfaces
      SecurityBundle:BasicAuthenticationListener: removed a default argument on getting a header value
    nicolas-grekas committed Aug 26, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [Validator][GroupSequence] fixed GroupSequence validation ignores PropertyMetadata of parent classes
      [FrameworkBundle][Security] Remove useless mocks
      [DoctrineBridge] Enhance exception message in EntityUserProvider
      added friendly exception when constraint validator does not exist or it is not enabled
      remove duplicate instruction
      [FrameworkBundle] Remove TranslatorBagInterface check
      [FrameworkBundle] Remove duplicated code in RouterDebugCommand
      [Validator] fixed duplicate constraints with parent class interfaces
      SecurityBundle:BasicAuthenticationListener: removed a default argument on getting a header value
    nicolas-grekas committed Aug 26, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [Validator][GroupSequence] fixed GroupSequence validation ignores PropertyMetadata of parent classes
      [FrameworkBundle][Security] Remove useless mocks
      [DoctrineBridge] Enhance exception message in EntityUserProvider
      added friendly exception when constraint validator does not exist or it is not enabled
      remove duplicate instruction
      [FrameworkBundle] Remove TranslatorBagInterface check
      [FrameworkBundle] Remove duplicated code in RouterDebugCommand
      [Validator] fixed duplicate constraints with parent class interfaces
      SecurityBundle:BasicAuthenticationListener: removed a default argument on getting a header value
    nicolas-grekas committed Aug 26, 2016
  4. [Validator][GroupSequence] fixed GroupSequence validation ignores Pro…

    …pertyMetadata of parent classes
    senaria committed with fabpot Jul 21, 2016
Commits on Aug 23, 2016
  1. bug #19580 [Validator] fixed duplicate constraints with parent class …

    …interfaces (dmaicher)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] fixed duplicate constraints with parent class interfaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#19516
    | License       | MIT
    | Doc PR        | -
    
    This fixes symfony/symfony#19516
    
    Commits
    -------
    
    fb36c5a [Validator] fixed duplicate constraints with parent class interfaces
    fabpot committed Aug 23, 2016
Commits on Aug 16, 2016
  1. Merge branch '3.1'

    * 3.1:
      [Routing] Add missing options in docblock
      [VarDumper] Fix dumping continuations
      [PropertyInfo] Fix an error in PropertyInfoCacheExtractor
      [HttpFoundation] fixed Request::getContent() reusage bug
      [Form] Skip CSRF validation on form when POST max size is exceeded
      Use try-finally where it possible
      [DependencyInjection] ContainerBuilder: Remove obsolete definitions
      Enhance the phpDoc return types so IDEs can handle the configuration tree.
      fixes
      Remove 3.0 from branch suggestions for fixes in PR template
      [Process] Strengthen Windows pipe files opening (again...)
      [Cache] Handle unserialize() failures gracefully
      Fix #19531 [Form] DateType fails parsing when midnight is not a valid time
    nicolas-grekas committed Aug 16, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [Routing] Add missing options in docblock
      [VarDumper] Fix dumping continuations
      [HttpFoundation] fixed Request::getContent() reusage bug
      [Form] Skip CSRF validation on form when POST max size is exceeded
      Enhance the phpDoc return types so IDEs can handle the configuration tree.
      fixes
      Remove 3.0 from branch suggestions for fixes in PR template
      [Process] Strengthen Windows pipe files opening (again...)
      Fix #19531 [Form] DateType fails parsing when midnight is not a valid time
    fabpot committed Aug 16, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [Routing] Add missing options in docblock
      [VarDumper] Fix dumping continuations
      [HttpFoundation] fixed Request::getContent() reusage bug
      [Form] Skip CSRF validation on form when POST max size is exceeded
      Enhance the phpDoc return types so IDEs can handle the configuration tree.
      fixes
      Remove 3.0 from branch suggestions for fixes in PR template
      [Process] Strengthen Windows pipe files opening (again...)
      Fix #19531 [Form] DateType fails parsing when midnight is not a valid time
    fabpot committed Aug 16, 2016
Commits on Aug 13, 2016
  1. fixes

    ro0NL committed with fabpot Aug 7, 2016
Commits on Aug 11, 2016
Commits on Aug 10, 2016
Commits on Aug 7, 2016
  1. Merge branch '3.1'

    * 3.1:
      [Routing] Reorder assert parameters
      [Cache] Use SCAN instead of KEYS with Redis >= 2.8
      Added missing czech validators translation of not expected charset
      Improved deprecation message
      Workaround another buggy PHP warning
      Add czech translation for Url and Length validator
      Add slovak translation for Url and Length validator
    nicolas-grekas committed Aug 7, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [Routing] Reorder assert parameters
      Added missing czech validators translation of not expected charset
      Workaround another buggy PHP warning
      Add czech translation for Url and Length validator
      Add slovak translation for Url and Length validator
    nicolas-grekas committed Aug 7, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [Routing] Reorder assert parameters
      Added missing czech validators translation of not expected charset
      Workaround another buggy PHP warning
      Add czech translation for Url and Length validator
      Add slovak translation for Url and Length validator
    nicolas-grekas committed Aug 7, 2016