Skip to content
Commits on Mar 22, 2016
  1. @nicolas-grekas

    Merge branch '2.3' into 2.7

    * 2.3:
      [Validator] use correct term for a property in docblock (not "option")
      [PropertyAccess] Remove most ref mismatches to improve perf
      [Validator] EmailValidator cannot extract hostname if email contains multiple @ symbols
      [NumberFormatter] Fix invalid numeric literal on PHP 7
      Use XML_ELEMENT_NODE in nodeType check
      [PropertyAccess] Reduce overhead of UnexpectedTypeException tracking
      [PropertyAccess] Throw an UnexpectedTypeException when the type do not match
      [FrameworkBundle] Add tests for the Controller class
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Tests/Controller/ControllerTest.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessor.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessorInterface.php
    	src/Symfony/Component/PropertyAccess/PropertyPath.php
    	src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
    	src/Symfony/Component/Validator/Constraints/EmailValidator.php
    nicolas-grekas committed Mar 22, 2016
Commits on Mar 18, 2016
  1. @sustmi
Commits on Mar 17, 2016
  1. @natechicago @nicolas-grekas
Commits on Mar 16, 2016
  1. @nicolas-grekas

    Merge branch '3.0'

    * 3.0:
      [Validator] Test DNS Url constraints using checkdnsrr() mock
      Improved the PHPdoc of FileSystem::copy()
      [Validator] Test DNS Email constraints using checkdnsrr() mock
      [travis] Run real php subprocesses on hhvm for Process component tests
      bug #18161 [Translation] Add support for fuzzy tags in PoFileLoader
      [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
      [Form] Fix INT64 cast to float in IntegerType.
      [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactoryInterface
      FrameworkBundle: Client: getContainer(): fixed phpdoc
      [Validator] Updating inaccurate docblock comment
    
    Conflicts:
    	phpunit.xml.dist
    nicolas-grekas committed Mar 16, 2016
  2. @nicolas-grekas

    Merge branch '2.8' into 3.0

    * 2.8:
      [Validator] Test DNS Url constraints using checkdnsrr() mock
      Improved the PHPdoc of FileSystem::copy()
      [Validator] Test DNS Email constraints using checkdnsrr() mock
      [travis] Run real php subprocesses on hhvm for Process component tests
      bug #18161 [Translation] Add support for fuzzy tags in PoFileLoader
      [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
      [Form] Fix INT64 cast to float in IntegerType.
      [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactoryInterface
      FrameworkBundle: Client: getContainer(): fixed phpdoc
      [Validator] Updating inaccurate docblock comment
    
    Conflicts:
    	.travis.yml
    nicolas-grekas committed Mar 16, 2016
  3. @nicolas-grekas

    Merge branch '2.7' into 2.8

    * 2.7:
      [Validator] Test DNS Url constraints using checkdnsrr() mock
      Improved the PHPdoc of FileSystem::copy()
      [Validator] Test DNS Email constraints using checkdnsrr() mock
      [travis] Run real php subprocesses on hhvm for Process component tests
      bug #18161 [Translation] Add support for fuzzy tags in PoFileLoader
      [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
      [Form] Fix INT64 cast to float in IntegerType.
      [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactoryInterface
      FrameworkBundle: Client: getContainer(): fixed phpdoc
      [Validator] Updating inaccurate docblock comment
    nicolas-grekas committed Mar 16, 2016
  4. @nicolas-grekas
  5. @nicolas-grekas

    Merge branch '2.3' into 2.7

    * 2.3:
      Improved the PHPdoc of FileSystem::copy()
      [Validator] Test DNS Email constraints using checkdnsrr() mock
      [travis] Run real php subprocesses on hhvm for Process component tests
      bug #18161 [Translation] Add support for fuzzy tags in PoFileLoader
      [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
      [Form] Fix INT64 cast to float in IntegerType.
      [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactoryInterface
      FrameworkBundle: Client: getContainer(): fixed phpdoc
      [Validator] Updating inaccurate docblock comment
    
    Conflicts:
    	.travis.yml
    	src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
    nicolas-grekas committed Mar 16, 2016
  6. @nicolas-grekas
  7. @nicolas-grekas

    Merge branch '3.0'

    * 3.0:
      [PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8
      bumped Symfony version to 2.3.40
      Fix leftover conflict marker in UPGRADE-3.0.md
      set s-maxage only if all responses are cacheable
      updated VERSION for 2.3.39
      update CONTRIBUTORS for 2.3.39
      updated CHANGELOG for 2.3.39
      Improved the "branch" row of the PR table
      [Debug] Replaced logic for detecting filesystem case sensitivity
      [Process] Wait a bit less on Windows
      Use debug member variable
      Autowiring the concrete class too - consistent with behavior of other services
      Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should
      Fix for Isssue #18091
      replace perfom by perform
      minor #18088 Fix typo for profiler
      [Validator] Fixing inaccurate typehint in docblock
      [ci] remove token for composer now that rate limiting is off
    nicolas-grekas committed Mar 16, 2016
  8. @nicolas-grekas

    Merge branch '2.8' into 3.0

    * 2.8:
      [PhpUnitBridge] Revert 7f62133939b1172e1c9924d211e1d315230b3be8
      bumped Symfony version to 2.3.40
      set s-maxage only if all responses are cacheable
      updated VERSION for 2.3.39
      update CONTRIBUTORS for 2.3.39
      updated CHANGELOG for 2.3.39
      Improved the "branch" row of the PR table
      [Debug] Replaced logic for detecting filesystem case sensitivity
      [Process] Wait a bit less on Windows
      Use debug member variable
      Autowiring the concrete class too - consistent with behavior of other services
      Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should
      Fix for Isssue #18091
      replace perfom by perform
      minor #18088 Fix typo for profiler
      [Validator] Fixing inaccurate typehint in docblock
      [ci] remove token for composer now that rate limiting is off
    
    Conflicts:
    	CHANGELOG-2.3.md
    	src/Symfony/Bridge/PhpUnit/composer.json
    nicolas-grekas committed Mar 16, 2016
Commits on Mar 12, 2016
  1. @natechicago

    [Validator] Updating inaccurate docblock comment

    The formatValue() docblock refers to a $prettyDateTime argument, which does not exist.  Instead, it should refer to the $format argument.
    natechicago committed Mar 11, 2016
  2. @natechicago

    [Validator] Fixing inaccurate typehint in docblock

    As of Symfony 2.8, constraint errors are now string UUIDs rather than integers.  The corresponding docblock typehint in getErrorName() should reflect this change.
    natechicago committed Mar 11, 2016
Commits on Mar 10, 2016
  1. @nicolas-grekas

    Merge branch '3.0'

    * 3.0: (28 commits)
      [Console] Fix an autocompletion question helper issue with non-sequentially indexed choices
      [Process] Fix pipes handling
      [Finder] Partially revert #17134 to fix a regression
      Mentioned the deprecation of deep parameters in UPGRADE files
      [HttpKernel] Fix mem usage when stripping the prod container
      [Filesystem] Fix false positive in ->remove()
      [Filesystem] Cleanup/sync with 2.3
      [Validator] Fix the locale validator so it treats a locale alias as a valid locale
      [HttpFoundation] Fix transient test
      [HttpFoundation] Add a dependency on the mbstring polyfill
      [2.7] update readme files for new components
      add readme files where missing
      [2.8] update readme files for new components
      fix lowest TwigBridge deps versions
      reference form type by name on Symfony 2.7
      [EventDispatcher] fix syntax error
      Don't use reflections when possible
      Don't use reflections when possible
      [Form] Update form tests after the ICU data update
      [Intl] Update tests and the number formatter to match behaviour of the intl extension
      ...
    
    Conflicts:
    	src/Symfony/Component/Ldap/README.md
    	src/Symfony/Component/Security/Core/README.md
    	src/Symfony/Component/Security/Csrf/README.md
    	src/Symfony/Component/Security/Http/README.md
    nicolas-grekas committed Mar 10, 2016
  2. @nicolas-grekas

    Merge branch '2.7' into 2.8

    * 2.7:
      [Finder] Partially revert #17134 to fix a regression
      [HttpKernel] Fix mem usage when stripping the prod container
      exception when registering bags for started sessions
    
    Conflicts:
    	src/Symfony/Component/Validator/composer.json
    nicolas-grekas committed Mar 10, 2016
  3. @nicolas-grekas

    Merge branch '2.3' into 2.7

    * 2.3:
      [Finder] Partially revert #17134 to fix a regression
      [HttpKernel] Fix mem usage when stripping the prod container
      exception when registering bags for started sessions
    
    Conflicts:
    	src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    nicolas-grekas committed Mar 10, 2016
  4. @nicolas-grekas

    Merge branch '2.8' into 3.0

    * 2.8: (25 commits)
      [Console] Fix an autocompletion question helper issue with non-sequentially indexed choices
      [Process] Fix pipes handling
      Mentioned the deprecation of deep parameters in UPGRADE files
      [Filesystem] Fix false positive in ->remove()
      [Filesystem] Cleanup/sync with 2.3
      [Validator] Fix the locale validator so it treats a locale alias as a valid locale
      [HttpFoundation] Fix transient test
      [HttpFoundation] Add a dependency on the mbstring polyfill
      [2.7] update readme files for new components
      add readme files where missing
      [2.8] update readme files for new components
      fix lowest TwigBridge deps versions
      reference form type by name on Symfony 2.7
      [EventDispatcher] fix syntax error
      Don't use reflections when possible
      Don't use reflections when possible
      [Form] Update form tests after the ICU data update
      [Intl] Update tests and the number formatter to match behaviour of the intl extension
      [Intl] Update the ICU data to version 55
      [Intl] Fix the update-data.php script in preparation for ICU 5.5
      ...
    
    Conflicts:
    	UPGRADE-2.8.md
    	UPGRADE-3.0.md
    	src/Symfony/Bridge/Twig/composer.json
    	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/FragmentRendererPass.php
    	src/Symfony/Component/Console/Helper/DialogHelper.php
    	src/Symfony/Component/Console/Helper/ProgressHelper.php
    	src/Symfony/Component/Console/Tests/Helper/LegacyDialogHelperTest.php
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Security/Core/README.md
    	src/Symfony/Component/Security/Csrf/README.md
    	src/Symfony/Component/Security/Http/README.md
    	src/Symfony/Component/Validator/Constraints/LocaleValidator.php
    nicolas-grekas committed Mar 10, 2016
Commits on Mar 8, 2016
  1. @fabpot

    Merge branch '2.7' into 2.8

    * 2.7:
      [Filesystem] Fix false positive in ->remove()
      [Filesystem] Cleanup/sync with 2.3
      [Validator] Fix the locale validator so it treats a locale alias as a valid locale
      reference form type by name on Symfony 2.7
    fabpot committed Mar 8, 2016
  2. @nicolas-grekas

    Merge branch '2.3' into 2.7

    * 2.3:
      [Filesystem] Fix false positive in ->remove()
      [Validator] Fix the locale validator so it treats a locale alias as a valid locale
    
    Conflicts:
    	src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
    	src/Symfony/Component/Validator/Constraints/LocaleValidator.php
    	src/Symfony/Component/Validator/composer.json
    nicolas-grekas committed Mar 8, 2016
Commits on Mar 7, 2016
  1. @jakzal
  2. @nicolas-grekas

    Merge branch '2.7' into 2.8

    * 2.7:
      [HttpFoundation] Fix transient test
      [HttpFoundation] Add a dependency on the mbstring polyfill
      [2.7] update readme files for new components
      add readme files where missing
      fix lowest TwigBridge deps versions
      [EventDispatcher] fix syntax error
      Don't use reflections when possible
      Don't use reflections when possible
      [Form] Update form tests after the ICU data update
      [Intl] Update tests and the number formatter to match behaviour of the intl extension
      [Intl] Update the ICU data to version 55
      [Intl] Fix the update-data.php script in preparation for ICU 5.5
      [Process] Fix memory issue when using large input streams
      Use constant instead of function call.
      fixed test name
      automatically generate safe fallback filename
      [Console] default to stderr in the console helpers
    
    Conflicts:
    	composer.json
    	src/Symfony/Bridge/PhpUnit/README.md
    	src/Symfony/Bridge/Twig/composer.json
    	src/Symfony/Component/Console/Helper/DialogHelper.php
    	src/Symfony/Component/Debug/DebugClassLoader.php
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Security/Acl/README.md
    	src/Symfony/Component/Security/Core/README.md
    	src/Symfony/Component/Security/Csrf/README.md
    	src/Symfony/Component/Security/Http/README.md
    nicolas-grekas committed Mar 7, 2016
  3. @nicolas-grekas

    Merge branch '2.3' into 2.7

    * 2.3:
      [HttpFoundation] Fix transient test
      [HttpFoundation] Add a dependency on the mbstring polyfill
      add readme files where missing
      Don't use reflections when possible
      [Form] Update form tests after the ICU data update
      [Intl] Update tests and the number formatter to match behaviour of the intl extension
      [Intl] Update the ICU data to version 55
      [Intl] Fix the update-data.php script in preparation for ICU 5.5
      Use constant instead of function call.
      fixed test name
      automatically generate safe fallback filename
    
    Conflicts:
    	src/Symfony/Component/Debug/Debug.php
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
    nicolas-grekas committed Mar 7, 2016
Commits on Mar 6, 2016
  1. @fabpot

    minor #18021 Don't use reflections when possible (Ener-Getick)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    Don't use reflections when possible
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Use php functions instead of reflection when possible (to improve a bit the performance).
    
    Commits
    -------
    
    a46270a Don't use reflections when possible
    fabpot committed Mar 6, 2016
Commits on Mar 5, 2016
  1. @Ener-Getick
Commits on Mar 4, 2016
  1. @fabpot

    Merge branch '3.0'

    * 3.0:
      Updated all the README files
      [TwigBundle] Fix failing test on appveyor
      Improved the error message when using "@" in a decorated service
      Improve error reporting in router panel of web profiler
      [DoctrineBridge][Form] Fix performance regression in EntityType
      [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths
      Allow to normalize \Traversable
      minor [Form] fix tests added by #16886
      Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener
      Simplified everything
      Added a test
      Fixed the problem in an easier way
      Fixed a syntax issue
      Improved the error message when a template is not found
      [CodingStandards] Conformed to coding standards
      [TwigBundle] fixed Include file locations in "Template could not be found" exception
    fabpot committed Mar 4, 2016
  2. @fabpot

    Merge branch '2.8' into 3.0

    * 2.8:
      Updated all the README files
      [TwigBundle] Fix failing test on appveyor
      Improved the error message when using "@" in a decorated service
      Improve error reporting in router panel of web profiler
      [DoctrineBridge][Form] Fix performance regression in EntityType
      [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths
      Allow to normalize \Traversable
      minor [Form] fix tests added by #16886
      Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener
      Simplified everything
      Added a test
      Fixed the problem in an easier way
      Fixed a syntax issue
      Improved the error message when a template is not found
      [CodingStandards] Conformed to coding standards
      [TwigBundle] fixed Include file locations in "Template could not be found" exception
    fabpot committed Mar 4, 2016
  3. @fabpot

    Merge branch '2.7' into 2.8

    * 2.7:
      Updated all the README files
      [TwigBundle] Fix failing test on appveyor
      Improved the error message when using "@" in a decorated service
      Improve error reporting in router panel of web profiler
      [DoctrineBridge][Form] Fix performance regression in EntityType
      [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths
      Allow to normalize \Traversable
      minor [Form] fix tests added by #16886
      Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener
      Simplified everything
      Added a test
      Fixed the problem in an easier way
      Fixed a syntax issue
      Improved the error message when a template is not found
      [CodingStandards] Conformed to coding standards
      [TwigBundle] fixed Include file locations in "Template could not be found" exception
    fabpot committed Mar 4, 2016
  4. @fabpot

    Merge branch '2.3' into 2.7

    * 2.3:
      Updated all the README files
      [TwigBundle] Fix failing test on appveyor
      [FrameworkBundle] Fix a regression in handling absolute and namespaced template paths
      Allow to normalize \Traversable
      Remove _path from query parameters when fragment is a subrequest and request attributes are already set Added tests for _path removal in FragmentListener
      Simplified everything
      Added a test
      Fixed the problem in an easier way
      Fixed a syntax issue
      Improved the error message when a template is not found
      [CodingStandards] Conformed to coding standards
      [TwigBundle] fixed Include file locations in "Template could not be found" exception
    fabpot committed Mar 4, 2016
  5. @javiereguiluz @fabpot
Commits on Mar 1, 2016
  1. @fabpot

    feature #17553 [Validator] Added a format option to the DateTime cons…

    …traint. (dosten)
    
    This PR was merged into the 3.1-dev branch.
    
    Discussion
    ----------
    
    [Validator] Added a format option to the DateTime constraint.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #14521
    | License       | MIT
    
    This PR adds a `format` option to the `DateTime` constraint, this allows to validate dates in custom formats, for example:
    
    ```php
    use Symfony\Component\Validator\Constraints\DateTime;
    use Symfony\Component\Validator\Validation;
    
    $validator = Validation::createValidator();
    
    $validator->validate('December 31, 1999', new DateTime(['format' => 'F d, Y']));
    $validator->validate('01:02:03', new DateTime(['format' => 'H:i:s']));
    $validator->validate('2010/01/01 01:02', new DateTime(['format' => 'Y/m/d H:i']));
    ```
    
    As you can see this new option allows to use the `DateTime` constraint to validate dates and times, so, maybe the `Date` and `Time` constraints can be deprecated in this PR.
    
    Commits
    -------
    
    9e94c9f Added a format option to the DateTime constraint.
    fabpot committed Mar 1, 2016
Commits on Feb 26, 2016
  1. @fabpot

    Merge branch '3.0'

    * 3.0:
      [3.0] [Tests] minor fix following #17787
      [2.8] [Form] minor fix some tests with placeholder in AbstractLayout
      [DependencyInjection] fix tests
      Validate XLIFF translation files
      [DependencyInjection] replace alias in factories
      replace alias in factory services
    fabpot committed Feb 26, 2016
  2. @fabpot

    Merge branch '2.8' into 3.0

    * 2.8:
      [2.8] [Form] minor fix some tests with placeholder in AbstractLayout
      [DependencyInjection] fix tests
      Validate XLIFF translation files
      [DependencyInjection] replace alias in factories
      replace alias in factory services
    fabpot committed Feb 26, 2016
Commits on Feb 23, 2016
  1. @fabpot

    Merge branch '2.7' into 2.8

    * 2.7:
      Validate XLIFF translation files
      [DependencyInjection] replace alias in factories
      replace alias in factory services
    fabpot committed Feb 23, 2016
  2. @fabpot

    Merge branch '2.3' into 2.7

    * 2.3:
      Validate XLIFF translation files
      replace alias in factory services
    fabpot committed Feb 23, 2016
  3. @fabpot

    minor #17903 Validate XLIFF translation files (javiereguiluz)

    This PR was squashed before being merged into the 2.3 branch (closes #17903).
    
    Discussion
    ----------
    
    Validate XLIFF translation files
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    In #17902 @stof proposed to add a simple test to validate `.xlf` files (to avoid issues like #17893).
    
    This is a proposal for that test. My questions:
    
    **1)** Do you agree displaying detailed error messages when the XML is not valid. Example output for the #17893 error:
    
    ![error_log](https://cloud.githubusercontent.com/assets/73419/13250664/932d2f14-da2b-11e5-8ea0-ecb43f58feea.png)
    
    Or is it enough displaying just the PHPUnit error message and let the user figure out the details?
    
    ![simple_error](https://cloud.githubusercontent.com/assets/73419/13250671/a3b4bfd2-da2b-11e5-9277-454d0dd160b2.png)
    
    **2)** How do I validate the translation files of the Security and Form components? Do I just copy+paste this test in those components?
    
    Commits
    -------
    
    db03055 Validate XLIFF translation files
    fabpot committed Feb 23, 2016
Something went wrong with that request. Please try again.