Permalink
Commits on Sep 22, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Sep 22, 2014
    * 2.3:
      fixed CS
      [Process] fixed some volatile tests
      [HttpKernel] fixed a volatile test
      [HttpFoundation] fixed some volatile tests
      Use getPathname() instead of string casting to get BinaryFileReponse file path
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/EventListener/SessionListener.php
    	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
    	src/Symfony/Component/ClassLoader/Tests/ApcUniversalClassLoaderTest.php
    	src/Symfony/Component/Config/Definition/ReferenceDumper.php
    	src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php
    	src/Symfony/Component/Console/Application.php
    	src/Symfony/Component/Console/Tests/ApplicationTest.php
    	src/Symfony/Component/Filesystem/Exception/IOException.php
    	src/Symfony/Component/Form/Extension/Templating/TemplatingExtension.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/HttpKernel/Tests/Bundle/BundleTest.php
    	src/Symfony/Component/HttpKernel/Tests/Fragment/RoutableFragmentRendererTest.php
    	src/Symfony/Component/HttpKernel/Tests/Profiler/Mock/RedisMock.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessor.php
    	src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCollectionTest.php
    	src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
    	src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php
    	src/Symfony/Component/Routing/Tests/Annotation/RouteTest.php
    	src/Symfony/Component/Routing/Tests/Loader/AnnotationClassLoaderTest.php
    	src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
    	src/Symfony/Component/Validator/Constraints/CollectionValidator.php
    	src/Symfony/Component/Validator/Tests/ExecutionContextTest.php
  2. fixed CS

    fabpot committed Sep 21, 2014
Commits on Sep 17, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Sep 17, 2014
    * 2.3: (35 commits)
      [Form] Fix PHPDoc for builder setData methods The underlying data variable is typed as mixed whereas the methods paramers where typed as array.
      fixed CS
      [Intl] Improved bundle reader implementations
      [Console] guarded against invalid aliases
      switch before_script to before_install and script to install
      fixed typo
      [HttpFoundation] Request - URI - comment improvements
      [Security] Added more tests
      remove `service` parameter type from XSD
      [Intl] Added exception handler to command line scripts
      [Intl] Fixed a few bugs in TextBundleWriter
      [Intl] Updated icu.ini up to ICU 53
      [Intl] Removed non-working $fallback argument from ArrayAccessibleResourceBundle
      Use separated function to resolve command and related arguments
      [SwiftmailerBridge] Bump allowed versions of swiftmailer
      [FrameworkBundle] Remove invalid markup
      [Intl] Added "internal" tag to all classes under Symfony\Component\Intl\ResourceBundle
      Remove routes for removed WebProfiler actions
      [Security] Fix usage of unexistent method in DoctrineAclCache.
      backport more error information from 2.6 to 2.3
      ...
    
    Conflicts:
    	.travis.yml
    	src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
    	src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	src/Symfony/Component/Process/PhpExecutableFinder.php
Commits on Sep 15, 2014
  1. bug #11799 [YAML] fix handling of empty sequence items (xabbuh)

    fabpot committed Sep 15, 2014
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [YAML] fix handling of empty sequence items
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #11798
    | License       | MIT
    | Doc PR        |
    
    When a line contains only a dash it cannot safely be assumed that it contains a nested list or an embedded mapping. If the next line starts with a dash at the same indentation, the current line's item is to be treated as `null`.
    
    Commits
    -------
    
    fc85435 fix handling of empty sequence items
Commits on Sep 4, 2014
Commits on Sep 3, 2014
  1. improve error when detecting unquoted asterisks

    xabbuh committed Sep 3, 2014
    Asterisks in unquoted strings are used in YAML to reference
    variables. Before Symfony 2.3.19, Symfony 2.4.9 and Symfony 2.5.4,
    unquoted asterisks in inlined YAML code were treated as regular
    strings. This was fixed for the inline parser in #11677. However, an
    unquoted * character now led to an error message like this:
    
    ```
    PHP Warning:  array_key_exists(): The first argument should be either a string or an integer in vendor/symfony/symfony/src/Symfony/Component/Yaml/Inline.php on line 409
    
      [Symfony\Component\Yaml\Exception\ParseException]
      Reference "" does not exist at line 171 (near "- { foo: * }").
    ```
Commits on Aug 31, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Aug 31, 2014
    * 2.3:
      [HttpKernel] add use statement for phpdoc
      Disabled the PHPUnit self-update on Travis
      [ClassLoader] simplified phpdoc
      [ClassLoader] Add a __call() method to XcacheClassLoader
      fix some minor typos in tests
      [Yaml] fixed mapping keys containing a quoted #
      Added fixture to test parsing of hash keys ending with a space and #
      [Filesystem Component] mkdir race condition fix #11626
      [Validator] reverted permissions change on translation files
      Fixed Factory services not within the ServiceReferenceGraph.
      [CssSelector] Fix URL to SimonSapin/cssselect repo
      [Validator] Fixed wrong translation keys/messages for Collection constraint. The error messages for a missing field and an unexpected field did not match the Contraint class
      [YAML] resolve variables in inlined YAML
      Disallow abstract definitions from doctrine event listener registration
    
    Conflicts:
    	src/Symfony/Bridge/Doctrine/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPass.php
    	src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/CompilerPass/RegisterEventListenersAndSubscribersPassTest.php
    	src/Symfony/Bundle/FrameworkBundle/EventListener/SessionListener.php
    	src/Symfony/Component/Filesystem/Filesystem.php
Commits on Aug 29, 2014
  1. fix handling of empty sequence items

    xabbuh committed Aug 29, 2014
    When a line contains only a dash it cannot safely be assumed that
    it contains a nested list or an embedded mapping. If the next line
    starts with a dash at the same indentation, the current line's item
    is to be treated as `null`.
Commits on Aug 28, 2014
Commits on Aug 18, 2014
Commits on Aug 4, 2014
  1. Merge branch '2.3' into 2.4

    webmozart committed Aug 4, 2014
    * 2.3: (22 commits)
      Fix incorrect romanian plural translations
      fix axes handling in Crawler::filterXPath()
      fix some docblocks
      Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
      [Process] Fix tests when pcntl is not available.
      [DependencyInjection] Roll back changes made to generated files.
      [Console] Roll back changes made to fixture files.
      [Validator] Added more detailed inline documentation
      [Validator] Removed information from the violation output if the value is an array, object or resource
      partially reverted previous commit
      fixed CS
      properly handle null data when denormalizing
      [Validator] Renamed valueToString() to formatValue(); added missing formatValue() calls
      [Validator] Fixed CS
      [Validator] Fixed date-to-string conversion tests to match ICU 51
      [Validator] Added "{{ value }}" parameters where they were missing
      [Validator] Simplified and explained the LuhnValidator
      [Validator] Simplified IssnValidator
      [Validator] Fixed and simplified IsbnValidator
      [Validator] Simplified IBAN validation algorithm
      ...
    
    Conflicts:
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/DependencyInjection/Container.php
    	src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
    	src/Symfony/Component/HttpFoundation/File/UploadedFile.php
    	src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
    	src/Symfony/Component/Validator/Constraints/AbstractComparisonValidator.php
    	src/Symfony/Component/Validator/Constraints/CollectionValidator.php
    	src/Symfony/Component/Validator/Tests/Constraints/EqualToValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/GreaterThanValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/IdenticalToValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/LessThanOrEqualValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/LessThanValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/NotEqualToValidatorTest.php
    	src/Symfony/Component/Validator/Tests/Constraints/NotIdenticalToValidatorTest.php
Commits on Aug 2, 2014
  1. fix some docblocks

    xabbuh committed Jul 26, 2014
Commits on Jul 9, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Jul 9, 2014
    * 2.3:
      fixed CS
      [HttpFoundation] Remove content-related headers if content is empty
      removed defaults from PHPUnit configuration
Commits on Jul 8, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Jul 8, 2014
    * 2.3:
      bumped Symfony version to 2.3.18
      updated VERSION for 2.3.17
      update CONTRIBUTORS for 2.3.17
      updated CHANGELOG for 2.3.17
      added XSD to PHPUnit configuration
      bug #11319 [HttpKernel] Ensure the storage exists before purging it in ProfilerTest
      [Translation] Added unescaping of ids in PoFileLoader
      updated italian translation for validation messages
      [DomCrawler] Fix docblocks and formatting.
      [DomCrawler] Remove the query string and the anchor of the uri of a link
      Simplified the Travis test command
      [Console] Make sure formatter is the same
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
Commits on Jul 7, 2014
  1. added XSD to PHPUnit configuration

    craue authored and fabpot committed Jul 6, 2014
Commits on May 12, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed May 12, 2014
    * 2.3:
      [Console]Improve formatter for double-width character
      Lower mbstring dep, remove it for Yaml and CssSelector components
      [Security] Add check for supported attributes in AclVoter
      [Form] Fixed TrimListenerTest as of PHP 5.5
      Added more IDE links
      [DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
      [Finder] fixed typehint of the Finder::addAdapter() method
      [TwigBridge][Transchoice] set %count% from the current context.
      [DependencyInjection] Fix travis unit tests
      Update PHPUnit before run
      [Validator] fixed wrong test
      [WebProfilerBundle] added test case for #10773
      [WebProfilerBundle] fixed profiler homepage, fixed #10806
      [WebProfilerBundle] Added test case for #10806
      changed travis to run on the nightly builds of HHVM until everything gets stable
      Fixed issue #5427
      Allow URLs that don't contain a path
    
    Conflicts:
    	.travis.yml
Commits on Apr 18, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Apr 18, 2014
    * 2.3:
      Textarea value should default to empty string instead of null.
      Fix doc blocks
      [Process] Fix #10681, process are failing on Windows Server 2003
      [Security] fix DBAL connection typehint
      [HttpFoundation] status 201 is allowed to have a body
      unified return null usages
    
    Conflicts:
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php
  2. minor #10717 unified return null usages (fabpot)

    fabpot committed Apr 18, 2014
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    unified return null usages
    
    | Q             | A
    | ------------- | ---
    | License       | MIT
    
    This PR unifies the way we return `null` from a function or method:
    
     * always use `return;` instead of `return null;` (the current code base uses both);
     * never use `return;` at the end of a function/method.
    
    Commits
    -------
    
    d1d569b unified return null usages
Commits on Apr 16, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Apr 16, 2014
    * 2.3:
      fixed types in phpdocs
    
    Conflicts:
    	src/Symfony/Bridge/Twig/TwigEngine.php
    	src/Symfony/Bundle/FrameworkBundle/Templating/Loader/FilesystemLoader.php
    	src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
    	src/Symfony/Component/Form/Extension/Core/ChoiceList/SimpleChoiceList.php
    	src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
    	src/Symfony/Component/HttpKernel/Controller/ControllerResolverInterface.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessorBuilder.php
    	src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
    	src/Symfony/Component/Stopwatch/StopwatchEvent.php
    	src/Symfony/Component/Templating/PhpEngine.php
  2. fixed types in phpdocs

    fabpot committed Apr 16, 2014
  3. Merge branch '2.3' into 2.4

    fabpot committed Apr 16, 2014
    * 2.3:
      made {@inheritdoc} annotations consistent across the board
      fixed types in phpdocs
      made phpdoc types consistent with those defined in Hack
      Add support Thai translations
      made types consistent with those defined in Hack
      removed extra/unsupported arguments
      [HttpKernel] fixed an error message
      [TwigBundle] removed undefined argument
      [Translation] Make IcuDatFileLoader/IcuResFileLoader::load invalid resource compatible with HHVM.
    
    Conflicts:
    	src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Fixtures/php/lazy_service.php
    	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Templating/Loader/FilesystemLoader.php
    	src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php
    	src/Symfony/Component/Config/Definition/ReferenceDumper.php
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/Debug/ErrorHandler.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataMapper/PropertyPathMapperTest.php
    	src/Symfony/Component/HttpFoundation/Response.php
    	src/Symfony/Component/HttpFoundation/StreamedResponse.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
    	src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
    	src/Symfony/Component/HttpKernel/Fragment/RoutableFragmentRenderer.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
    	src/Symfony/Component/Stopwatch/StopwatchPeriod.php
    	src/Symfony/Component/Translation/TranslatorInterface.php
    	src/Symfony/Component/Validator/ConstraintValidatorFactory.php
  4. unified return null usages

    fabpot committed Apr 16, 2014
Commits on Apr 15, 2014
Commits on Apr 13, 2014
Commits on Mar 12, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Mar 12, 2014
    * 2.3:
      [Process] Fix #9160 : escaping an argument with a trailing backslash on windows fails
      [Process] Fix some unit tests that create the process object instead of delegate it to the implementation
      [Process] Make process tests more accurate on exception messages
      [Process] Fix process status in TTY mode
      [Process] Use assertSame instead of assertEquals to avoid comparison against `null`
      [HttpFoundation] added some unit tests
      10158 get vary multiple
      made Cookie stringification more robust
      [Yaml] fix for a HHVM bug
Commits on Mar 4, 2014
  1. [Yaml] fix for a HHVM bug

    fabpot committed Mar 4, 2014
Commits on Feb 27, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Feb 27, 2014
    * 2.3:
      bumped Symfony version to 2.3.12
      updated VERSION for 2.3.11
      update CONTRIBUTORS for 2.3.11
      updated CHANGELOG for 2.3.11
      Follow-up to #10312: Fixed minor performance related issues in Yaml\Inline.
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
Commits on Feb 25, 2014
Commits on Feb 24, 2014
  1. Merge branch '2.3' into 2.4

    fabpot committed Feb 24, 2014
    * 2.3:
      [Process] minor fixes
      Improve performance of getNextEmbedBlock by removing unnecessary preg_match and function calls.
      Avoid unnecessary line indentation calculation.
      Optimise Inline::evaluateScalar() for parsing strings.
      fixed CS
      fixed parsing Mongo DSN and added Test for it
      () is also a valid delimiter
      Adding PHP 5.6 to travis-ci tests
      Update BCryptPasswordEncoder.php
      [Validator] Removed PHP <5.3.3 specific code which is not officially supported.
      Fixed wrong redirect url if path contains some query parameters
Commits on Feb 23, 2014
  1. Improve performance of getNextEmbedBlock by removing unnecessary preg…

    alexpott committed Feb 23, 2014
    …_match and function calls.