Commits on Jul 9, 2012
Commits on Jun 9, 2012
  1. merged branch jakzal/yamlDoubleQuotesDumperFix (PR #4320)

    fabpot committed Jun 9, 2012
    b631073 [Yaml] Fixed double quotes escaping in Dumper.
    [Yaml] Fixed double quotes escaping in Dumper
    Issue #4308 is caused by Dumper::escapeWithDoubleQuotes() which uses [str_replace()](
    From the php docs:
    > Because str_replace() replaces left to right, it might replace a previously inserted value when doing multiple replacements.
    We should be very careful in deciding about the order of elements in $escapees array. I'd really appreciate if someone reviewed my fix. Tests say I didn't break anything but I'm not sure what percentage of Yaml specification is covered by tests.
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: not that I know
    Symfony2 tests pass: [![Build Status](](
    Fixes the following tickets: #4308
    by travisbot at 2012-05-18T08:53:51Z
    This pull request [passes]( (merged 5192722c into a04acc89).
    by travisbot at 2012-05-18T23:19:49Z
    This pull request [fails]( (merged ecaa1aab into fc3c609b).
    by dinamic at 2012-05-19T07:35:21Z
    Something is really wrong with this method. You can see clearly that multiple characters would fail proper escaping.
    Here's an example:
    $value = '\\\\"some value\n \"some quoted string\" and \'some single quotes one\'"';
    string(72) ""\\\"some value\n \\some quoted string\\ and 'some single quotes one'\"""
    To begin with the backslash - in the initial value you have 2 (escaped ones), that after escaping should result in 4, not in 1 (escaped). I guess this behavior has to be verified with the importer, but imho it does not seem right.
    Does anyone know why this escaping wasn't done using a regular expression in first place?
    by clemens-tolboom at 2012-05-19T10:18:58Z
    Searching for\xc2\x85 the table on is interesting enough to decide we need way more documentation on this file.
    \xc2\x85 seems to be triple dot (ellipses)
    \xe2\x80\xa9 seems to be paragraph separator see
Commits on May 18, 2012
  1. fixed CS

    fabpot committed May 18, 2012
Commits on May 15, 2012
  1. fixed phpdoc @param alignment

    fabpot committed May 15, 2012
Commits on Feb 22, 2012
  1. Updated LICENSE files copyright

    marc.weistroff committed Feb 22, 2012
Commits on Jan 13, 2012
Commits on Jan 11, 2012
  1. optimized string starts with checks

    kriswallsmith committed Jan 11, 2012
    Doing this with strpos() is slightly faster than substr().
  2. fixed some phpdoc

    fabpot committed Jan 11, 2012
Commits on Jan 5, 2012
Commits on Dec 18, 2011
  1. fixed CS

    fabpot committed Dec 18, 2011
  2. tweaked the README files

    fabpot committed Dec 18, 2011
  3. merged branch lsmith77/component_readmes (PR #2561)

    fabpot committed Dec 18, 2011
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    added basic README files for all components and bridges
    heavily based on and the official Symfony2 documentation
    by jmikola at 2011/11/03 13:36:07 -0700
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    by lsmith77 at 2011/11/03 13:41:29 -0700
    by stealth35 at 2011/11/03 13:49:31 -0700
    Nice job, but you also need to add `<?php`
    ex :
    ``` php
    use Symfony\Component\DomCrawler\Crawler;
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    print $crawler->filter('body > p')->text();
    by lsmith77 at 2011/11/03 13:56:57 -0700
    by ericclemmons at 2011/11/03 19:57:57 -0700
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    by lsmith77 at 2011/11/04 01:18:23 -0700
    ok .. fixed the issues you mentioned @fabpot
    by lsmith77 at 2011/11/11 15:00:27 -0800
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    by drak at 2011/11/11 18:54:13 -0800
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at
    by lsmith77 at 2011/11/12 00:59:14 -0800
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <> wrote:
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at
    > ---
    > Reply to this email directly or view it on GitHub:
    > symfony/symfony#2561 (comment)
    by breerly at 2011/11/21 10:28:36 -0800
    Pretty excited with this.
    by dbu at 2011/11/24 00:02:50 -0800
    is there anything we can help with to make this ready to be merged?
    by lsmith77 at 2011/12/18 02:39:23 -0800
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
Commits on Dec 13, 2011
  1. [DoctrineBridge] fixed some CS

    fabpot committed Dec 13, 2011
Commits on Nov 17, 2011
Commits on Nov 4, 2011
Commits on Nov 3, 2011
  1. added basic README files for all components

    lsmith77 committed Nov 3, 2011
        heavily inspired by and the official Symfony2 documentation
Commits on Nov 2, 2011
Commits on Nov 1, 2011
Commits on Sep 26, 2011
  1. [composer] add composer.json

    igorw committed Sep 24, 2011
Commits on Aug 22, 2011
Commits on Jul 13, 2011
  1. [Yaml] Wrap numeric strings in quotes when dumping

    jmikola committed Jul 13, 2011
    This addresses an obscure case where a hash string (actually a commit-ish, "686e444") was dumped to YAML as an unquoted string value. It was later parsed from YAML as an exponential numeric and changed to ".Inf".
Commits on Jun 20, 2011
Commits on Jun 14, 2011
  1. [Yaml] moved exceptions to their own sub-namespace (added a specific …

    fabpot committed Jun 14, 2011
    …exception for the dump)
  2. fixed CS

    fabpot committed Jun 14, 2011
Commits on Jun 8, 2011
  1. fixed CS

    fabpot committed Jun 8, 2011
Commits on May 14, 2011
  1. [Yaml] tweaked error message

    fabpot committed May 14, 2011
Commits on May 12, 2011
  1. [Yaml] added exceptions when non-utf8 encoding is detected

    Martin Schuhfuss
    Martin Schuhfuss committed May 12, 2011
    encoding is detected using the `mb_detect_encoding()`-function
    in strict-mode. Checking is done before the parsing starts.
    Without this patch, the calls to `preg_replace()` using the
    'u'-modifier would cause the non-utf8-string being processed
    to be empty when parsing starts which makes the parsing return
    no result.
Commits on Apr 23, 2011
  1. [Phpdoc] Cleaning/fixing

    pborreli committed Apr 23, 2011
Commits on Apr 15, 2011
Commits on Mar 24, 2011