Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

phpDoc documents wrong exception #3

Closed
wants to merge 1 commit into from

3 participants

@lanthaler

The documentation of Yaml::parse() is wrong. It doesn't throw an InvalidArgumentException but a ParseException.

@stof

pull requests should be sent to symfony/symfony. The subtree splits are marked as read-only in their description, which means that only the cron job updating them from the symfony repo writes in them.

there is currently a discussion to see if it could be possible to accept pull requests coming both ways but we haven't set up the needed tools yet (or even figured if it can be done reliably)

@fabpot fabpot referenced this pull request from a commit in symfony/symfony
@lanthaler lanthaler [Yaml] fixed phpdoc (closes symfony/Yaml#3) 0ccb6fa
@fabpot fabpot closed this
@lanthaler
@lanthaler

Yeah sorry, I realized that just today as I read the conversation about this on the dev mailing list. Perhaps a reminder in the README would do it as I think a lot of people don't read that little note at the top.

@dustinwhittle dustinwhittle referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@mmucklo mmucklo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 26, 2012
  1. @lanthaler
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Yaml.php
View
2  Yaml.php
@@ -45,7 +45,7 @@ static public function enablePhpParsing()
*
* @return array The YAML converted to a PHP array
*
- * @throws \InvalidArgumentException If the YAML is not valid
+ * @throws ParseException If the YAML is not valid
*
* @api
*/
Something went wrong with that request. Please try again.