phpDoc documents wrong exception #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

lanthaler commented Mar 26, 2012

The documentation of Yaml::parse() is wrong. It doesn't throw an InvalidArgumentException but a ParseException.

Member

stof commented Apr 4, 2012

pull requests should be sent to symfony/symfony. The subtree splits are marked as read-only in their description, which means that only the cron job updating them from the symfony repo writes in them.

there is currently a discussion to see if it could be possible to accept pull requests coming both ways but we haven't set up the needed tools yet (or even figured if it can be done reliably)

fabpot added a commit to symfony/symfony that referenced this pull request Apr 5, 2012

@fabpot fabpot closed this Apr 5, 2012

Contributor

lanthaler commented Apr 5, 2012

Yeah sorry, I realized that just today as I read the conversation about this on the dev mailing list. Perhaps a reminder in the README would do it as I think a lot of people don't read that little note at the top.

Contributor

lanthaler commented Apr 5, 2012

Yeah sorry, I realized that just today as I read the conversation about this on the dev mailing list. Perhaps a reminder in the README would do it as I think a lot of people don't read that little note at the top.

fabpot added a commit that referenced this pull request Apr 20, 2012

teohhanhui pushed a commit to teohhanhui/Yaml that referenced this pull request Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment