From 20f3d0cdeacec5119bdb2a0ab4fc701a8838dc0b Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Wed, 3 Sep 2025 09:42:23 +0200 Subject: [PATCH] [Agent][Demo][Platform] Replace `self::assert*` with `$this->assert*` in test files --- demo/tests/SmokeTest.php | 12 ++++++------ .../MetadataFactory/ReflectionFactoryTest.php | 6 +++--- .../tests/Bridge/VertexAi/Gemini/ModelClientTest.php | 2 +- src/platform/tests/Message/AssistantMessageTest.php | 8 ++++---- src/platform/tests/Message/SystemMessageTest.php | 8 ++++---- src/platform/tests/Message/ToolCallMessageTest.php | 8 ++++---- src/platform/tests/Message/UserMessageTest.php | 8 ++++---- 7 files changed, 26 insertions(+), 26 deletions(-) diff --git a/demo/tests/SmokeTest.php b/demo/tests/SmokeTest.php index b61727ab9..6040a369b 100644 --- a/demo/tests/SmokeTest.php +++ b/demo/tests/SmokeTest.php @@ -26,9 +26,9 @@ public function testIndex() $client = static::createClient(); $client->request('GET', '/'); - self::assertResponseIsSuccessful(); - self::assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo'); - self::assertSelectorCount(5, '.card'); + $this->assertResponseIsSuccessful(); + $this->assertSelectorTextSame('h1', 'Welcome to the LLM Chain Demo'); + $this->assertSelectorCount(5, '.card'); } #[DataProvider('provideChats')] @@ -37,9 +37,9 @@ public function testChats(string $path, string $expectedHeadline) $client = static::createClient(); $client->request('GET', $path); - self::assertResponseIsSuccessful(); - self::assertSelectorTextSame('h4', $expectedHeadline); - self::assertSelectorCount(1, '#chat-submit'); + $this->assertResponseIsSuccessful(); + $this->assertSelectorTextSame('h4', $expectedHeadline); + $this->assertSelectorCount(1, '#chat-submit'); } /** diff --git a/src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php b/src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php index b55c11747..47daf46e3 100644 --- a/src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php +++ b/src/agent/tests/Toolbox/MetadataFactory/ReflectionFactoryTest.php @@ -64,7 +64,7 @@ public function testGetDefinition() /** @var Tool[] $metadatas */ $metadatas = iterator_to_array($this->factory->getTool(ToolRequiredParams::class)); - self::assertToolConfiguration( + $this->assertToolConfiguration( metadata: $metadatas[0], className: ToolRequiredParams::class, name: 'tool_required_params', @@ -96,7 +96,7 @@ public function testGetDefinitionWithMultiple() [$first, $second] = $metadatas; - self::assertToolConfiguration( + $this->assertToolConfiguration( metadata: $first, className: ToolMultiple::class, name: 'tool_hello_world', @@ -115,7 +115,7 @@ className: ToolMultiple::class, ], ); - self::assertToolConfiguration( + $this->assertToolConfiguration( metadata: $second, className: ToolMultiple::class, name: 'tool_required_params', diff --git a/src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php b/src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php index 96aec1ef2..3324a7ce5 100644 --- a/src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php +++ b/src/platform/tests/Bridge/VertexAi/Gemini/ModelClientTest.php @@ -67,7 +67,7 @@ public function testItPassesServerToolsFromOptions() ]; $httpClient = new MockHttpClient( function ($method, $url, $options) { - self::assertJsonStringEqualsJsonString( + $this->assertJsonStringEqualsJsonString( <<<'JSON' { "tools": [ diff --git a/src/platform/tests/Message/AssistantMessageTest.php b/src/platform/tests/Message/AssistantMessageTest.php index 4250f8a7c..4ed4d9302 100644 --- a/src/platform/tests/Message/AssistantMessageTest.php +++ b/src/platform/tests/Message/AssistantMessageTest.php @@ -68,8 +68,8 @@ public function testDifferentMessagesHaveDifferentUids() $message2 = new AssistantMessage('bar'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testSameMessagesHaveDifferentUids() @@ -78,8 +78,8 @@ public function testSameMessagesHaveDifferentUids() $message2 = new AssistantMessage('foo'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testMessageIdImplementsRequiredInterfaces() diff --git a/src/platform/tests/Message/SystemMessageTest.php b/src/platform/tests/Message/SystemMessageTest.php index 343786308..5a6276934 100644 --- a/src/platform/tests/Message/SystemMessageTest.php +++ b/src/platform/tests/Message/SystemMessageTest.php @@ -50,8 +50,8 @@ public function testDifferentMessagesHaveDifferentUids() $message2 = new SystemMessage('bar'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testSameMessagesHaveDifferentUids() @@ -60,8 +60,8 @@ public function testSameMessagesHaveDifferentUids() $message2 = new SystemMessage('foo'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testMessageIdImplementsRequiredInterfaces() diff --git a/src/platform/tests/Message/ToolCallMessageTest.php b/src/platform/tests/Message/ToolCallMessageTest.php index 9354625bd..4f0d6b251 100644 --- a/src/platform/tests/Message/ToolCallMessageTest.php +++ b/src/platform/tests/Message/ToolCallMessageTest.php @@ -55,8 +55,8 @@ public function testDifferentMessagesHaveDifferentUids() $message2 = new ToolCallMessage($toolCall, 'baz'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testSameMessagesHaveDifferentUids() @@ -66,8 +66,8 @@ public function testSameMessagesHaveDifferentUids() $message2 = new ToolCallMessage($toolCall, 'bar'); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testMessageIdImplementsRequiredInterfaces() diff --git a/src/platform/tests/Message/UserMessageTest.php b/src/platform/tests/Message/UserMessageTest.php index 1d61c5c69..9ac223050 100644 --- a/src/platform/tests/Message/UserMessageTest.php +++ b/src/platform/tests/Message/UserMessageTest.php @@ -95,8 +95,8 @@ public function testDifferentMessagesHaveDifferentUids() $message2 = new UserMessage(new Text('bar')); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testSameMessagesHaveDifferentUids() @@ -105,8 +105,8 @@ public function testSameMessagesHaveDifferentUids() $message2 = new UserMessage(new Text('foo')); $this->assertNotSame($message1->getId()->toRfc4122(), $message2->getId()->toRfc4122()); - self::assertIsUuidV7($message1->getId()->toRfc4122()); - self::assertIsUuidV7($message2->getId()->toRfc4122()); + $this->assertIsUuidV7($message1->getId()->toRfc4122()); + $this->assertIsUuidV7($message2->getId()->toRfc4122()); } public function testMessageIdImplementsRequiredInterfaces()