From dcb7f3ad1e61105496916852fe3e991b4438c77b Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Thu, 11 Sep 2025 17:27:03 +0200 Subject: [PATCH] [Agent] Make `$options` parameter default to empty array in `Input` and `Output` --- src/agent/src/Input.php | 2 +- src/agent/src/Output.php | 2 +- .../InputProcessor/ModelOverrideInputProcessorTest.php | 2 +- .../InputProcessor/SystemPromptInputProcessorTest.php | 10 +++++----- .../tests/StructuredOutput/AgentProcessorTest.php | 4 ++-- src/agent/tests/Toolbox/AgentProcessorTest.php | 10 +++++----- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/agent/src/Input.php b/src/agent/src/Input.php index 47087b3f7..0187a18af 100644 --- a/src/agent/src/Input.php +++ b/src/agent/src/Input.php @@ -25,7 +25,7 @@ final class Input public function __construct( public Model $model, public MessageBag $messages, - private array $options, + private array $options = [], ) { } diff --git a/src/agent/src/Output.php b/src/agent/src/Output.php index d7553e451..0e48f4c2a 100644 --- a/src/agent/src/Output.php +++ b/src/agent/src/Output.php @@ -27,7 +27,7 @@ public function __construct( public readonly Model $model, public ResultInterface $result, public readonly MessageBag $messages, - public readonly array $options, + public readonly array $options = [], ) { } } diff --git a/src/agent/tests/InputProcessor/ModelOverrideInputProcessorTest.php b/src/agent/tests/InputProcessor/ModelOverrideInputProcessorTest.php index a30768cc2..bfa1f42f9 100644 --- a/src/agent/tests/InputProcessor/ModelOverrideInputProcessorTest.php +++ b/src/agent/tests/InputProcessor/ModelOverrideInputProcessorTest.php @@ -48,7 +48,7 @@ public function testProcessInputWithValidModelOption() public function testProcessInputWithoutModelOption() { $gpt = new Gpt(); - $input = new Input($gpt, new MessageBag(), []); + $input = new Input($gpt, new MessageBag()); $processor = new ModelOverrideInputProcessor(); $processor->processInput($input); diff --git a/src/agent/tests/InputProcessor/SystemPromptInputProcessorTest.php b/src/agent/tests/InputProcessor/SystemPromptInputProcessorTest.php index 23059442e..39919cd32 100644 --- a/src/agent/tests/InputProcessor/SystemPromptInputProcessorTest.php +++ b/src/agent/tests/InputProcessor/SystemPromptInputProcessorTest.php @@ -47,7 +47,7 @@ public function testProcessInputAddsSystemMessageWhenNoneExists() { $processor = new SystemPromptInputProcessor('This is a system prompt'); - $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message')), []); + $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message'))); $processor->processInput($input); $messages = $input->messages->getMessages(); @@ -65,7 +65,7 @@ public function testProcessInputDoesNotAddSystemMessageWhenOneExists() Message::forSystem('This is already a system prompt'), Message::ofUser('This is a user message'), ); - $input = new Input(new Gpt(), $messages, []); + $input = new Input(new Gpt(), $messages); $processor->processInput($input); $messages = $input->messages->getMessages(); @@ -92,7 +92,7 @@ public function execute(ToolCall $toolCall): mixed } ); - $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message')), []); + $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message'))); $processor->processInput($input); $messages = $input->messages->getMessages(); @@ -130,7 +130,7 @@ public function execute(ToolCall $toolCall): mixed } ); - $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message')), []); + $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message'))); $processor->processInput($input); $messages = $input->messages->getMessages(); @@ -170,7 +170,7 @@ public function execute(ToolCall $toolCall): mixed } ); - $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message')), []); + $input = new Input(new Gpt(), new MessageBag(Message::ofUser('This is a user message'))); $processor->processInput($input); $messages = $input->messages->getMessages(); diff --git a/src/agent/tests/StructuredOutput/AgentProcessorTest.php b/src/agent/tests/StructuredOutput/AgentProcessorTest.php index 6e23369e3..37c381a83 100644 --- a/src/agent/tests/StructuredOutput/AgentProcessorTest.php +++ b/src/agent/tests/StructuredOutput/AgentProcessorTest.php @@ -56,7 +56,7 @@ public function testProcessInputWithoutOutputStructure() $processor = new AgentProcessor(new ConfigurableResponseFormatFactory()); $model = new Model('gpt-4', [Capability::OUTPUT_STRUCTURED]); - $input = new Input($model, new MessageBag(), []); + $input = new Input($model, new MessageBag()); $processor->processInput($input); @@ -162,7 +162,7 @@ public function testProcessOutputWithoutResponseFormat() $model = self::createMock(Model::class); $result = new TextResult(''); - $output = new Output($model, $result, new MessageBag(), []); + $output = new Output($model, $result, new MessageBag()); $processor->processOutput($output); diff --git a/src/agent/tests/Toolbox/AgentProcessorTest.php b/src/agent/tests/Toolbox/AgentProcessorTest.php index 5f0cd6408..e2624d91e 100644 --- a/src/agent/tests/Toolbox/AgentProcessorTest.php +++ b/src/agent/tests/Toolbox/AgentProcessorTest.php @@ -49,7 +49,7 @@ public function testProcessInputWithoutRegisteredToolsWillResultInNoOptionChange $model = new Model('gpt-4', [Capability::TOOL_CALLING]); $processor = new AgentProcessor($toolbox); - $input = new Input($model, new MessageBag(), []); + $input = new Input($model, new MessageBag()); $processor->processInput($input); @@ -65,7 +65,7 @@ public function testProcessInputWithRegisteredToolsWillResultInOptionChange() $model = new Model('gpt-4', [Capability::TOOL_CALLING]); $processor = new AgentProcessor($toolbox); - $input = new Input($model, new MessageBag(), []); + $input = new Input($model, new MessageBag()); $processor->processInput($input); @@ -94,7 +94,7 @@ public function testProcessInputWithUnsupportedToolCallingWillThrowException() $model = new Model('gpt-3'); $processor = new AgentProcessor($this->createStub(ToolboxInterface::class)); - $input = new Input($model, new MessageBag(), []); + $input = new Input($model, new MessageBag()); $processor->processInput($input); } @@ -115,7 +115,7 @@ public function testProcessOutputWithToolCallResponseKeepingMessages() $processor = new AgentProcessor($toolbox, keepToolMessages: true); $processor->setAgent($agent); - $output = new Output($model, $result, $messageBag, []); + $output = new Output($model, $result, $messageBag); $processor->processOutput($output); @@ -140,7 +140,7 @@ public function testProcessOutputWithToolCallResponseForgettingMessages() $processor = new AgentProcessor($toolbox, keepToolMessages: false); $processor->setAgent($agent); - $output = new Output($model, $result, $messageBag, []); + $output = new Output($model, $result, $messageBag); $processor->processOutput($output);