Skip to content

[AI Bundle] Shift chain factory service definition to fix agent definition #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

[AI Bundle] Shift chain factory service definition to fix agent definition #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/ai-bundle/src/AiBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,14 @@ private function processAgentConfig(string $name, array $config, ContainerBuilde
// TOOLBOX
if ($config['tools']['enabled']) {
// Setup toolbox for agent
$memoryFactoryDefinition = new ChildDefinition('ai.tool_factory.abstract');
$memoryFactoryDefinition->setClass(MemoryToolFactory::class);
$container->setDefinition('ai.toolbox.'.$name.'.memory_factory', $memoryFactoryDefinition);
$chainFactoryDefinition = new Definition(ChainFactory::class, [
[new Reference('ai.toolbox.'.$name.'.memory_factory'), new Reference('ai.tool_factory')],
]);
$container->setDefinition('ai.toolbox.'.$name.'.chain_factory', $chainFactoryDefinition);

$toolboxDefinition = (new ChildDefinition('ai.toolbox.abstract'))
->replaceArgument(1, new Reference('ai.toolbox.'.$name.'.chain_factory'))
->addTag('ai.toolbox', ['name' => $name]);
Expand Down Expand Up @@ -624,14 +632,6 @@ private function processAgentConfig(string $name, array $config, ContainerBuilde

// Define specific list of tools if are explicitly defined
if ([] !== $config['tools']['services']) {
$memoryFactoryDefinition = new ChildDefinition('ai.tool_factory.abstract');
$memoryFactoryDefinition->setClass(MemoryToolFactory::class);
$container->setDefinition('ai.toolbox.'.$name.'.memory_factory', $memoryFactoryDefinition);
$chainFactoryDefinition = new Definition(ChainFactory::class, [
[new Reference('ai.toolbox.'.$name.'.memory_factory'), new Reference('ai.tool_factory')],
]);
$container->setDefinition('ai.toolbox.'.$name.'.chain_factory', $chainFactoryDefinition);

$tools = [];
foreach ($config['tools']['services'] as $tool) {
if (isset($tool['agent'])) {
Expand Down