[Platform] Fix platform creation #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzwilding
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
franzwilding
changed the title
chr-hertel
approved these changes
Nov 4, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Oh, i guess that's my bad with #802 - thanks for patching that 🙏
chr-hertel
force-pushed
the
fix/platform-creaton
branch
from
6b6a10a to
4f01e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the platform bundle does not test creating of all possible platforms. Because of this, some more exotic models like mistral could not be created (because of a PR of me some time ago).
This PR fixes the creation of all platforms and also adds an test to really get the instances of the (lazy) services.