Process model configuration from semantic config #916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ai.model configuration in the AI Bundle is now properly processed and passed to ModelCatalog services. Previously, the configuration was validated but never used by the bundle. This fix adds: - processModelConfig() method to process model configuration - getModelClassForPlatform() method to map platform names to model classes - Support for anthropic, openai, gemini, mistral, and ollama platforms - Proper handling of vertexai platform name mapping Fixes symfony#898
carsonbot
changed the title
OskarStark
commented
Nov 21, 2025
| * | ||
| * @return class-string|null | ||
| */ | ||
| private function getModelClassForPlatform(string $platformName): ?string |
Contributor
Author
There was a problem hiding this comment.
@chr-hertel we can get rid of this when making the class required in the config which feels ok to me, WDYT?
I am talking about:
Member
|
nice try, but github actions do not fall for this 😆 vs. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #898
The
ai.modelconfiguration in the AI Bundle is now properly processed and passed toModelCatalogservices. Previously, the configuration was validated but never used by the bundle, requiring users to manually configure services inservices.yaml.Changes
processModelConfig()method to process model configuration from semantic configgetModelClassForPlatform()helper method to map platform names to model classesExample
With this fix, the following configuration now works as expected:
The model will be properly passed to the
OllamaModelCatalogconstructor without requiring manual service configuration.Testing