Permalink
Commits on Dec 28, 2015
  1. @stof

    bug #407 enable the StaticAsseticHelperPass (xabbuh)

    This PR was merged into the 2.7-dev branch.
    
    Discussion
    ----------
    
    enable the StaticAsseticHelperPass
    
    This fixes #406.
    
    Commits
    -------
    
    0f75a27 enable the StaticAsseticHelperPass
    stof committed Dec 28, 2015
  2. @xabbuh

    enable the StaticAsseticHelperPass

    This fixes #406.
    xabbuh committed Dec 28, 2015
  3. @stof

    minor #399 Fix travis typo (alinalexandru)

    This PR was merged into the 2.7-dev branch.
    
    Discussion
    ----------
    
    Fix travis typo
    
    Commits
    -------
    
    95eb7b5 Fix travis typo
    stof committed Dec 28, 2015
  4. @stof

    bug #402 fix request in DefaultValueSupplier (albert-gonzalez)

    This PR was squashed before being merged into the 2.7-dev branch (closes #402).
    
    Discussion
    ----------
    
    fix request in DefaultValueSupplier
    
    In Symfony 3 the service 'request' has been removed from the container, and the function isScopeActive doesn't exist anymore. With this fix the Request Stack is injected in DefaultValueSupplier to get the request.
    
    Commits
    -------
    
    29198ae fix request in DefaultValueSupplier
    stof committed Dec 28, 2015
  5. @albert-gonzalez @stof
Commits on Dec 5, 2015
  1. @alinalexandru

    Fix travis typo

    alinalexandru committed Dec 5, 2015
Commits on Dec 3, 2015
  1. @kriswallsmith

    Merge pull request #390 from thetiby/master

    Added CleanCSS filter config
    kriswallsmith committed Dec 3, 2015
Commits on Dec 1, 2015
  1. @stof

    bug #395 Fixing 3.0 compatibility problem with ResourceInterface::isF…

    …resh() (weaverryan)
    
    This PR was merged into the 2.7-dev branch.
    
    Discussion
    ----------
    
    Fixing 3.0 compatibility problem with ResourceInterface::isFresh()
    
    Hi guys!
    
    The bundle is not ready for 3.0 yet, because of [AsseticResource](https://github.com/symfony/assetic-bundle/blob/master/Config/AsseticResource.php). Implementing `isFresh()` on `ResourceInterface` is deprecated: we need to also implement `SelfCheckingResourceInterface`.
    
    But this patch clearly has issues: it makes AsseticBundle require symfony/config 2.8 (and worse, beta currently). Is there a way to make the bundle compatible with 2.7 (where `SelfCheckingResourceInterface` doesn't exist) AND 3.0 (where `SelfCheckingResourceInterface` is required) at the same time?
    
    Thanks!
    
    Commits
    -------
    
    49c7279 Adding a new SelfCheckingAsseticResource for compat with 2.8-3.0+
    stof committed Dec 1, 2015
Commits on Nov 24, 2015
  1. @weaverryan

    Adding a new SelfCheckingAsseticResource for compat with 2.8-3.0+

    In 2.8, the SelfCheckingResourceInterface becomes available and you must
    implement it for 3.0. An if statement either uses the old AsseticResource
    (which does not include this interface) or the new SelfCheckingAsseticResource
    if the interface exists.
    weaverryan committed Nov 23, 2015
Commits on Nov 17, 2015
  1. @stof

    Update the changelog

    stof committed Nov 17, 2015
  2. @stof

    minor #394 Add symfony 3.0 support (Ener-Getick)

    This PR was merged into the 2.7-dev branch.
    
    Discussion
    ----------
    
    Add symfony 3.0 support
    
    This PR adds symfony 3.0 support.
    
    Commits
    -------
    
    1482825 Add symfony 3.0 support
    stof committed Nov 17, 2015
Commits on Nov 12, 2015
  1. @Ener-Getick

    Add symfony 3.0 support

    Ener-Getick committed Nov 11, 2015
Commits on Oct 12, 2015
  1. @thetiby

    Added CleanCSS filter config

    thetiby committed Nov 25, 2014
Commits on Sep 1, 2015
  1. @stof

    Add a readme file

    Closes #306
    stof committed Sep 1, 2015
  2. @stof

    Update the changelog

    stof committed Sep 1, 2015
Commits on Aug 31, 2015
  1. @stof
  2. @stof

    Add the web folder as load path for the sass filter

    This makes it consistent with the Scss filter.
    Refs #125
    stof committed Aug 31, 2015
  3. @stof

    Update the branch alias

    stof committed Aug 31, 2015
  4. @stof

    bug #332 Use the etag in the internal AssetCache cache key (EvanPurkh…

    …iser)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Use the etag in the internal AssetCache cache key
    
    When using the AsseticController to serve assets that have a filter applied to them implementing the [`DependencyExtractorInterface`](https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/DependencyExtractorInterface.php) the etag will be correctly computed using `AssetFactory::getLastModified`, which properly takes into account filters marked with this interface.
    
    However. The asset is then cached using the `AssetCache`, which only takes into consideration the modification time of the asset itself, and _does not_ take into account the modification time of dependencies. The effect is that when a dependency of an asset is changed (for example a SCSS file that imports another SCSS file) the etag will correctly differ and the response will be considered modified, but the `AssetCache` will incorrectly assume that the asset has not changed. The root cause is that assets derive their last modified independently from any other asset, so `AssetCache` can only do the same.
    
    After spending some time understanding the problem we came up with what we think is an appropriate solution. This doesn't alter any APIs so I think it may be merged in as a patch.
    
    The AssetCache will compute the cache key based upon metadata about the asset, among these things are the filters that were applied to the asset. In particular, [the serialization of the filter](https://github.com/kriswallsmith/assetic/blob/50a30b23ce4229b408d99d580d1f056908dfb64f/src/Assetic/Asset/AssetCache.php#L159-L165). If the filter also implements the `HashableInterface` then the `hash` method will be used to add to the cache key. Originally this was simply meant for [when a filter can't be serialized](kriswallsmith/assetic#228), but we can take advantage of this and use it to add additional metadata to the cache key.
    
    In this implementation we create a custom filter implementing `HashableInterface` that is simply used to add an additional component to the cache key and not modify the content in load or dump. This then instantiated with the etag as the cache key (since this includes the proper modified time) and is passed along to the AssetCache.
    
    Commits
    -------
    
    5067a03 Use the etag in the internal AssetCache cache key
    stof committed Aug 31, 2015
  5. @stof

    feature #357 [Config] Treat NULL like "all bundles" (default behaviou…

    …r) (loostro)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [Config] Treat NULL like "all bundles" (default behaviour)
    
    Allow to overwrite value with "all bundles" (default behaviour) for given enviroment.
    
    Eg. if `config.yml` has `bundles: [DemoBundle]` and in `config_dev.yml` I want to overwrite that to "all bundles" (default) with this PR merged I could do that with `bundles: ~`.
    
    Commits
    -------
    
    82d3f86 Update Configuration.php
    stof committed Aug 31, 2015
  6. @stof

    feature #326 Add configuration for precision (trivago-makbarof)

    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Add configuration for precision
    
    Now in assetic it's possible to set the precision of decimals
    So we also need a way to set it in symfony which I think this is the correct way
    The commit for assetic: kriswallsmith/assetic@ec53b62
    
    Commits
    -------
    
    e9c5a22 Add configuration for precision
    stof committed Aug 31, 2015
  7. @stof
  8. @stof

    feature #347 Allow configuration of sass/scss filter sourcemap option…

    …. (thetiby)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Allow configuration of sass/scss filter sourcemap option.
    
    This is [already supported](https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/Sass/SassFilter.php#L86) by assetic.
    
    Commits
    -------
    
    cc966da Allow configuration of sass/scss filter sourcemap option.
    stof committed Aug 31, 2015
  9. @stof

    minor #379 Fix the Twig_Environment service in the container tests fo…

    …r Twig 2 (stof)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Fix the Twig_Environment service in the container tests for Twig 2
    
    Commits
    -------
    
    820093c Refactor the static assets helper to use Symfony 3 APIs
    275f6fe Fix tests for Symfony 3 by enabling the asset component
    a20ce0a Fix the Twig_Environment service in the container tests
    stof committed Aug 31, 2015
  10. @stof
  11. @stof
  12. @stof
  13. @stof

    Merge pull request #378 from stof/test_dev

    Add testing against dev dependencies
    stof committed Aug 31, 2015
  14. @stof
  15. @stof
  16. @stof

    feature #375 Add support for Twig 2 (stof)

    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Add support for Twig 2
    
    This depends on https://github.com/kriswallsmith/assetic/pull/751for the TokenParser change (but the bundle is still compatible with older versions of Assetic not implementing this change, and current versions of the bundle are compatible with Assetic with the change applied thanks to BC layers)
    
    Commits
    -------
    
    5874fdf Add support for Twig 2
    stof committed Aug 31, 2015
Commits on Aug 20, 2015
  1. @stof

    Add support for Twig 2

    stof committed Aug 20, 2015
  2. @stof

    minor #368 Add PHP 7 on Travis (Soullivaneuh)

    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Add PHP 7 on Travis
    
    Commits
    -------
    
    3215442 Add PHP 7 on Travis
    stof committed Aug 20, 2015
  3. @Soullivaneuh @Soullivaneuh

    Add PHP 7 on Travis

    Soullivaneuh committed with Soullivaneuh Jul 30, 2015
  4. @stof