Permalink
Commits on Sep 1, 2012
  1. load test

    eventhorizonpl committed Aug 27, 2012
Commits on Aug 27, 2012
  1. dump test

    fix things pointed out by stof
    
    fix things pointed out by pborreli
    
    fix things pointed out by fabpot
    eventhorizonpl committed Aug 23, 2012
Commits on Aug 25, 2012
  1. merged branch willdurand/fix-composer-components (PR #5318)

    Commits
    -------
    
    933e821 Add minimum-stability (dev) in each component
    
    Discussion
    ----------
    
    Add minimum-stability (dev) in each component
    
    This fixes the ability to run the test suite in each component if a `composer install` is needed.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T13:57:14Z
    
    If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great.
    Anyway, 👍 for this
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-08-22T13:59:15Z
    
    Yes I already did that once. I'll try to fix more components later.
    
    On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet <
    notifications@github.com> wrote:
    
    > If you really want to run the testsuite standalone, some dev requirements
    > are missing (SecurityBundle needs the FrameworkBundle for its functional
    > tests for instance). If you have some time to check the missing dev
    > requirement, it would be great.
    > Anyway, [image: 👍] for this
    >
    > —
    > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>.
    >
    >
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:02:23Z
    
    Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle)
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:14:00Z
    
    what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-22T14:30:13Z
    
    please, don't add more travis files. The main already tests everything, and that's all we need.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:33:46Z
    
    @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps).
    Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis.
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:42:30Z
    
    ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook
    
    ---------------------------------------------------------------------------
    
    by hason at 2012-08-24T13:12:04Z
    
    @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T13:35:07Z
    
    @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
    fabpot committed Aug 25, 2012
Commits on Aug 24, 2012
  1. getNamespaces test

    getPrefixes test
    
    loadClass test
    
    getPrefixes test
    
    addPrefix test
    
    getFallbackDirs test
    
    fix things pointed out by stof
    eventhorizonpl committed Aug 23, 2012
Commits on Aug 22, 2012
Commits on Jul 15, 2012
  1. Revert "raised the minimum version of PHP to 5.3.4 (closes #3856)"

    This reverts commit 2dcc44897ef1ceec2721bbf616c4744131340657.
    fabpot committed Jul 15, 2012
Commits on Jul 13, 2012
  1. raised the minimum version of PHP to 5.3.4 (closes #3856)

    We've raised the minimum version of PHP because of a PHP
    bug before 5.3.4:
    
    https://bugs.php.net/bug.php?id=52083
    https://bugs.php.net/bug.php?id=50027
    fabpot committed Jul 13, 2012
Commits on Jul 10, 2012
  1. [ClassLoader] fixed order of interfaces in generated class collection…

    … caches (closes #4841)
    fabpot committed Jul 10, 2012
Commits on Jul 9, 2012
  1. merged branch bamarni/master (PR #4792)

    Commits
    -------
    
    6c9c2ec [ClassCollectionLoader] fixed comment striping on classes in global namespace
    
    Discussion
    ----------
    
    [ClassCollectionLoader] fixed comment striping on classes in global namespace
    
    Comments aren't striped when the class is in the global namespace, this adds a fake namespace to let the fixNamespaceDeclaration method handling the formating, so we can remove a method.
    
    I've also put dev as minimum policy in composer, otherwise I couldn't install dependencies.
    fabpot committed Jul 9, 2012
  2. fixed CS

    fabpot committed Jul 9, 2012
Commits on Jul 8, 2012
Commits on Jul 4, 2012
  1. merged branch fabpot/classloader-optim (PR #4729)

    Commits
    -------
    
    3f9e8ff [ClassLoader] made ClassCollectionLoader::load() automatically include class dependencies
    6f4d281 [ClassLoader] added missing support for PHP 5.4 traits
    
    Discussion
    ----------
    
    Classloader optimization
    
    The first commit fixes support for PHP 5.4 trait.
    
    The second one does several things:
    
     * it optimizes the recent merge so that the reflection class instance is only loaded once;
     * we use the fact that we now get all class dependencies to automatically add all class dependencies to the map.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-03T17:26:46Z
    
    I've updated to take into accounts traits.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-07-04T11:58:57Z
    
    great job 👍
    
    I can't see it in the diff as this part hasn't changed, but somewhere in the autoReload block there is :
    ```
    if ($meta[1] != $classes) {
        $reload = true;
    }
    ```
    
    It should be array_unique($classes), otherwise the file would be perpetually regenerated in autoReload mode when the input contains duplicate, because they're implicitely removed when dumping the files.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-04T13:20:04Z
    
    @bamarni I've added an `array_unique` call at the top (this bug existed before by the way).
    fabpot committed Jul 4, 2012
  2. [ClassLoader] made ClassCollectionLoader::load() automatically includ…

    …e class dependencies
    fabpot committed Jul 3, 2012
Commits on Jul 3, 2012
  1. [ClassLoader] fixed typo

    fabpot committed Jul 3, 2012
  2. fixed unit tests

    fabpot committed Jul 3, 2012
Commits on Jun 19, 2012
Commits on May 21, 2012
  1. fixed CS

    fabpot committed May 21, 2012
Commits on May 15, 2012
  1. added @ to all chmod() calls to avoid PHP warnings (operation not per…

    …mitted) when using CIFS or NTFSa (closes #2125)
    fabpot committed May 15, 2012
Commits on May 7, 2012
  1. updated minimum PHP version to 5.3.3

    5.3.3 has some interesting fixes and this is the version used by
    Redhat 6 and Debian 6
    fabpot committed May 7, 2012
Commits on May 1, 2012
  1. merged branch willdurand/fix-components (PR #4155)

    Commits
    -------
    
    c195957 [Components] Tests/Autoloading fixes
    
    Discussion
    ----------
    
    Fix components
    
    See #4141
    
    ----
    This PR:
    
    * configures each component to use composer to manage "dev" dependencies instead of env variables;
    * adds phpunit configuration file on Filesystem component;
    * fixes READMEs.
    
    It's mergeable without any problems, but I would recommend to wait a fix in Composer in order to use `self.version` in `require`/`require-dev` sections.
    
    Note: I kept `suggest` sections because it makes sense but this PR doesn't aim to provide useful explanations for each entry. It could be another PR, not that one.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-04-30T20:43:13Z
    
    @fabpot I reviewed each component, one by one. Now `phpunit` always works, even if tests are skipped. A simple `composer install --dev` allows to run the complete test suite. Each commit is well separated from the others. I guess, everything is ok now.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-30T20:47:00Z
    
    Please squash, as it makes no sense to have the same commit for each component.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-01T14:26:11Z
    
    Can you squash your commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-05-01T14:29:38Z
    
    done
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-01T15:48:25Z
    
    It does not seem that the commits are squashed.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-05-01T15:54:08Z
    
    done
    fabpot committed May 1, 2012
  2. [Components] Tests/Autoloading fixes

    * Switched to Composer to manage "dev" dependencies
    * Fixed READMEs
    * Excluded vendor in phpunit.xml.dist files
    * Fixed message in bootstrap.php files
    * Added autoloader for the component itself
    willdurand committed Apr 27, 2012
  3. fixed CS

    fabpot committed May 1, 2012
Commits on Apr 27, 2012
  1. Revert "merged branch Seldaek/master (PR #4133)"

    This reverts commit 00e7a94a8c761a3e10c388e4d06cb3ce4cd04ad7, reversing
    changes made to a01dec00f4e8de357cce5fdf121ac98729f7f8ff.
    fabpot committed Apr 27, 2012
  2. Update branch aliases

    Seldaek committed Apr 27, 2012
Commits on Apr 26, 2012
  1. [ClassLoader] added CHANGELOG

    fabpot committed Apr 26, 2012
Commits on Apr 25, 2012
  1. merged 2.0

    fabpot committed Apr 25, 2012
Commits on Apr 23, 2012
  1. [2.1][Component][ClassLoader] cs

    gajdaw committed Apr 23, 2012
  2. [2.0][Component][ClassLoader] cs

    gajdaw committed Apr 23, 2012
Commits on Apr 19, 2012
  1. Fix umasks in chmod() calls

    vicb committed Apr 19, 2012
  2. Fix chmod() calls to apply umask

    Seldaek committed Apr 19, 2012
  3. Fix #3929

    rouffj committed Apr 19, 2012
Commits on Apr 14, 2012
  1. [Tests] Use proper assertions

    stloyd committed Apr 12, 2012
Commits on Apr 11, 2012
  1. merged branch kimhemsoe/xcache_classloader (PR #3809)

    Commits
    -------
    
    c36651b Fixed spelling error
    f123684 Removed leftover from c/p
    b74a5d4 Updated to new cache loader pattern.
    7e66908 Added XCache class loader
    
    Discussion
    ----------
    
    [ClassLoader] Added XCache class loader
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    There is no tests, as it seems there is no way to use xcache storage functions from CLI.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-04-06T20:12:09Z
    
    Please implement a XcacheClassLoader following the same pattern than the new ApcClassLoader instead
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2012-04-07T14:20:47Z
    
    - should include tests
    - should include documentation (will you also update the component documentation for this new class?)
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-04-07T14:25:00Z
    
    @cordoval the PR explains why there is no tests: xcache canot be used in the CLI.
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2012-04-07T14:26:43Z
    
    ok @stof sorry it said it seemed not to be possible, i thought it was possible but I am wrong.
    
    ---------------------------------------------------------------------------
    
    by kimhemsoe at 2012-04-07T15:01:24Z
    
    @cordoval My english is really horrible. I would not mind if someone else could do that task for me. We also need to add doc for the new ApcClassLoader.
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2012-04-07T15:03:57Z
    
    I wish you can explain me more then about this class and how to use it in code so then I can write easily the documentation :D deal?
    
    ---------------------------------------------------------------------------
    
    by kimhemsoe at 2012-04-07T15:21:25Z
    
    Deal :P
    
    The XcacheClassLoader and ApcClassLoader replaces the old ApcUniversalClassLoader.
    They giving us support for using another loader then UniversalClassLoader, without duplicating the cache layer.
    Aslong it have a public function findFile($class) method.
    
     $loader = new ClassLoader();
    
    // register classes with namespaces
    $loader->add('Symfony\Component', __DIR__.'/component');
    $loader->add('Symfony', __DIR__.'/framework');
    
    $cachedLoader = new XcacheClassLoader('my_prefix', $loader);
    
    // activate the cached autoloader
    $cachedLoader->register();
    
    Think that is more or less the essence of this.
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2012-04-09T08:28:53Z
    
    it is not add but registerNamespace right?
    
    so the main idea is to get rid of the restriction to use Apc with Universal loader
    
    what is the comparative advantage between APC and Xcache?
    
    ---------------------------------------------------------------------------
    
    by kimhemsoe at 2012-04-09T08:55:23Z
    
    Yes if the $loader (class finder) were to be a instance UniversalClassLoader.
    
    Yes the main idea is to be able to reuse the cache layer with any class loader there obey to the one restriction.
    
    Difference between apc and xcache and why to use what is coming down to taste and your setup. We use xcache as APC have some issues in fastcgi setups. when we upgrade to php54 at somepoint we get to chance to move to php-fpm wich solves these issues. Short story: Slightly out of scope for any documentation in here :-P
    fabpot committed Apr 11, 2012