Permalink
Commits on Mar 8, 2013
  1. Fixed test to use Reflection

    merk committed Mar 8, 2013
Commits on Mar 3, 2013
Commits on Mar 2, 2013
Commits on Feb 27, 2013
  1. merged branch lsmith77/debugclassloader_findfile_2_1 (PR #7168)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    0690709 added a DebuClassLoader::findFile() method to make the wrapping less invasive
    
    Discussion
    ----------
    
    added a DebuClassLoader::findFile() method to make the wrapping less invasive
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    
    i have classified it as a bug fix, since due to the wrapping it can break assumptions about the loaded class loader, so implementing this method at least doesnt break the assumption that ``findFile()`` is available.
    
    actually i think we should also introduced a loader interface to reduce the duct typing
    
    ---------------------------------------------------------------------------
    
    by stof at 2013-02-24T16:39:46Z
    
    👎 for the interface:
    
    - it would make the use of the autoloader more difficult (you would have to require the interface before requiring the loader)
    - it would forbid using these wrappers with the composer ClassLoader
    
    ---------------------------------------------------------------------------
    
    by digitalkaoz at 2013-02-24T19:16:36Z
    
    mh, i think all autoloaders should follow a common interface, maybe its worth to think about a PSR?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2013-02-24T19:27:27Z
    
    ah I see
    
    ---------------------------------------------------------------------------
    
    by stof at 2013-02-24T20:33:07Z
    
    @digitalkaoz Such an interface would have to be in PHP itself, otherwise, you would have to require it first each time (as it cannot be autoloaded before registering the autoloader). And an autoloader in PHP is just a callable.
    
    ---------------------------------------------------------------------------
    
    by digitalkaoz at 2013-02-24T20:47:10Z
    
    Yes @stof, i know, but it would be nice if all autoloaders follows a common pattern , call it a convention ;)
    fabpot committed Feb 27, 2013
Commits on Feb 24, 2013
Commits on Jan 26, 2013
Commits on Jan 19, 2013
Commits on Jan 9, 2013
Commits on Jan 4, 2013
  1. Merge branch '2.0' into 2.1

    * 2.0:
      updated license year
      Update src/Symfony/Component/HttpFoundation/Response.php
      [Console] fixed unitialized properties (closes #5935)
      [Bundle] [FrameworkBundle] fixed typo in phpdoc of the SessionListener.
      bumped Symfony version to 2.0.21-DEV
      updated VERSION for 2.0.21
      updated CHANGELOG for 2.0.21
    
    Conflicts:
    	src/Symfony/Bundle/SwiftmailerBundle/LICENSE
    	src/Symfony/Component/Filesystem/LICENSE
    	src/Symfony/Component/HttpFoundation/Response.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot committed Jan 4, 2013
  2. updated license year

    fabpot committed Jan 4, 2013
Commits on Dec 6, 2012
Commits on Nov 8, 2012
  1. Fix export-ignore on Windows

    gajdaw committed Nov 8, 2012
Commits on Oct 27, 2012
  1. Merge branch '2.0' into 2.1

    * 2.0:
      [ClassLoader] fixed unbracketed namespaces (closes #5747)
    
    Conflicts:
    	src/Symfony/Component/ClassLoader/ClassCollectionLoader.php
    	tests/Symfony/Tests/Component/ClassLoader/ClassCollectionLoaderTest.php
    fabpot committed Oct 27, 2012
Commits on Oct 4, 2012
Commits on Sep 1, 2012
  1. load test

    eventhorizonpl committed Aug 27, 2012
Commits on Aug 27, 2012
  1. dump test

    fix things pointed out by stof
    
    fix things pointed out by pborreli
    
    fix things pointed out by fabpot
    eventhorizonpl committed Aug 23, 2012
Commits on Aug 25, 2012
  1. merged branch willdurand/fix-composer-components (PR #5318)

    Commits
    -------
    
    933e821 Add minimum-stability (dev) in each component
    
    Discussion
    ----------
    
    Add minimum-stability (dev) in each component
    
    This fixes the ability to run the test suite in each component if a `composer install` is needed.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T13:57:14Z
    
    If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great.
    Anyway, 👍 for this
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-08-22T13:59:15Z
    
    Yes I already did that once. I'll try to fix more components later.
    
    On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet <
    notifications@github.com> wrote:
    
    > If you really want to run the testsuite standalone, some dev requirements
    > are missing (SecurityBundle needs the FrameworkBundle for its functional
    > tests for instance). If you have some time to check the missing dev
    > requirement, it would be great.
    > Anyway, [image: 👍] for this
    >
    > —
    > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>.
    >
    >
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:02:23Z
    
    Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle)
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:14:00Z
    
    what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-22T14:30:13Z
    
    please, don't add more travis files. The main already tests everything, and that's all we need.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-22T14:33:46Z
    
    @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps).
    Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis.
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-08-22T14:42:30Z
    
    ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook
    
    ---------------------------------------------------------------------------
    
    by hason at 2012-08-24T13:12:04Z
    
    @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-24T13:35:07Z
    
    @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
    fabpot committed Aug 25, 2012
Commits on Aug 24, 2012
  1. getNamespaces test

    getPrefixes test
    
    loadClass test
    
    getPrefixes test
    
    addPrefix test
    
    getFallbackDirs test
    
    fix things pointed out by stof
    eventhorizonpl committed Aug 23, 2012
Commits on Aug 22, 2012
Commits on Jul 15, 2012
  1. Revert "raised the minimum version of PHP to 5.3.4 (closes #3856)"

    This reverts commit 2dcc44897ef1ceec2721bbf616c4744131340657.
    fabpot committed Jul 15, 2012
Commits on Jul 13, 2012
  1. raised the minimum version of PHP to 5.3.4 (closes #3856)

    We've raised the minimum version of PHP because of a PHP
    bug before 5.3.4:
    
    https://bugs.php.net/bug.php?id=52083
    https://bugs.php.net/bug.php?id=50027
    fabpot committed Jul 13, 2012
Commits on Jul 10, 2012
  1. [ClassLoader] fixed order of interfaces in generated class collection…

    … caches (closes #4841)
    fabpot committed Jul 10, 2012
Commits on Jul 9, 2012
  1. merged branch bamarni/master (PR #4792)

    Commits
    -------
    
    6c9c2ec [ClassCollectionLoader] fixed comment striping on classes in global namespace
    
    Discussion
    ----------
    
    [ClassCollectionLoader] fixed comment striping on classes in global namespace
    
    Comments aren't striped when the class is in the global namespace, this adds a fake namespace to let the fixNamespaceDeclaration method handling the formating, so we can remove a method.
    
    I've also put dev as minimum policy in composer, otherwise I couldn't install dependencies.
    fabpot committed Jul 9, 2012
  2. fixed CS

    fabpot committed Jul 9, 2012
Commits on Jul 8, 2012
Commits on Jul 4, 2012
  1. merged branch fabpot/classloader-optim (PR #4729)

    Commits
    -------
    
    3f9e8ff [ClassLoader] made ClassCollectionLoader::load() automatically include class dependencies
    6f4d281 [ClassLoader] added missing support for PHP 5.4 traits
    
    Discussion
    ----------
    
    Classloader optimization
    
    The first commit fixes support for PHP 5.4 trait.
    
    The second one does several things:
    
     * it optimizes the recent merge so that the reflection class instance is only loaded once;
     * we use the fact that we now get all class dependencies to automatically add all class dependencies to the map.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-03T17:26:46Z
    
    I've updated to take into accounts traits.
    
    ---------------------------------------------------------------------------
    
    by bamarni at 2012-07-04T11:58:57Z
    
    great job 👍
    
    I can't see it in the diff as this part hasn't changed, but somewhere in the autoReload block there is :
    ```
    if ($meta[1] != $classes) {
        $reload = true;
    }
    ```
    
    It should be array_unique($classes), otherwise the file would be perpetually regenerated in autoReload mode when the input contains duplicate, because they're implicitely removed when dumping the files.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-07-04T13:20:04Z
    
    @bamarni I've added an `array_unique` call at the top (this bug existed before by the way).
    fabpot committed Jul 4, 2012
  2. [ClassLoader] made ClassCollectionLoader::load() automatically includ…

    …e class dependencies
    fabpot committed Jul 3, 2012
Commits on Jul 3, 2012
  1. [ClassLoader] fixed typo

    fabpot committed Jul 3, 2012
  2. fixed unit tests

    fabpot committed Jul 3, 2012
Commits on Jun 19, 2012
Commits on May 21, 2012
  1. fixed CS

    fabpot committed May 21, 2012