Skip to content
Permalink
Branch: master
Commits on Aug 14, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Remove superfluous phpdoc tags
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      Remove superfluous phpdoc tags
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      Remove superfluous phpdoc tags
Commits on Aug 13, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add type declarations to private DefaultChoiceListFactory methods
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  4. Fix return statements

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 10, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 10, 2019
    * 4.3:
      cleanups
      Disable PHPUnit result cache on the CI
      [Security] Cleanup "Digest nonce has expired." translation
      [Translation] Highlight invalid translation status
      Added translations in validator for Serbian Cyrillic
      Added translations in validator for Serbian Latin
      [EventDispatcher] wrong Request class
      [DependencyInjection] improved exception message
  2. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 10, 2019
    * 3.4:
      cleanups
      Disable PHPUnit result cache on the CI
      [Translation] Highlight invalid translation status
Commits on Aug 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Replace warning by isolated test
      Fix deprecation in 4.4 branche
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Replace warning by isolated test
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Replace warning by isolated test
  4. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Fix compatibility with PHPUnit 8
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  5. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  6. minor #33000 Fix deprecations on 4.3 (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Fix deprecations on 4.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    Fix deprecations in branch 4.3
    note: remaining deprecation `assertStringContainsString` will be fixed in #32977
    
    * [ ] fix tests in branch 3.4 in #32981
    
    Commits
    -------
    
    8fd16a6bee Fix deprecation on 4.3
  7. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Remove unneeded phpdocs
  8. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Debug] Improve UPGRADE files
      remove wrongly added legacy group from test
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      add missing conflict rule
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      remove some more useless phpdocs
      Resilience against file_get_contents() race conditions.
      Turned return type annotations of private methods into php return types.
  9. minor #32993 Turned return type annotations of private methods into p…

    nicolas-grekas committed Aug 8, 2019
    …hp return types (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    Turned return type annotations of private methods into php return types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    As discussed with @nicolas-grekas in symfony/symfony#30323 (comment), this PR attempts to turn `@return` annotations on private methods into return type declarations.
    
    Commits
    -------
    
    f54ca001fe Turned return type annotations of private methods into php return types.
Commits on Aug 7, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 7, 2019
    * 4.4:
      [ErrorRenderer] Fix timestamp on logs view
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 7, 2019
    * 4.3:
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 7, 2019
    * 3.4:
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  4. bug #32516 [FrameworkBundle][Config] Ignore exceptions thrown during …

    nicolas-grekas committed Aug 7, 2019
    …reflection classes autoload (fancyweb)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle][Config] Ignore exceptions thrown during reflection classes autoload
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#32499 with PHP 7.3+
    | License       | MIT
    | Doc PR        | -
    
    The behavior when an exception is thrown in a class loader changed in PHP 7.3 (cf https://3v4l.org/OQPk9). That means that the `throwOnRequiredClass` trick that is done in the parent class of these cache warmers (`AbstractPhpFileCacheWarmer`) does not work anymore with PHP7.3+.
    
    Commits
    -------
    
    dbd9b75d86 [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  5. Merge branch '4.4'

    nicolas-grekas committed Aug 7, 2019
    * 4.4:
      fix merge
      Fix inconsistent return points.
      pass translation parameters to the trans filter
      [Mime] fixed wrong mimetype
      [ProxyManagerBridge] Polyfill for unmaintained version
      [HttpClient] Declare `$active` first to prevent weird issue
      Remove deprecated assertContains
      [HttpClient] fix tests
      SCA: dropped unused mocks, duplicate import and a function alias usage
      Added correct plural for box -> boxes
      [Config] fix test
      Fix remaining tests
      fix getName() when transport is null
      [Console] Check for ErrorHandler classes
      Improve fa (persian) translation
  6. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 7, 2019
    * 4.3:
      Fix inconsistent return points.
      pass translation parameters to the trans filter
      [Mime] fixed wrong mimetype
      [ProxyManagerBridge] Polyfill for unmaintained version
      [HttpClient] Declare `$active` first to prevent weird issue
      Remove deprecated assertContains
      [HttpClient] fix tests
      SCA: dropped unused mocks, duplicate import and a function alias usage
      Added correct plural for box -> boxes
      [Config] fix test
      Fix remaining tests
      Improve fa (persian) translation
  7. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 7, 2019
    * 3.4:
      Fix inconsistent return points.
      Fix remaining tests
  8. bug #32981 Fix tests/code for php 7.4 (jderusse)

    nicolas-grekas committed Aug 7, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix tests/code for php 7.4
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    Fix remaining tests and deprecation
    
    Commits
    -------
    
    05ec8a08b4 Fix remaining tests
  9. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 7, 2019
    * 3.4:
      [ProxyManagerBridge] Polyfill for unmaintained version
      SCA: dropped unused mocks, duplicate import and a function alias usage
      [Config] fix test
      Improve fa (persian) translation
Commits on Aug 6, 2019
  1. [Config] fix test

    nicolas-grekas committed Aug 6, 2019
  2. Merge branch '4.4'

    nicolas-grekas committed Aug 6, 2019
    * 4.4:
      bump phpunit-bridge cache-id
      removed unneeded phpdocs
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 6, 2019
    * 4.3:
      bump phpunit-bridge cache-id
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 6, 2019
    * 3.4:
      bump phpunit-bridge cache-id
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
Commits on Aug 3, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 3, 2019
    * 4.4:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 3, 2019
    * 4.3:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 3, 2019
    * 3.4:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
Older
You can’t perform that action at this time.