From 5113ee5765e347383829ab1dd0ffa1d0babea92c Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Mon, 14 Nov 2016 00:44:51 +0200 Subject: [PATCH 1/2] Add note about deploying dev environment to Heroku --- app.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app.json b/app.json index ace673aaf..57c8f536c 100644 --- a/app.json +++ b/app.json @@ -13,7 +13,10 @@ "postdeploy": "php bin/console doctrine:schema:create && php bin/console doctrine:fixtures:load -n" }, "env": { - "SYMFONY_ENV": "prod", + "SYMFONY_ENV": { + "value": "prod", + "description": "If you want to be able to use the Symfony `dev` environment in the deployed version, you will need to move the necessary dependencies like `SensioGeneratorBundle` to normal requirements rather than `dev` requirements, but it will be a security issue, because development tools like the `WebProfiler` can be revealing sensitive information." + }, "SYMFONY_LOG": "php://stderr", "SYMFONY_SECRET": { "description": "Extra entropy for %kernel.secret%; used for CSRF tokens, cookies and signed URLs.", From 00259b7913efb804fce9264af5adaba1774c5015 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Fri, 18 Nov 2016 08:18:40 +0100 Subject: [PATCH 2/2] Tweaked the warning message --- app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.json b/app.json index 57c8f536c..aa1b8c36d 100644 --- a/app.json +++ b/app.json @@ -15,7 +15,7 @@ "env": { "SYMFONY_ENV": { "value": "prod", - "description": "If you want to be able to use the Symfony `dev` environment in the deployed version, you will need to move the necessary dependencies like `SensioGeneratorBundle` to normal requirements rather than `dev` requirements, but it will be a security issue, because development tools like the `WebProfiler` can be revealing sensitive information." + "description": "If you want to use the Symfony `dev` environment in the deployed application, you must move the necessary dependencies (like SensioGeneratorBundle) from `require-dev` to `require`. This will introduce security issues because development tools like the WebProfiler reveal sensitive information." }, "SYMFONY_LOG": "php://stderr", "SYMFONY_SECRET": {