Permalink
Commits on Nov 13, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Nov 13, 2017
    * 3.4:
      [DI] Fix dumping with custom base class
      fixed typo
      [HttpFoundation] Add test
      [HttpFoundation] Fix session-related BC break
      [Process] Workaround PHP bug #75515 in ProcessTest::testSimpleInputStream()
      [FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands
      fix method name
  2. Merge branch '3.3' into 3.4

    nicolas-grekas committed Nov 13, 2017
    * 3.3:
      [DI] Fix dumping with custom base class
      [HttpFoundation] Add test
      [HttpFoundation] Fix session-related BC break
      [Process] Workaround PHP bug #75515 in ProcessTest::testSimpleInputStream()
      fix method name
Commits on Nov 12, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Nov 12, 2017
    * 3.4:
      [TwigBridge] Fixed the .form-check-input class in the bs4 templates
      [Console] Fix traversable autocomplete values
      [SecurityBundle] Improve deprecations
      [DI] Friendlier name for generated container in "as_files" mode
      [Debug] Remove false-positive deprecation from DebugClassLoader
      [SecurityBundle] Add missing quotes in deprecation messages
      [ExpressionLanguage] Fix PhpDoc type-hints on Token value
      bumped Symfony version to 3.3.12
      Add default translations path option and convention
      updated VERSION for 3.3.11
      updated CHANGELOG for 3.3.11
      bumped Symfony version to 2.8.30
      updated VERSION for 2.8.29
      updated CHANGELOG for 2.8.29
      bumped Symfony version to 2.7.37
      updated VERSION for 2.7.36
      update CONTRIBUTORS for 2.7.36
      updated CHANGELOG for 2.7.36
Commits on Nov 11, 2017
Commits on Nov 9, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Nov 9, 2017
    * 3.4:
      [DI] Add "container.hot_path" tag to flag the hot path and inline related services
      [FrameworkBundle] Fine-tune generated annotations.php cache
      [HttpFoundation] Prevent PHP from sending Last-Modified on session start
      Micro optim using explicit root namespaces
Commits on Nov 7, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Nov 7, 2017
    * 3.4:
      [3.4] Remove useless docblocks
      [3.3] More docblock fixes
      [2.7] More docblock fixes
      [TwigBridge] Fix BC break due required twig environment
      Random fixes
      Docblock fixes
      [DI] Fix cannot bind env var
      Fix some signatures in PHP-DSLs
      [HttpKernel] Enhance deprecation message
      bumped Symfony version to 3.4.0
      updated VERSION for 3.4.0-BETA3
      updated CHANGELOG for 3.4.0-BETA3
      [SecurityBundle] Fix the datacollector to properly support decision.object being null
  2. Merge branch '3.3' into 3.4

    nicolas-grekas committed Nov 7, 2017
    * 3.3:
      [3.3] More docblock fixes
      [2.7] More docblock fixes
  3. Merge branch '2.8' into 3.3

    nicolas-grekas committed Nov 7, 2017
    * 2.8:
      [2.7] More docblock fixes
  4. Merge branch '2.7' into 2.8

    nicolas-grekas committed Nov 7, 2017
    * 2.7:
      [2.7] More docblock fixes
  5. bug #24850 [DI] Fix cannot bind env var (ogizanagi)

    nicolas-grekas committed Nov 7, 2017
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] Fix cannot bind env var
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see comment below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
    | Tests pass?   | yes
    | Fixed tickets | #24845 <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A
    
    In #24602 we removed the processing of bindings from the `AbstractRecursivePass`. But there is actually one case where we want a recursive pass to process them: to resolve env param placeholders.
    
    Commits
    -------
    
    f8f3a15 [DI] Fix cannot bind env var
  6. minor #24846 Fix some signatures in PHP-DSLs (nicolas-grekas)

    nicolas-grekas committed Nov 7, 2017
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix some signatures in PHP-DSLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    af85431 Fix some signatures in PHP-DSLs
  7. Merge branch '3.3' into 3.4

    nicolas-grekas committed Nov 7, 2017
    * 3.3:
      Random fixes
      Docblock fixes
      [HttpKernel] Enhance deprecation message
      [SecurityBundle] Fix the datacollector to properly support decision.object being null
  8. Random fixes

    nicolas-grekas committed Nov 7, 2017
  9. Merge branch '2.8' into 3.3

    nicolas-grekas committed Nov 7, 2017
    * 2.8:
      Docblock fixes
  10. Merge branch '2.7' into 2.8

    nicolas-grekas committed Nov 7, 2017
    * 2.7:
      Docblock fixes
  11. Docblock fixes

    nicolas-grekas committed Nov 7, 2017
  12. [DI] Fix cannot bind env var

    ogizanagi committed Nov 7, 2017
Commits on Nov 6, 2017
Commits on Nov 5, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Nov 5, 2017
    * 3.4:
      Remove useless phpdoc
      [DI] Fix the "almost-circular refs" fix
      [Form] Fix low deps
  2. Merge branch '3.4'

    nicolas-grekas committed Nov 5, 2017
    * 3.4:
      [HttpFoundation] refactoring: calculate when need
      [Serializer] Fix extra attributes when no group specified
      [Intl] Make intl-data tests pass and save language aliases again
      [FrameworkBundle][Config] fix: do not add resource checkers for debug=false
      [DI] Fix "almost-circular" dependencies handling
      [Console] Fix CommandTester::setInputs() docblock
      Only enabling validation if it is present
      Fix displaying errors for bootstrap 4
      [Serializer] readd default argument value
      Fix reference dump for deprecated nodes
      [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass
      [HttpKernel] Let the storage manage the session starts
      [VarDumper] fix trailling comma when dumping an exception
      [Validator] Fix TraceableValidator is reset on data collector instantiation
      Remove useless docblocks
      [FrameworkBundle] Fix docblocks
      [PropertyInfo] Remove useless docblocks
  3. Merge branch '3.3' into 3.4

    nicolas-grekas committed Nov 5, 2017
    * 3.3:
      [Serializer] Fix extra attributes when no group specified
      [Intl] Make intl-data tests pass and save language aliases again
      [Console] Fix CommandTester::setInputs() docblock
      [Serializer] readd default argument value
      [VarDumper] fix trailling comma when dumping an exception
      Remove useless docblocks
      [FrameworkBundle] Fix docblocks
      [PropertyInfo] Remove useless docblocks
  4. Merge branch '2.8' into 3.3

    nicolas-grekas committed Nov 5, 2017
    * 2.8:
      [Intl] Make intl-data tests pass and save language aliases again
      Remove useless docblocks
      [PropertyInfo] Remove useless docblocks
  5. Merge branch '2.7' into 2.8

    nicolas-grekas committed Nov 5, 2017
    * 2.7:
      [Intl] Make intl-data tests pass and save language aliases again
      Remove useless docblocks
Commits on Oct 29, 2017
  1. Remove useless docblocks

    nicolas-grekas committed Oct 28, 2017
Commits on Oct 28, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Oct 28, 2017
    * 3.4:
      Ensure DeprecationErrorHandler::collectDeprecations() is triggered
      Config: mark builder property deprecated
      fix CachePoolPrunerPass to use correct command service id
      [TwigBridge] Re-add Bootstrap 3 Checkbox Layout
      [FrameworkBundle] Allow to disable assets via framework:assets xml configuration
      fixed $_ENV/$_SERVER precedence in test framework
      [HttpFoundation] Fix FileBag issue with associative arrays
      [DI] Throw when a service name or an alias contains dynamic values (prevent an infinite loop)
      [HttpFoundation] Fix caching of session-enabled pages
      [Guard] remove invalid deprecation notice
      fix the phpdoc that is not really inherited from response
      Minor docblock cleanup
      Remove redundant sprintf arguments.
  2. Merge branch '3.3' into 3.4

    nicolas-grekas committed Oct 28, 2017
    * 3.3:
      Ensure DeprecationErrorHandler::collectDeprecations() is triggered
      [FrameworkBundle] Allow to disable assets via framework:assets xml configuration
      fixed $_ENV/$_SERVER precedence in test framework
      [HttpFoundation] Fix FileBag issue with associative arrays
      [DI] Throw when a service name or an alias contains dynamic values (prevent an infinite loop)
      fix the phpdoc that is not really inherited from response
      Minor docblock cleanup
      Remove redundant sprintf arguments.
Commits on Oct 26, 2017
  1. bug #24686 Fix $_ENV/$_SERVER precedence in test framework (fabpot)

    fabpot committed Oct 26, 2017
    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    Fix $_ENV/$_SERVER precedence in test framework
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    When defining env vars values in `phpunit.xml.dist`, we are using `<env ...>`. PHPUnit registers those env vars in `$_ENV`, but not in `$_SERVER`. This means that those values might not be used by Symfony if env vars defined in `.env` are automatically registered (which is my case).
    
    In any case, I think it makes sense to make `$_ENV` take precedence as this is how we register them in `phpunit.xml.dist`.
    
    Commits
    -------
    
    6ed9919d24 fixed $_ENV/$_SERVER precedence in test framework