Permalink
Commits on Jul 21, 2017
  1. Merge branch '3.4'

    * 3.4: (22 commits)
      use Precise on Travis to keep PHP LDAP support
      Fix case sensitive sameSite cookie
      [PropertyInfo] Use rawurlencode to escape PSR-6 keys
      fix(security): ensure the 'route' index is set before attempting to use it
      Fix registering lazy command services with autoconfigure enabled
      Fix the design of the profiler exceptions when there is no message
      [Config] Minor fix
      document the TwigRenderer class deprecation
      [Security] added more tests
      [Security] fixed default target path when referer contains a query string
      [Security] simplified tests
      [Security] refactored tests
      [WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages
      [FrameworkBundle] fix ValidatorCacheWarmer: use serializing ArrayAdapter
      Change "this" to "that" to avoid confusion
      [VarDumper] Move locale sniffing to dump() time
      [VarDumper] Use "C" locale when using "comma" flags
      [Config] Make ClassExistenceResource throw on invalid parents
      [DebugBundle] Added min_depth to Configuration
      [Console] Add a factory command loader for standalone application with lazy-loading needs
      ...
    nicolas-grekas committed Jul 21, 2017
Commits on Jul 19, 2017
  1. Merge branch '3.3' into 3.4

    * 3.3:
      [Security] added more tests
      [Security] fixed default target path when referer contains a query string
      [Security] simplified tests
      [Security] refactored tests
      [WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages
      [FrameworkBundle] fix ValidatorCacheWarmer: use serializing ArrayAdapter
      Change "this" to "that" to avoid confusion
      [VarDumper] Move locale sniffing to dump() time
      [VarDumper] Use "C" locale when using "comma" flags
      [Config] Make ClassExistenceResource throw on invalid parents
    fabpot committed Jul 19, 2017
  2. Merge branch '3.2' into 3.3

    * 3.2:
      [Security] added more tests
      [Security] fixed default target path when referer contains a query string
      [Security] simplified tests
      [Security] refactored tests
      [FrameworkBundle] fix ValidatorCacheWarmer: use serializing ArrayAdapter
      Change "this" to "that" to avoid confusion
      [VarDumper] Move locale sniffing to dump() time
    fabpot committed Jul 19, 2017
  3. feature #23561 [DI] Optimize use of private and pre-defined services …

    …(nicolas-grekas)
    
    This PR was merged into the 4.0-dev branch.
    
    Discussion
    ----------
    
    [DI] Optimize use of private and pre-defined services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes (perf)
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    By making private services really private and taking into account that (un)setting pre-defined services is not allowed anymore, we can go one step further into optimizing the dumped container.
    
    Commits
    -------
    
    c0c1881fe4 [DI] Optimize use of private and pre-defined services
    fabpot committed Jul 19, 2017
  4. minor #23579 [DI] Change "this" to "that" in `findAndSortTaggedServic…

    …es` doc to reduce confusion (simshaun)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [DI] Change "this" to "that" in `findAndSortTaggedServices` doc to reduce confusion
    
    Continuation of PR #23578 which I royally messed up.....
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    | Doc PR        | None
    
    I know this is extremely minor, but reading the description of this method, I got confused. Wondering if it's just me.
    
    Where it says:
    
    > The order of additions must be respected for services having the same priority, and knowing that the \SplPriorityQueue class does not respect the FIFO method, we should not use **this** class.
    
    Should it not say "we should not use **that** class"?
    
    Commits
    -------
    
    04b7b04b65 Change "this" to "that" to avoid confusion
    fabpot committed Jul 19, 2017
Commits on Jul 18, 2017
  1. Merge branch '3.4'

    * 3.4:
      remove useless comment
      [FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface
      fix merge
    nicolas-grekas committed Jul 18, 2017
  2. Merge branch '3.3' into 3.4

    * 3.3:
      remove useless comment
      fix merge
    nicolas-grekas committed Jul 18, 2017
  3. fix merge

    nicolas-grekas committed Jul 18, 2017
  4. Merge branch '3.4'

    * 3.4:
      [DI] Resolve aliases earlier
      [DI] Mark Container::$privates as internal
      [DI] Minor dumping logic simplification
      bumped Symfony version to 3.3.6
      updated VERSION for 3.3.5
      updated CHANGELOG for 3.3.5
      bumped Symfony version to 3.2.13
      updated VERSION for 3.2.12
      updated CHANGELOG for 3.2.12
      bumped Symfony version to 2.8.26
      updated VERSION for 2.8.25
      updated CHANGELOG for 2.8.25
      bumped Symfony version to 2.7.33
      updated VERSION for 2.7.32
      update CONTRIBUTORS for 2.7.32
      updated CHANGELOG for 2.7.32
    nicolas-grekas committed Jul 18, 2017
  5. Merge branch '3.3' into 3.4

    * 3.3:
      [DI] Resolve aliases earlier
      [DI] Mark Container::$privates as internal
      [DI] Minor dumping logic simplification
      bumped Symfony version to 3.3.6
      updated VERSION for 3.3.5
      updated CHANGELOG for 3.3.5
      bumped Symfony version to 3.2.13
      updated VERSION for 3.2.12
      updated CHANGELOG for 3.2.12
      bumped Symfony version to 2.8.26
      updated VERSION for 2.8.25
      updated CHANGELOG for 2.8.25
      bumped Symfony version to 2.7.33
      updated VERSION for 2.7.32
      update CONTRIBUTORS for 2.7.32
      updated CHANGELOG for 2.7.32
    nicolas-grekas committed Jul 18, 2017
  6. Merge branch '3.2' into 3.3

    * 3.2:
      [DI] Resolve aliases earlier
      [DI] Mark Container::$privates as internal
      bumped Symfony version to 3.2.13
      updated VERSION for 3.2.12
      updated CHANGELOG for 3.2.12
      bumped Symfony version to 2.8.26
      updated VERSION for 2.8.25
      updated CHANGELOG for 2.8.25
      bumped Symfony version to 2.7.33
      updated VERSION for 2.7.32
      update CONTRIBUTORS for 2.7.32
      updated CHANGELOG for 2.7.32
    nicolas-grekas committed Jul 18, 2017
  7. Merge branch '2.8' into 3.2

    * 2.8:
      [DI] Resolve aliases earlier
      bumped Symfony version to 2.8.26
      updated VERSION for 2.8.25
      updated CHANGELOG for 2.8.25
      bumped Symfony version to 2.7.33
      updated VERSION for 2.7.32
      update CONTRIBUTORS for 2.7.32
      updated CHANGELOG for 2.7.32
    nicolas-grekas committed Jul 18, 2017
  8. Merge branch '2.7' into 2.8

    * 2.7:
      [DI] Resolve aliases earlier
      bumped Symfony version to 2.7.33
      updated VERSION for 2.7.32
      update CONTRIBUTORS for 2.7.32
      updated CHANGELOG for 2.7.32
    nicolas-grekas committed Jul 18, 2017
Commits on Jul 17, 2017
  1. Merge branch '3.4'

    * 3.4: (22 commits)
      Fix lazy commands registration
      [TwigBridge] deprecate TwigRenderer
      [FrameworkBundle] Set default public directory on install assets
      [Security] Fix wrong term in UserProviderInterface
      [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
      disable inlining deprecated services
      [Stopwatch] Fix precision for root section
      [Cache] add constructor docblocks for clarity
      [WebServerBundle] allowed public/ root directory to be auto-discovered along side web/
      [WebServerBundle] remove duplicate code
      [SecurityBundle] Clarify deprecation in UserPasswordEncoderCommand::getContainer
      [Profiler][Validator] ValidatorDataCollector: use new DataCollector::getCasters() method
      [Profiler] Fix data collector getCasters() call
      [VarDumper] Added setMinDepth to VarCloner
      remove symfony/process suggestion
      [DI] Remove unused dynamic property
      [Cache] add constructor docblocks for clarity
      [Security] validate empty passwords again
      [Process] Fixed issue between process builder and exec
      non-conflicting anonymous service ids across files
      ...
    nicolas-grekas committed Jul 17, 2017
  2. Merge branch '3.3' into 3.4

    * 3.3:
      [FrameworkBundle] Set default public directory on install assets
      [Security] Fix wrong term in UserProviderInterface
      [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
      disable inlining deprecated services
      [Cache] add constructor docblocks for clarity
      [WebServerBundle] allowed public/ root directory to be auto-discovered along side web/
      [WebServerBundle] remove duplicate code
      [SecurityBundle] Clarify deprecation in UserPasswordEncoderCommand::getContainer
      [Cache] add constructor docblocks for clarity
      [Security] validate empty passwords again
      [DI] Remove irrelevant comment from container
      [TwigBridge] cleaner implementation of the TwigRenderer
    fabpot committed Jul 17, 2017
  3. Merge branch '3.2' into 3.3

    * 3.2:
      [Security] Fix wrong term in UserProviderInterface
      [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
      disable inlining deprecated services
      [Cache] add constructor docblocks for clarity
      [Security] validate empty passwords again
      [DI] Remove irrelevant comment from container
      [TwigBridge] cleaner implementation of the TwigRenderer
    fabpot committed Jul 17, 2017
  4. Merge branch '2.8' into 3.2

    * 2.8:
      [Security] Fix wrong term in UserProviderInterface
      [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
      disable inlining deprecated services
      [Security] validate empty passwords again
      [DI] Remove irrelevant comment from container
      [TwigBridge] cleaner implementation of the TwigRenderer
    fabpot committed Jul 17, 2017
  5. Merge branch '2.7' into 2.8

    * 2.7:
      [Security] Fix wrong term in UserProviderInterface
      [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
      [Security] validate empty passwords again
      [DI] Remove irrelevant comment from container
      [TwigBridge] cleaner implementation of the TwigRenderer
    fabpot committed Jul 17, 2017
  6. minor #23452 [DI] Remove irrelevant comment from container (ro0NL)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DI] Remove irrelevant comment from container
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes-ish
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->
    
    Spotted in #22811
    
    Commits
    -------
    
    595a225a0f [DI] Remove irrelevant comment from container
    fabpot committed Jul 17, 2017
Commits on Jul 15, 2017
  1. Merge branch '3.3' into 3.4

    * 3.3:
      [Profiler] Fix data collector getCasters() call
      remove symfony/process suggestion
      [DI] Remove unused dynamic property
      [Process] Fixed issue between process builder and exec
      non-conflicting anonymous service ids across files
    nicolas-grekas committed Jul 15, 2017
Commits on Jul 14, 2017
Commits on Jul 13, 2017
  1. Merge branch '3.4'

    * 3.4:
      [DI] Check privates before resolving alias in Container::initialized
      [FrameworkBundle] Fix tests
    nicolas-grekas committed Jul 13, 2017
Commits on Jul 12, 2017
  1. feature #23484 [DI] Remove remaining deprecated features (nicolas-gre…

    …kas)
    
    This PR was merged into the 4.0-dev branch.
    
    Discussion
    ----------
    
    [DI] Remove remaining deprecated features
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
     * removed autowiring services based on the types they implement
     * removed the `DefinitionDecorator` class, replaced by `ChildDefinition`
     * removed the `AutowireServiceResource` class and related `AutowirePass::createResourceForClass()` method
     * removed `LoggingFormatter`, `Compiler::getLoggingFormatter()` and `addLogMessage()` class and methods, use the `ContainerBuilder::log()` method instead
     * removed `FactoryReturnTypePass`
     * removed `ContainerBuilder::addClassResource()`, use the `addObjectResource()` or the `getReflectionClass()` method instead.
     * removed support for top-level anonymous services
     * removed silent behavior for unused attributes and elements
     * Removed the "framework.validation.cache" configuration option. Configure the "cache.validator" service under "framework.cache.pools" instead.
    
    Commits
    -------
    
    4bd7b921f4 [DI] Remove remaining deprecated features
    fabpot committed Jul 12, 2017
  2. fix merge

    nicolas-grekas committed Jul 12, 2017