Permalink
Commits on Jan 5, 2012
Commits on Dec 27, 2011
  1. ParameterBag no longer resolves parameters that have spaces.

    They must be strictly "%some.parameter%" or similar.
    ericclemmons committed Dec 27, 2011
Commits on Dec 18, 2011
  1. fixed CS

    fabpot committed Dec 18, 2011
  2. tweaked the README files

    fabpot committed Dec 18, 2011
  3. merged branch lsmith77/component_readmes (PR #2561)

    Commits
    -------
    
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    
    Discussion
    ----------
    
    added basic README files for all components and bridges
    
    heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2011/11/03 13:36:07 -0700
    
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:41:29 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by stealth35 at 2011/11/03 13:49:31 -0700
    
    Nice job, but you also need to add `<?php`
    
    ex :
    
    ``` php
    <?php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    
    print $crawler->filter('body > p')->text();
    ```
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:56:57 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by ericclemmons at 2011/11/03 19:57:57 -0700
    
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/04 01:18:23 -0700
    
    ok .. fixed the issues you mentioned @fabpot
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/11 15:00:27 -0800
    
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    
    ---------------------------------------------------------------------------
    
    by drak at 2011/11/11 18:54:13 -0800
    
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/12 00:59:14 -0800
    
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:
    
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > symfony/symfony#2561 (comment)
    
    ---------------------------------------------------------------------------
    
    by breerly at 2011/11/21 10:28:36 -0800
    
    Pretty excited with this.
    
    ---------------------------------------------------------------------------
    
    by dbu at 2011/11/24 00:02:50 -0800
    
    is there anything we can help with to make this ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/18 02:39:23 -0800
    
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
    fabpot committed Dec 18, 2011
Commits on Dec 13, 2011
  1. [DoctrineBridge] fixed some CS

    fabpot committed Dec 13, 2011
Commits on Dec 8, 2011
  1. [DependencyInjection] Made the reference case insensitive

    The container is case insensitive so using capital letters in a reference
    made it fail in some cases when checking the dependencies.
    Closes #2807
    stof committed Dec 8, 2011
Commits on Nov 30, 2011
  1. Throw exceptions in case someone forgot to set method name in call.

    Bug fix: yes
    Feature add: no
    Symfony2 tests pass: yes
    Symfony2 tests added: yes
    
    In general without this exception generated by php dumper container class, will cause PHP fatal error, bacause method call will look like this: `$instance->(/* arguments*/);`.
    canni committed Nov 30, 2011
Commits on Nov 24, 2011
  1. removed unused use statements

    fabpot committed Nov 24, 2011
Commits on Nov 23, 2011
Commits on Nov 17, 2011
Commits on Nov 3, 2011
  1. added basic README files for all components

        heavily inspired by http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    lsmith77 committed Nov 3, 2011
Commits on Nov 2, 2011
Commits on Nov 1, 2011
Commits on Oct 29, 2011
  1. removed unused use statements

    fabpot committed Oct 29, 2011
Commits on Oct 27, 2011
  1. [DependencyInjection] Fix DefinitionDecorator::getArgument() for repl…

    …acements
    
    While Definition::getArgument() could be used to fetch replaced values, it relied upon bad comparison logic (e.g. "index_1" > 1). Additionally, storing original arguments and replacements in the same array makes Definition::getArguments()'s bounds check unreliable. A single argument and its replacement would count twice, allowing getArgument(2) to pass the bounds check and result in an array index error.
    
    With this new method, fetching of replacement arguments is more straightforward and bounds checking functions as it should.
    jmikola committed Oct 27, 2011
Commits on Oct 25, 2011
  1. [DependencyInjection] fixed int casting for XML files (based on what …

    …is done in the YAML component)
    fabpot committed Oct 25, 2011
Commits on Oct 24, 2011
Commits on Sep 29, 2011
  1. merged branch igorw/composer (PR #2275)

    Commits
    -------
    
    731b28b [composer] add missing deps for FrameworkBundle
    9c8f100 [composer] change ext/intl to the new ext-intl syntax
    d535afe [composer] fix monolog-bridge composer.json, add more inter-component deps
    9ade639 [composer] add composer.json
    
    Discussion
    ----------
    
    Composer
    
    This PR adds a composer.json file for [composer](https://github.com/composer/composer) ([more info](packagist.org/about-composer)).
    
    For discussion you can also go into #composer-dev on freenode and argue with naderman, seldaek and everzet.
    
    ---------------------------------------------------------------------------
    
    by naderman at 2011/09/26 15:51:51 -0700
    
    You haven't entered any keywords, they might come in handy when searching for packages on packagist.
    
    But really this is just a +1 ;-)
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/09/26 16:12:21 -0700
    
    See my comments on your previous (non-rebased) commit: igorw/symfony@f1c0242
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011/09/27 00:04:36 -0700
    
    Following dependencies do not have a composer.json yet: Twig, Doctrine (orm, dbal, common), swiftmailer.
    
    Also missing from the standard edition: assetic, twig-extensions, jsm-metadata, SensioFrameworkExtraBundle, JMSSecurityExtraBundle, SensioDistributionBundle, SensioGeneratorBundle, AsseticBundle.
    
    The point is, those can be added later on. Having the components composerized is already a leap forward. Also, doctrine depends on some symfony components, we've got to start somewhere.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/27 00:36:41 -0700
    
    Also, just for information, the plan is to have `symfony/framework-bundle` be the "framework", with all dependencies to doctrine etc, though we should really only have strict requirements in there, and then in symfony-standard we ship a composer.json that requires the framework-bundle, doctrine-orm and things like that that are not essential to core. Otherwise people don't have a choice about what they use anymore.
    
    Just a comment btw, the json is invalid, all / should be escaped. However json_decode is nice enough to parse those without complaining, browsers do too, even Crockford's json2.js does, so I'm not sure if we should privilege readability over strictness, since it seems nobody really cares about this escaping.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2011/09/27 00:41:39 -0700
    
    So, I've implemented all of @stof's suggestions, except (for reasons stated above):
    
    * doctrine to DoctrineBundle
    * swiftmailer to SwiftmailerBundle
    * twig to TwigBundle
    * doctrine-common to Validator
    * FrameworkBundle (what exactly does it depend on?)
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/09/27 00:52:31 -0700
    
    @igorw at least HttpKernel, Routing, Templating, EventDispatcher, Doctrine Common (annotations cannot be disabled), Translator, Form (optional), Validator (optional), Console (optional). See the service definitions to see the others
    
    @Seldaek FrameworkBundle does not depend on Doctrine, except for Common
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/09/27 03:15:34 -0700
    
    What does the symfony/ or ext/ prefix control in composer?
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/27 03:33:52 -0700
    
    symfony/ is just the (mandatory) vendor namespace. Also ext/ has been renamed to ext- now, so it's not in any vendor, and should avoid potential issues.
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/09/27 05:07:03 -0700
    
    @Seldaek Mandatory? So every package name is "vendor/package"? I like that because previously i thought package names are not namespaced, and thus clashes could occur between different communities easily.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/27 05:16:20 -0700
    
    @beberlei: Mandatory. As of yesterday http://packagist.org/ will tell you you have an invalid package name if there's no slash in it. See composer/packagist@1306d1c#diff-3
    fabpot committed Sep 29, 2011
Commits on Sep 28, 2011
Commits on Sep 27, 2011
Commits on Sep 26, 2011
  1. [composer] add composer.json

    igorw committed Sep 24, 2011
Commits on Sep 25, 2011
  1. Revert "merged branch stealth35/ini_bool (PR #2235)"

    This reverts commit 363057b181ba9ebb7a72306c76fe3ff67bf3c649, reversing
    changes made to 545cd4cd636b9ce084ce0b5768708b29d4a6b429.
    fabpot committed Sep 25, 2011
  2. Revert "[DependencyInjection] fixed array support for the ini loader"

    This reverts commit e0ace8eaee2756c60d79681d907b01875d06e7dc.
    fabpot committed Sep 25, 2011
Commits on Sep 23, 2011
Commits on Sep 21, 2011
Commits on Sep 9, 2011
Commits on Sep 5, 2011
Commits on Jul 20, 2011
Commits on Jul 16, 2011
  1. removed unused code

    schmittjoh committed Jul 16, 2011
  2. tabs -> spaces

    schmittjoh committed Jul 16, 2011
  3. improves the exception message, and removes unnecessary constraint to…

    … only allow strings inside strings
    schmittjoh committed Jul 16, 2011