Skip to content
Permalink
Branch: master
Commits on Nov 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Nov 8, 2019
    * 4.4:
      [DI] fix loading env while env loaders are loaded
  2. Merge branch '4.4'

    nicolas-grekas committed Nov 8, 2019
    * 4.4:
      [DI] fix locators with numeric keys
      Add support for NO_COLOR env var
      [DI][FrameworkBundle] add EnvVarLoaderInterface - remove SecretEnvVarProcessor
      Fix error when we use VO for the marking property
      [DI] Remove LazyString from 4.4, before adding back to the String component
  3. minor #34290 [DI] Remove LazyString from 4.4, before adding back to t…

    nicolas-grekas committed Nov 8, 2019
    …he String component (nicolas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] Remove LazyString from 4.4, before adding back to the String component
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    In #34190 I'm proposing to move LazyString to the Service contracts, but String might be a better fit actually. Let's remove the class from 4.4 where it's not really needed, and add it back on 5.0 in the String component.
    
    Commits
    -------
    
    b1a3ee76ac [DI] Remove LazyString from 4.4, before adding back to the String component
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Nov 8, 2019
    * 4.3:
      [DI] fix locators with numeric keys
      Fix error when we use VO for the marking property
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Nov 8, 2019
    * 3.4:
      [DI] fix locators with numeric keys
  6. [DI] fix merge

    nicolas-grekas committed Nov 8, 2019
  7. Merge branch '4.4'

    nicolas-grekas committed Nov 8, 2019
    * 4.4:
      [DI] Dont cache classes with missing parents
      [HttpClient] Fix a crash when calling CurlHttpClient::__destruct()
      Unallow symfony/http-kernel ^5.0
      [FrameworkBundle] fix SodiumVault after stof review
      [HttpClient] allow arbitrary JSON values in requests
      [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
      [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
      [FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change
  8. feature #31310 [DependencyInjection] Added option `ignore_errors: not…

    nicolas-grekas committed Nov 8, 2019
    …_found` for imported config files (pulzarraider)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Added option `ignore_errors: not_found` for imported config files
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#11647
    
    If someone want to add optional config file. The only available choice was to add `ignore_errors: true` option
    
    e.g.
    ```
    imports:
        - { resource: parameters.yml, ignore_errors: true }
    ```
    
    But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files.
    
    This PR introduce new possible value `not_found` for `ignore_errors` option. It can be used for optional config files like the `ignore_errors: true`, but it will ignore only the file non-existence, not the possible syntax errors inside.
    
    Usage:
    ```
    imports:
        - { resource: parameters.yml, ignore_errors: not_found}
    ```
    
    Commits
    -------
    
    e0ee01c10d [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
  9. Merge branch '4.3' into 4.4

    nicolas-grekas committed Nov 8, 2019
    * 4.3:
      [DI] Dont cache classes with missing parents
      [HttpClient] Fix a crash when calling CurlHttpClient::__destruct()
      [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
      [FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change
  10. Merge branch '3.4' into 4.3

    nicolas-grekas committed Nov 8, 2019
    * 3.4:
      [DI] Dont cache classes with missing parents
      [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
Commits on Nov 6, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Nov 6, 2019
    * 4.4:
      Skip validation of services that make the CI fail
Commits on Nov 5, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Nov 5, 2019
    * 4.4: (39 commits)
      [Console] Fix #33915, Detect dimensions using mode CON if vt100 is supported
      [PhpUnitBridge] Also search for composer.phar in git root folder
      [HttpKernel][DataCollectorInterface] Ease compatibility
      Add tests to ensure defaultLocale is properly passed to the URL generator
      [DependencyInjection] Fix broken references in tests
      [VarDumper] display the method we're in when dumping stack traces
      [HttpClient] Retry safe requests when then fail before the body arrives
      [Console] Rename some methods related to redraw frequency
      Avoid using of kernel after shutdown
      Simplify PHP CS Fixer configuration
      [PropertyInfo] Fixed type extraction for nullable collections of non-nullable elements
      [FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month
      Fix CS
      [Serializer] Fix property name usage for denormalization
      Name test accordingly to the tested class
      Fix MockFileSessionStorageTest::sessionDir being used after it's unset
      [Security] Fix SwitchUserToken wrongly deauthenticated
      Supporting Bootstrap 4 custom switches
      Add new Form WeekType
      bumped Symfony version to 4.3.7
      ...
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Nov 5, 2019
    * 4.3: (26 commits)
      [Console] Fix #33915, Detect dimensions using mode CON if vt100 is supported
      [HttpKernel][DataCollectorInterface] Ease compatibility
      Add tests to ensure defaultLocale is properly passed to the URL generator
      [DependencyInjection] Fix broken references in tests
      [HttpClient] Retry safe requests when then fail before the body arrives
      Avoid using of kernel after shutdown
      Simplify PHP CS Fixer configuration
      [PropertyInfo] Fixed type extraction for nullable collections of non-nullable elements
      [FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month
      [Serializer] Fix property name usage for denormalization
      Name test accordingly to the tested class
      Fix MockFileSessionStorageTest::sessionDir being used after it's unset
      bumped Symfony version to 4.3.7
      updated VERSION for 4.3.6
      updated CHANGELOG for 4.3.6
      bumped Symfony version to 3.4.34
      updated VERSION for 3.4.33
      update CONTRIBUTORS for 3.4.33
      updated CHANGELOG for 3.4.33
      [HttpClient] Fix perf issue when doing thousands of requests with curl
      ...
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Nov 5, 2019
    * 3.4:
      [DependencyInjection] Fix broken references in tests
      Avoid using of kernel after shutdown
      Simplify PHP CS Fixer configuration
      [FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month
      Fix MockFileSessionStorageTest::sessionDir being used after it's unset
      bumped Symfony version to 3.4.34
      updated VERSION for 3.4.33
      update CONTRIBUTORS for 3.4.33
      updated CHANGELOG for 3.4.33
      [Stopwatch] Fixed a bug in stopwatch event getStartTime
      [Stopwatch] Fixed bug in getDuration when counting multiple ongoing periods
      Adding some validations tags on validators.et.xlf
      add missing translation for 94 (it)
Commits on Nov 4, 2019
  1. feature #31587 [Routing][Config] Allow patterns of resources to be ex…

    nicolas-grekas committed Nov 4, 2019
    …cluded from config loading (tristanbes)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Routing][Config] Allow patterns of resources to be excluded from config loading
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #31516
    | License       | MIT
    | Doc PR        | not yet
    
    The PR will fix the following RFC: #31516
    
    Like resource loading for services, this PR offers a way to exclude patterns of resources like:
    
    ```yml
    // config/routes/annotations.yaml
    controllers:
        resource: ../../src/Controller/*
        type: annotation
        exclude: '../src/Controller/{DebugEmailController}.php'
    ```
    
    All the annotation routes inside `Controller/` will be loaded in this example except all the one present inside the `Controller/DebugEmailController.php`
    
    Commits
    -------
    
    332ff8811c [Routing][Config] Allow patterns of resources to be excluded from config loading
  2. feature #32256 [DI] Add compiler pass and command to check that servi…

    nicolas-grekas committed Nov 4, 2019
    …ces wiring matches type declarations (alcalyn, GuilhemN, nicolas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] Add compiler pass and command to check that services wiring matches type declarations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #27744
    | License       | MIT
    | Doc PR        |
    
    PR replacing symfony/symfony#27825.
    
    It adds a `lint:container` command asserting the type hints used in your code are correct.
    
    Commits
    -------
    
    8230a1543e Make it really work on real apps
    4b3e9d4c96 Fix comments, improve the feature
    a6292b917b [DI] Add compiler pass to check arguments type hint
You can’t perform that action at this time.