Skip to content
Permalink
Branch: master
Commits on Aug 14, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Import return annotations from vendors
      [ErrorHandler] Handle return types in DebugClassLoader
      cs fix
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      Remove superfluous phpdoc tags
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      Remove superfluous phpdoc tags
Commits on Aug 13, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
      [DI] deprecate support for non-object services
      [Translation] XliffLintCommand: allow .xliff file extension
      [Serializer] Encode empty objects as objects, not arrays
  2. feature #32845 [HttpKernel][FrameworkBundle] Add alternative conventi…

    nicolas-grekas committed Aug 13, 2019
    …on for bundle directories (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32845).
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#32453
    | License       | MIT
    | Doc PR        | TODO
    
    We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures.
    
    The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure.
    
    We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention.
    
    I've added some functional tests in which I've changed everything to this structure:
    ```
    -- ModernBundle
       |-- config/
       |-- public/
       |-- src/
           |-- ModernBundle.php
       |-- templates/
       |-- translations/
    ```
    WDYT?
    
    Commits
    -------
    
    6996e1cbe2 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  3. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add type declarations to private DefaultChoiceListFactory methods
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  6. Fix return statements

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 10, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 10, 2019
    * 4.3:
      Bump minimal requirements
Commits on Aug 9, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 9, 2019
    * 4.4:
      Fix typo
      Fix unitialized variable in DeprecationErrorHandler
      fix Danish translations
      Support ISO 3166-1 Alpha-3 country codes
      Added the missing translations for the Slovak 'sk' locale.
      Add deprecation for method signature
      Add compatibility trait for PHPUnit constraint classes
      [HttpFoundation] Clear invalid session cookie
      Fix tst patern to handle callstack with/without return typehint
      Fix negative DateInterval
      [Validator] Allow objects implementing __toString() to be used as violation messages
      [FrameworkBundle][Routing] Private service route loaders
      [DoctrineBridge] Allow invokable event listeners
Commits on Aug 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Improve some URLs
      cleanup remaining param  and internal Intl FulLTransformer
      [HttpClient] fix data loss when streaming as a PHP resource
      Fix test compatibility with 4.x components
      [Cache] cs fix
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  4. minor #32800 Improve some URLs (Arman-Hosseini)

    nicolas-grekas committed Aug 8, 2019
    This PR was squashed before being merged into the 3.4 branch (closes #32800).
    
    Discussion
    ----------
    
    Improve some URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    fab17a4487 Improve some URLs
  5. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Fix compatibility with PHPUnit 8
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  6. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  7. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Remove unneeded phpdocs
  8. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Debug] Improve UPGRADE files
      remove wrongly added legacy group from test
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      add missing conflict rule
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      remove some more useless phpdocs
      Resilience against file_get_contents() race conditions.
      Turned return type annotations of private methods into php return types.
Commits on Aug 6, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 6, 2019
    * 4.4:
      bump phpunit-bridge cache-id
      removed unneeded phpdocs
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
Commits on Aug 5, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 5, 2019
    * 4.4:
      [Form] Fix inconsistencies
      Use Phpunit FQDN in tests comments
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 5, 2019
    * 4.3:
      [Form] Fix inconsistencies
      Use Phpunit FQDN in tests comments
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 5, 2019
    * 3.4:
      [Form] Fix inconsistencies
      Use Phpunit FQDN in tests comments
  4. Merge branch '4.4'

    nicolas-grekas committed Aug 5, 2019
    * 4.4:
      Minor fixes
      [Mailer] fixed dispatcher not available in Mailer
      [HttpClient] Minor fixes
      Use namespaced Phpunit classes
      Add polyfill for PhpUnit namespace
      [Messenger] Fixed ConsumeMessagesCommand configuration
      [Form] remove leftover int child phpdoc
      Support DateTimeInterface in IntlDateFormatter::format
      [PhpUnitBridge] fixed PHPUnit 8.3 compatibility: method handleError was renamed to __invoke
      [Yaml] Removed unused $nullAsTilde property
      [Security] add support for opportunistic password migrations
      [Lock] Legacy test should implement legacy interface
      fixed phpdocs
      Use PHPunit assertion
      [Intl] Order alpha2 to alpha3 mapping + phpdoc fixes
Commits on Aug 3, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 3, 2019
    * 4.4:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 3, 2019
    * 4.3:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 3, 2019
    * 3.4:
      Remove use of ForwardCompatTrait
      Remove deprecated methods assertArraySubset
Commits on Aug 2, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 2, 2019
    * 4.4:
      Fix tests
      Fix deprecated phpunit annotation
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 2, 2019
    * 4.3:
      Fix tests
      Fix deprecated phpunit annotation
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 2, 2019
    * 3.4:
      Fix tests
      Fix deprecated phpunit annotation
Commits on Aug 1, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 1, 2019
    * 4.4:
      cs fix
      Replace calls to setExpectedException by Pollyfill
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 1, 2019
    * 4.3:
      cs fix
      Replace calls to setExpectedException by Pollyfill
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 1, 2019
    * 3.4:
      cs fix
      Replace calls to setExpectedException by Pollyfill
Older
You can’t perform that action at this time.