Skip to content

Commit

Permalink
bug #517 remove deprecated CURLPIPE_HTTP1 support flag (hal869)
Browse files Browse the repository at this point in the history
This PR was merged into the 1.2-dev branch.

Discussion
----------

remove deprecated CURLPIPE_HTTP1 support flag

cref #515

@ https://curl.haxx.se/libcurl/c/CURLMOPT_PIPELINING.html
```
	HTTP/1 Pipelining support was disabled in 7.62.0.
```

here
```
	lsb_release -rd
		Description:    openSUSE Leap 15.1
		Release:        15.1

	curl -V
		curl 7.65.1 (x86_64-suse-linux-gnu) libcurl/7.65.1 OpenSSL/1.1.0i-fips zlib/1.2.11 libidn2/2.2.0
		...
```

manually
```
	src/CurlDownloader.php

-	        curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_HTTP1 | CURLPIPE_MULTIPLEX*/ 3);
+	        curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_MULTIPLEX*/ 2);
```

now, check
```
	composer --version
		Composer version 1.8.6 2019-06-11 15:03:05
```

Commits
-------

0fd8e9a remove deprecated CURLPIPE_HTTP1 support flag
  • Loading branch information
fabpot committed Jun 15, 2019
2 parents 5ed4909 + 0fd8e9a commit 8618b24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/CurlDownloader.php
Expand Up @@ -46,7 +46,7 @@ class CurlDownloader
public function __construct()
{
$this->multiHandle = $mh = curl_multi_init();
curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_HTTP1 | CURLPIPE_MULTIPLEX*/ 3);
curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_MULTIPLEX*/ 2);
if (\defined('CURLMOPT_MAX_HOST_CONNECTIONS')) {
curl_multi_setopt($mh, CURLMOPT_MAX_HOST_CONNECTIONS, 8);
}
Expand Down

0 comments on commit 8618b24

Please sign in to comment.