Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy tags significantly reduces memory and CPU usage #378

Merged
merged 1 commit into from Jul 11, 2018
Merged

Removing legacy tags significantly reduces memory and CPU usage #378

merged 1 commit into from Jul 11, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 10, 2018

Before:

Memory usage: peak: 606.6MB, time: 5.79s

After:

Memory usage: peak: 158.56MB, time: 1.86s

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t we apply the same trick for all packages having a recipe (we have the minimum version required for the recipe)?

@nicolas-grekas
Copy link
Member Author

Only symfony/* components have a significant list of tags. We can, but case by case IMHO, when useful.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and amazing results! Thanks.

src/ComposerRepository.php Outdated Show resolved Hide resolved
src/Cache.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member Author

Comments addressed thanks.

src/Cache.php Show resolved Hide resolved
src/ComposerRepository.php Outdated Show resolved Hide resolved
src/Cache.php Show resolved Hide resolved
src/Cache.php Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Jul 11, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 990b2d1 into symfony:master Jul 11, 2018
fabpot added a commit that referenced this pull request Jul 11, 2018
…U usage (nicolas-grekas)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Removing legacy tags significantly reduces memory and CPU usage

Before:
> Memory usage: 272.59MB (peak: 606.6MB), time: 5.79s

After:
> Memory usage: 145.56MB (peak: 158.56MB), time: 1.86s

Commits
-------

990b2d1 Removing legacy tags significantly reduces memory and CPU usage
@nicolas-grekas nicolas-grekas deleted the clear-tags branch July 12, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet