Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Lock copied files to prevent removing files needed by other recipes #451
This PR modifies the
How to reproduce the issue
This will remove both files installed through the recipe
How to verify the fix
Create a new project based on
Alternatively removing a recipe and then requiring it again will update the lock as well, but it needs to be done for each recipe, as otherwise the list of locked files would be incomplete.
Now when we remove the console again, opening the page in the browser should still work and the file
None, as far as I can tell. For newly required recipes the files will be tracked. The new key for files in
Unfortunately if any of the previously installed recipes has conflicting files, this will not be recognized unless the recipe is removed and then installed again.
3 times, most recently
Dec 23, 2018
referenced this pull request
Jan 7, 2019
Hi @nicolas-grekas. Sorry for not updating. I'm currently busy settling into a new client project.
Writing tests for this was a bit tricky due to the Lock-class requiring a file to write to. I think the rebase and the flexible root-dir made this a bit easier, but I had no time to confirm this. I don't feel comfortable mocking the calls to Lock as I want to ensure the file list is handled properly.
I won't have time until Wednesday next week though. I set the end of the first week of February as my personal deadline for this.
dbrumann left a comment •
The issue is fixed. I messed up when replacing my