Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore existing env vars when running dump-env #478

Merged
merged 1 commit into from Apr 3, 2019
Merged

Ignore existing env vars when running dump-env #478

merged 1 commit into from Apr 3, 2019

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Mar 4, 2019

@bendavies
Copy link

didn't get a notification for this on my linked issue. thanks - i'll take a look.

@nicolas-grekas nicolas-grekas merged commit c818a51 into symfony:master Apr 3, 2019
nicolas-grekas added a commit that referenced this pull request Apr 3, 2019
This PR was merged into the 1.2-dev branch.

Discussion
----------

Ignore existing env vars when running dump-env

Fix #475
Fix #476
Fix symfony/symfony#30418

Commits
-------

c818a51 Ignore existing env vars when running dump-env
@nicolas-grekas nicolas-grekas deleted the fix-dump-env branch April 3, 2019 17:17
@DavG
Copy link

DavG commented May 31, 2019

This introduces bug #500

foreach ($_SERVER as $k => $v) {
    if (\is_string($v) && false !== getenv($k)) {
        unset($_SERVER[$k]);
        putenv($k);
    }
}

@bendavies
Copy link

bendavies commented Jun 13, 2019

@nicolas-grekas I thought I checked but it doesn't not seem that this fixed the issue described at #476.

https://github.com/bendavies/symfony-flex-env-issue is still a problem.

@bendavies
Copy link

bendavies commented Jun 13, 2019

looking at the fix in this PR, I cant see the issue was resolved actually.
the problem was not with dump-env, but with the loading of var in bootstrap.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants