Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy handling #489

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@Lctrs
Copy link
Contributor

Lctrs commented Apr 15, 2019

Fix #488.

I'm working behind a corporate proxy and since few days, I get errors like in the screenshot below whenever I use flex.

issue

Further debugging revealed that composer replace the http scheme by tcp in the proxy url, which curl doesn't support.

As curl reads proxy conf from env by default, let's just not override it.

@stof

This comment has been minimized.

Copy link
Member

stof commented Apr 15, 2019

What looks weird is that Composer 2.x (still in dev) is still doing the replacement even when using Curl. So either that change is wrong, or Composer 2.x will also suffer from it.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Apr 15, 2019

@stof Composer 2 borrowed code from flex, so it might benefit from the exposure we have here and thus should be patched accordingly (#486 also)

@stof

stof approved these changes Apr 15, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Apr 16, 2019

Thank you @Lctrs.

@fabpot fabpot merged commit 234d613 into symfony:master Apr 16, 2019

1 of 2 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Apr 16, 2019

bug #489 Fix proxy handling (Lctrs)
This PR was merged into the 1.2-dev branch.

Discussion
----------

Fix proxy handling

Fix #488.

I'm working behind a corporate proxy and since few days, I get errors like in the screenshot below whenever I use flex.

![issue](https://user-images.githubusercontent.com/5477973/56134493-f6ac6a00-5f8e-11e9-8e5c-393f284688e7.png)

Further debugging revealed that [composer replace the http scheme by tcp in the proxy url](https://github.com/composer/composer/blob/1.8.5/src/Composer/Util/StreamContextFactory.php#L78), which curl doesn't support.

As curl reads proxy conf from env by default, let's just not override it.

Commits
-------

234d613 Fix proxy handling

@Lctrs Lctrs deleted the Lctrs:fix-proxy branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.