Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve regex for container configurator #493

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
5 participants
@maxhelias
Copy link
Contributor

commented May 1, 2019

Escapes the regex of the container configurator because for the case of the variables "env()" this one are broken.
Example with the mercure or doctrine/mongodb-odm-bundle recipe if you remove the dependence.

@nicolas-grekas
Copy link
Member

left a comment

Can you please add a test case?

@maxhelias maxhelias force-pushed the maxhelias:config-container branch from e762638 to a3a22b3 May 2, 2019

@maxhelias

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

@nicolas-grekas It's done 😃

@stof

stof approved these changes May 2, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Thank you @maxhelias.

@fabpot fabpot merged commit a3a22b3 into symfony:master May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 6, 2019

bug #493 Improve regex for container configurator (maxhelias)
This PR was merged into the 1.2-dev branch.

Discussion
----------

Improve regex for container configurator

Escapes the regex of the container configurator because for the case of the variables "env()" this one are broken.
Example with the mercure or doctrine/mongodb-odm-bundle recipe if you remove the dependence.

Commits
-------

a3a22b3 Improve regex for container configurator

@maxhelias maxhelias deleted the maxhelias:config-container branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.