Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display stdout too when dump-env fails #494

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented May 7, 2019

Sometimes the useful info is on stdout.

@javiereguiluz
Copy link
Member

left a comment

Nice! I would have needed this recently :)

@fabpot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 397a0aa into symfony:master May 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 7, 2019

minor #494 Display stdout too when dump-env fails (nicolas-grekas)
This PR was merged into the 1.2-dev branch.

Discussion
----------

Display stdout too when dump-env fails

Sometimes the useful info is on stdout.

Commits
-------

397a0aa Display stdout too when dump-env fails
@@ -127,7 +127,7 @@ private function loadEnv(string $path, string $env): array
$process->run();
if (!$process->isSuccessful()) {
throw new \RuntimeException($process->getErrorOutput());
throw new \RuntimeException($process->getErrorOutput().$process->getOutput());

This comment has been minimized.

Copy link
@lyrixx

lyrixx May 9, 2019

Member
  1. there is a ProcessFailedException that does that, but in a better way
  2. but there is the mustRun() method that is even simpler

#496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.