Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further decoupling from symfony/symfony replace section #505

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jun 3, 2019

Continues #499

}
if (!$vers || $vers === $versions['splits'][$name]) {
unset($versions['splits'][$name]);

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 3, 2019

Author Member

we keep only the packages that are affected by the version requirements and have a non-empty intersection with existing versions of it

@@ -29,7 +29,7 @@ public function testRemoveLegacyTags(array $expected, array $packages, string $s
public function provideRemoveLegacyTags()
{
yield 'no-symfony/symfony' => [[123], [123], '~1', ['master' => '3.5', 'splits' => []]];

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 3, 2019

Author Member

we don't read the "master" entry anymore

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 48e90bf into symfony:master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #505 Further decoupling from symfony/symfony replace section (nic…
…olas-grekas)

This PR was merged into the 1.2-dev branch.

Discussion
----------

Further decoupling from symfony/symfony replace section

Continues #499

Commits
-------

48e90bf Further decoupling from symfony/symfony replace section

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-req branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.