Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix referencing real $ENV vars when running dump-env #507

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 5, 2019

Fixes #500

@stof

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

shouldn't a reference to another env variable be resolved at runtime rather than at dumping time, so that you don't need to re-dump when changing the other env variable ?
This improved dump command is still not equivalent to running Dotenv (changes to the .env file of course require re-dumping, but I'm talking about changes to real env variables).

Btw, what happens if we add a real env variable, for which the .env file contains a default value ? Would re-dumping be necessary ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

Yes: dump-env is about freezing the defaults, nothing more. Then real env vars can take over at runtime as usual.

@DavG

This comment has been minimized.

Copy link

commented Jun 5, 2019

Sounds perfect to me @nicolas-grekas , thanks for reconsidering the issue.
I'm gonna do some manual tests too.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-dump-env branch from e932005 to 443c86c Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 443c86c into symfony:master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #507 Fix referencing real $ENV vars when running dump-env (nicola…
…s-grekas)

This PR was merged into the 1.2-dev branch.

Discussion
----------

Fix referencing real $ENV vars when running dump-env

Fixes #500

Commits
-------

443c86c Fix referencing real $ENV vars when running dump-env
@DavG

This comment has been minimized.

Copy link

commented Jun 5, 2019

It works perfectly. Thanks again !

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-dump-env branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.