Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dealing with locally patched packages #509

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 5, 2019

Fixes #508
Happens on the CI when local packages are built for testing PRs.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix branch from 4f9452a to 42bdc9f Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 42bdc9f into symfony:master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #509 Fix dealing with locally patched packages (nicolas-grekas)
This PR was merged into the 1.2-dev branch.

Discussion
----------

Fix dealing with locally patched packages

Fixes #508
Happens on the CI when local packages are built for testing PRs.

Commits
-------

42bdc9f Fix dealing with locally patched packages
@@ -78,6 +78,8 @@ public function removeLegacyTags(array $data): array
foreach ($versions as $version => $composerJson) {
if ('dev-master' === $version) {
$normalizedVersion = $this->versionParser->normalize($devMasterAlias);
} elseif (!isset($composerJson['version_normalized'])) {

This comment has been minimized.

Copy link
@stof

stof Jun 5, 2019

Member

why not attempting to read $composerJson['version'] and normalizing it (or just $version) ? We have access to the VersionParser to normalize here.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 5, 2019

Author Member

because we don't really care: when this happens, we always want to keep the "version" anyway

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.