Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output emojis when the output isn't being decorated #532

Merged

Conversation

Projects
None yet
3 participants
@kevinreniers
Copy link
Contributor

commented Jul 8, 2019

This should fix #528.

Before:

root@bafcbe268c5d:/projects/test# composer install
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 27 installs, 0 updates, 0 removals
  - Installing symfony/flex (dev-fix/disable-emojis-by-is-decorated 7e14191): Downloading (100%)

Prefetching 26 packages 馃幎 馃挩
  - Downloading (100%)

  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/cache-contracts (v1.1.5): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/service-contracts (v1.1.5): Loading from cache
  - Installing symfony/polyfill-php73 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
  - Installing symfony/console (v4.3.2): Loading from cache
  - Installing symfony/dotenv (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher-contracts (v1.1.5): Loading from cache
  - Installing symfony/routing (v4.3.2): Loading from cache
  - Installing symfony/polyfill-php72 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-intl-idn (v1.11.0): Loading from cache
  - Installing symfony/mime (v4.3.2): Loading from cache
  - Installing symfony/http-foundation (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher (v4.3.2): Loading from cache
  - Installing psr/log (1.1.0): Loading from cache
  - Installing symfony/debug (v4.3.2): Loading from cache
  - Installing symfony/http-kernel (v4.3.2): Loading from cache
  - Installing symfony/finder (v4.3.2): Loading from cache
  - Installing symfony/filesystem (v4.3.2): Loading from cache
  - Installing symfony/dependency-injection (v4.3.2): Loading from cache
  - Installing symfony/config (v4.3.2): Loading from cache
  - Installing symfony/var-exporter (v4.3.2): Loading from cache
  - Installing symfony/cache (v4.3.2): Loading from cache
  - Installing symfony/framework-bundle (v4.3.2): Loading from cache
  - Installing symfony/yaml (v4.3.2): Loading from cache
Generating autoload files
Executing script cache:clear [OK]
Executing script assets:install public [OK]

After:

root@bafcbe268c5d:/projects/test# composer install --no-ansi
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 27 installs, 0 updates, 0 removals
  - Installing symfony/flex (dev-fix/disable-emojis-by-is-decorated 7e14191): Downloading (100%)

Prefetching 26 packages
  - Downloading (100%)

  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/cache-contracts (v1.1.5): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/service-contracts (v1.1.5): Loading from cache
  - Installing symfony/polyfill-php73 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
  - Installing symfony/console (v4.3.2): Loading from cache
  - Installing symfony/dotenv (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher-contracts (v1.1.5): Loading from cache
  - Installing symfony/routing (v4.3.2): Loading from cache
  - Installing symfony/polyfill-php72 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-intl-idn (v1.11.0): Loading from cache
  - Installing symfony/mime (v4.3.2): Loading from cache
  - Installing symfony/http-foundation (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher (v4.3.2): Loading from cache
  - Installing psr/log (1.1.0): Loading from cache
  - Installing symfony/debug (v4.3.2): Loading from cache
  - Installing symfony/http-kernel (v4.3.2): Loading from cache
  - Installing symfony/finder (v4.3.2): Loading from cache
  - Installing symfony/filesystem (v4.3.2): Loading from cache
  - Installing symfony/dependency-injection (v4.3.2): Loading from cache
  - Installing symfony/config (v4.3.2): Loading from cache
  - Installing symfony/var-exporter (v4.3.2): Loading from cache
  - Installing symfony/cache (v4.3.2): Loading from cache
  - Installing symfony/framework-bundle (v4.3.2): Loading from cache
  - Installing symfony/yaml (v4.3.2): Loading from cache
Generating autoload files
Executing script cache:clear [OK]
Executing script assets:install public [OK]
@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @kevinreniers.

@fabpot fabpot merged commit 7e14191 into symfony:master Jul 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

bug #532 Don't output emojis when the output isn't being decorated (k鈥
鈥vinreniers)

This PR was merged into the 1.4-dev branch.

Discussion
----------

Don't output emojis when the output isn't being decorated

This should fix #528.

Before:

```
root@bafcbe268c5d:/projects/test# composer install
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 27 installs, 0 updates, 0 removals
  - Installing symfony/flex (dev-fix/disable-emojis-by-is-decorated 7e14191): Downloading (100%)

Prefetching 26 packages 馃幎 馃挩
  - Downloading (100%)

  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/cache-contracts (v1.1.5): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/service-contracts (v1.1.5): Loading from cache
  - Installing symfony/polyfill-php73 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
  - Installing symfony/console (v4.3.2): Loading from cache
  - Installing symfony/dotenv (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher-contracts (v1.1.5): Loading from cache
  - Installing symfony/routing (v4.3.2): Loading from cache
  - Installing symfony/polyfill-php72 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-intl-idn (v1.11.0): Loading from cache
  - Installing symfony/mime (v4.3.2): Loading from cache
  - Installing symfony/http-foundation (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher (v4.3.2): Loading from cache
  - Installing psr/log (1.1.0): Loading from cache
  - Installing symfony/debug (v4.3.2): Loading from cache
  - Installing symfony/http-kernel (v4.3.2): Loading from cache
  - Installing symfony/finder (v4.3.2): Loading from cache
  - Installing symfony/filesystem (v4.3.2): Loading from cache
  - Installing symfony/dependency-injection (v4.3.2): Loading from cache
  - Installing symfony/config (v4.3.2): Loading from cache
  - Installing symfony/var-exporter (v4.3.2): Loading from cache
  - Installing symfony/cache (v4.3.2): Loading from cache
  - Installing symfony/framework-bundle (v4.3.2): Loading from cache
  - Installing symfony/yaml (v4.3.2): Loading from cache
Generating autoload files
Executing script cache:clear [OK]
Executing script assets:install public [OK]
```

After:
```
root@bafcbe268c5d:/projects/test# composer install --no-ansi
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 27 installs, 0 updates, 0 removals
  - Installing symfony/flex (dev-fix/disable-emojis-by-is-decorated 7e14191): Downloading (100%)

Prefetching 26 packages
  - Downloading (100%)

  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/cache-contracts (v1.1.5): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/service-contracts (v1.1.5): Loading from cache
  - Installing symfony/polyfill-php73 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.11.0): Loading from cache
  - Installing symfony/console (v4.3.2): Loading from cache
  - Installing symfony/dotenv (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher-contracts (v1.1.5): Loading from cache
  - Installing symfony/routing (v4.3.2): Loading from cache
  - Installing symfony/polyfill-php72 (v1.11.0): Loading from cache
  - Installing symfony/polyfill-intl-idn (v1.11.0): Loading from cache
  - Installing symfony/mime (v4.3.2): Loading from cache
  - Installing symfony/http-foundation (v4.3.2): Loading from cache
  - Installing symfony/event-dispatcher (v4.3.2): Loading from cache
  - Installing psr/log (1.1.0): Loading from cache
  - Installing symfony/debug (v4.3.2): Loading from cache
  - Installing symfony/http-kernel (v4.3.2): Loading from cache
  - Installing symfony/finder (v4.3.2): Loading from cache
  - Installing symfony/filesystem (v4.3.2): Loading from cache
  - Installing symfony/dependency-injection (v4.3.2): Loading from cache
  - Installing symfony/config (v4.3.2): Loading from cache
  - Installing symfony/var-exporter (v4.3.2): Loading from cache
  - Installing symfony/cache (v4.3.2): Loading from cache
  - Installing symfony/framework-bundle (v4.3.2): Loading from cache
  - Installing symfony/yaml (v4.3.2): Loading from cache
Generating autoload files
Executing script cache:clear [OK]
Executing script assets:install public [OK]
```

Commits
-------

7e14191 Don't output emojis when the output isn't being decorated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.