Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Command to list all available recipes #562

Open
wants to merge 2 commits into
base: master
from

Conversation

@maxhelias
Copy link
Contributor

maxhelias commented Sep 18, 2019

First step of #518, the command symfony:recipes:show and alias symfony:recipes

Result :
Capture d’écran 2019-09-18 à 15 46 09

I need feedback on the disposition and maybe i can add the version of the recipe installed like

  • doctrine/annontations 1.0

Tell me what you think :)

Note: the last section is currently commented out, and will be added later

@maxhelias maxhelias force-pushed the maxhelias:feature/recipe-list branch from b423b27 to 7abec16 Sep 18, 2019
src/Command/RecipesCommand.php Outdated Show resolved Hide resolved
src/Command/RecipesCommand.php Outdated Show resolved Hide resolved
src/Command/RecipesCommand.php Show resolved Hide resolved
src/Flex.php Outdated Show resolved Hide resolved
src/InformationOperation.php Outdated Show resolved Hide resolved
src/InformationOperation.php Outdated Show resolved Hide resolved
@maxhelias maxhelias force-pushed the maxhelias:feature/recipe-list branch 2 times, most recently from 032d7d6 to 5ed8416 Sep 18, 2019
@maxhelias maxhelias force-pushed the maxhelias:feature/recipe-list branch from 5ed8416 to f26a79a Oct 10, 2019
@maxhelias maxhelias requested a review from weaverryan Oct 10, 2019
@maxhelias

This comment has been minimized.

Copy link
Contributor Author

maxhelias commented Nov 6, 2019

friendly ping @weaverryan 😄

//$write[] = '';
//$write[] = '<fg=blue>Run</>:';
//$write[] = ' * composer symfony:recipes vendor/package to see details about a recipe.';
//$write[] = ' * composer symfony:recipes:update vendor/package to update that recipe.';

This comment has been minimized.

Copy link
@weaverryan

weaverryan Nov 7, 2019

Member

I think to make this new command "complete", we would need to at least be able to show 2 commands down here:

A) A command to "update" a single recipe - so symfony:recipe:update - item (3) from #518
B) A command to "install" missing recipes - so symfony:recipe:install - item (2) from #518

The symfony:recipes vendor/package or whatever we call it - item (4) from #518 would be super nice to have, as would symfony:recipes:blame - but those could come later.

This comment has been minimized.

Copy link
@maxhelias

maxhelias Nov 8, 2019

Author Contributor
  • I started the symfony:recipes vendor/package in this command. I will update this PR when it's ready
  • The symfony:recipes:install is ready here : #565
  • For the symfony:recipes:update, it would be better to have some feedback on the #565 before I start it
  • And for the symfony:recipes:blame, it will be a lot more complicated and I agree to do it later
@maxhelias maxhelias force-pushed the maxhelias:feature/recipe-list branch from f26a79a to 96a33d4 Nov 7, 2019
@maxhelias

This comment has been minimized.

Copy link
Contributor Author

maxhelias commented Nov 13, 2019

I updated the PR, there is now the possibility to inspect only one recipe
Here is an overview, make suggestions for the final rendering 😉

Capture d’écran 2019-11-13 à 15 30 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.