Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computing the intersection of Symfony components with extra.symfony.require #580

Merged
merged 1 commit into from Dec 1, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 1, 2019

A constraint like ">5.0.0,<5.1" in SYMFONY_REQUIRE doesn't work right now, this fixes it.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:multi branch from 6b2c021 to 38f2f20 Dec 1, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Dec 1, 2019

PR ready. FYI the implementation could be a bit more robust if https://flex.symfony.com/versions.json could list the latest stable version of each branch.

e.g.

"branches": {
  "2.7" => "2.7.123",
  etc
}
@nicolas-grekas nicolas-grekas changed the title Fix comparing dev-versions of Symfony components Fix computing the intersection of Symfony components with extra.symfony.require Dec 1, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 1, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 38f2f20 into symfony:master Dec 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
fabpot added a commit that referenced this pull request Dec 1, 2019
…tra.symfony.require (nicolas-grekas)

This PR was merged into the 1.5-dev branch.

Discussion
----------

Fix computing the intersection of Symfony components with extra.symfony.require

A constraint like `">5.0.0,<5.1"` in `SYMFONY_REQUIRE` doesn't work right now, this fixes it.

Commits
-------

38f2f20 Fix comparing dev-versions of Symfony components
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:multi branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.