Use relative URLs when index.json provides them #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2022
nicolas-grekas
force-pushed
the
relative-urls
branch
from
daf707c to
c3815a7
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 30, 2022
This PR was merged into the 1.x branch. Discussion ---------- Fix relative URLs in index.json not working Hello, This PR fixes #897. It relates also to #872. `@nicolas`-grekas I found out that in [index.json](https://raw.githubusercontent.com/symfony/recipes-contrib/flex/main/index.json), the name of the attribute is _recipe_template_relative_, and not _recipes_template_relative_ as expected in the source code. And we should also set _recipe_template_ , instead of _recipes_template_. Regards, Commits ------- fae4e7f Update Downloader.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #868 with help from symfony-tools/recipes-checker@86f5d7f
Best reviewed ignoring whitespaces.