Skip to content
Permalink
Branch: master
Commits on May 11, 2019
  1. bug #30930 [FrameworkBundle] Fixed issue when a parameter contains a …

    nicolas-grekas committed May 11, 2019
    …'%' (lyrixx)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fixed issue when a parameter contains a '%'
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31431
    | License       | MIT
    | Doc PR        |
    
    ---
    
    On my computer:
    ```
    dump(get_cfg_var('xdebug.file_link_format'));
    "subl://%f:%l"
    ```
    
    When I ran `bin/console debug:config framework` I got this exception:
    
    ```
    
    In ParameterBag.php line 100:
    
      [Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException]
      The parameter "templating.helper.code.file_link_format" has a
    dependency on a non-existent parameter "f:".
    
    Exception trace:
     () at
    /home/gregoire/dev/github.com/lyrixx/symfony/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php:100
    ...
    ```
    
    This issue was introduced [here](https://github.com/symfony/symfony/pull/27684/files#diff-b3847149480405e1de881530b4c75ab5L212) / cc @ro0NL
    
    This PR does not really fix the issue: I'm able to debug the config, The
    the `debug:container --env-vars` does not work anymore. How could we fix
    both issue? cc @nicolas-grekas
    
    Commits
    -------
    
    7bcd714381 [FrameworkBundle] Fixed issue when a parameter container a '%'
Commits on May 9, 2019
  1. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Doctrine\Bridge] fix tests
      [Intl] Revise timezone name generation
      Simplifying SyncTransport and fixing bug with handlers transport
      [DomCrawler] fix HTML5 parser integration
  2. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  3. Merge branch '4.2' into 4.3

    nicolas-grekas committed May 9, 2019
    * 4.2:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  4. Merge branch '3.4' into 4.2

    nicolas-grekas committed May 9, 2019
    * 3.4:
      [DI] Removes number of elements information in debug mode
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  5. bug #31371 [DI] Removes number of elements information in debug mode …

    nicolas-grekas committed May 9, 2019
    …(jschaedl)
    
    This PR was squashed before being merged into the 3.4 branch (closes #31371).
    
    Discussion
    ----------
    
    [DI] Removes number of elements information in debug mode
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31340
    | License       | MIT
    | Doc PR        | -
    
    With this services config:
    
    ```yaml
    my_service:
        class: stdClass
        arguments: [!tagged my_tag]
    
    my_tagged_service_1:
        class: stdClass
        tags: [my_tag]
    
    my_tagged_service_2:
        class: stdClass
        tags: [my_tag]
    ```
    Executing `./bin/console debug:container my_service --show-arguments --env=dev` resulted in
    
    ```bash
    Information for Service "my_service"
    ====================================
    
     ---------------- -------------------------
      Option           Value
     ---------------- -------------------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Iterator (0 element(s))
     ---------------- -------------------------
    ```
     With this fix the output changed to:
    
    ```bash
    Information for Service "my_service"
    ====================================
    
     ---------------- ------------
      Option           Value
     ---------------- ------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Tagged Iterator for "my_tag"
     ---------------- ------------
    ```
    
    and with `./bin/console debug:container my_service --show-arguments --env=prod`
    
    ```bash
    Information for Service "my_service_tagged_iterator"
    ====================================================
    
     ---------------- ---------------------------------------------
      Option           Value
     ---------------- ---------------------------------------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Tagged Iterator for "my_tag" (2 element(s))
     ---------------- ---------------------------------------------
    ```
    
    Commits
    -------
    
    0da4b83197 [DI] Removes number of elements information in debug mode
Commits on May 1, 2019
  1. Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session ser…

    nicolas-grekas committed May 1, 2019
    …vice resettable (dmaicher)"
    
    This reverts commit 029fb2e7e36b7cdf29e27d4bfa54dd11adc5d457, reversing
    changes made to 9dad29d61c5605b589493efe34012fdb1218b92b.
You can’t perform that action at this time.