Skip to content
Permalink
Branch: master
Commits on Aug 14, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Import return annotations from vendors
      [ErrorHandler] Handle return types in DebugClassLoader
      cs fix
  2. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Remove superfluous phpdoc tags
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      Remove superfluous phpdoc tags
Commits on Aug 13, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
      [DI] deprecate support for non-object services
      [Translation] XliffLintCommand: allow .xliff file extension
      [Serializer] Encode empty objects as objects, not arrays
  2. feature #32845 [HttpKernel][FrameworkBundle] Add alternative conventi…

    nicolas-grekas committed Aug 13, 2019
    …on for bundle directories (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32845).
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#32453
    | License       | MIT
    | Doc PR        | TODO
    
    We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures.
    
    The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure.
    
    We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention.
    
    I've added some functional tests in which I've changed everything to this structure:
    ```
    -- ModernBundle
       |-- config/
       |-- public/
       |-- src/
           |-- ModernBundle.php
       |-- templates/
       |-- translations/
    ```
    WDYT?
    
    Commits
    -------
    
    6996e1cbe2 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  5. Fix return statements

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 12, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 12, 2019
    * 4.4:
      [WebLink] implement PSR-13 directly
Commits on Aug 9, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 9, 2019
    * 4.4:
      [HttpKernel] fixed class having a leading \ in a route controller
      [HttpKernel] trim the leading backslash in the controller init
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 9, 2019
    * 4.3:
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 9, 2019
    * 3.4:
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
  4. Merge branch '4.4'

    nicolas-grekas committed Aug 9, 2019
    * 4.4:
      Fix typo
      Fix unitialized variable in DeprecationErrorHandler
      fix Danish translations
      Support ISO 3166-1 Alpha-3 country codes
      Added the missing translations for the Slovak 'sk' locale.
      Add deprecation for method signature
      Add compatibility trait for PHPUnit constraint classes
      [HttpFoundation] Clear invalid session cookie
      Fix tst patern to handle callstack with/without return typehint
      Fix negative DateInterval
      [Validator] Allow objects implementing __toString() to be used as violation messages
      [FrameworkBundle][Routing] Private service route loaders
      [DoctrineBridge] Allow invokable event listeners
Commits on Aug 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Replace warning by isolated test
      Fix deprecation in 4.4 branche
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Replace warning by isolated test
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Replace warning by isolated test
  4. minor #33048 Remove ForwardCompatTestTrait (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 5.0-dev branch.
    
    Discussion
    ----------
    
    Remove ForwardCompatTestTrait
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.0
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | NA
    | License       | MIT
    | Doc PR        | NA
    
    Removes ForwardCompatTestTrait not needed anymore, and use the PHPUnit 8 signature on methods `setUp` and `tearDown`
    
    Commits
    -------
    
    242786cf98 Remove ForwardCompatTestTrait
  5. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Improve some URLs
      cleanup remaining param  and internal Intl FulLTransformer
      [HttpClient] fix data loss when streaming as a PHP resource
      Fix test compatibility with 4.x components
      [Cache] cs fix
  6. minor #33056 cleanup remaining param $options and internal Intl FullT…

    nicolas-grekas committed Aug 8, 2019
    …ransformer (Tobion)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    cleanup remaining param $options and internal Intl FullTransformer
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets |#...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    Continuation of #33020 and #33019
    
    Commits
    -------
    
    5dbcdc6ff4 cleanup remaining param  and internal Intl FulLTransformer
  7. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  8. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  9. minor #32800 Improve some URLs (Arman-Hosseini)

    nicolas-grekas committed Aug 8, 2019
    This PR was squashed before being merged into the 3.4 branch (closes #32800).
    
    Discussion
    ----------
    
    Improve some URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    fab17a4487 Improve some URLs
  10. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Fix compatibility with PHPUnit 8
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  11. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  12. minor #33000 Fix deprecations on 4.3 (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Fix deprecations on 4.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    Fix deprecations in branch 4.3
    note: remaining deprecation `assertStringContainsString` will be fixed in #32977
    
    * [ ] fix tests in branch 3.4 in #32981
    
    Commits
    -------
    
    8fd16a6bee Fix deprecation on 4.3
  13. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Remove unneeded phpdocs
  14. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Debug] Improve UPGRADE files
      remove wrongly added legacy group from test
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      add missing conflict rule
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      remove some more useless phpdocs
      Resilience against file_get_contents() race conditions.
      Turned return type annotations of private methods into php return types.
  15. minor #32993 Turned return type annotations of private methods into p…

    nicolas-grekas committed Aug 8, 2019
    …hp return types (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    Turned return type annotations of private methods into php return types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    As discussed with @nicolas-grekas in symfony/symfony#30323 (comment), this PR attempts to turn `@return` annotations on private methods into return type declarations.
    
    Commits
    -------
    
    f54ca001fe Turned return type annotations of private methods into php return types.
Commits on Aug 7, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 7, 2019
    * 4.4:
      remove deprecated cache pool arguments
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 7, 2019
    * 4.3:
      remove deprecated cache pool arguments
  3. Merge branch '4.4'

    nicolas-grekas committed Aug 7, 2019
    * 4.4:
      [ErrorRenderer] Fix timestamp on logs view
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 7, 2019
    * 4.3:
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 7, 2019
    * 3.4:
      [FrameworkBundle][Config] Ignore exeptions thrown during reflection classes autoload
Older
You can’t perform that action at this time.