Skip to content
Permalink
Branch: master
Commits on Jan 11, 2020
Commits on Jan 9, 2020
  1. bug #35099 [FrameworkBundle] Do not throw exception on value generate…

    nicolas-grekas committed Jan 9, 2020
    … key (jderusse)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Do not throw exception on value generate key
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    When using env variable instead of key files and creating a new Secret, the check in `generateKeys` (called by the command `SecretsSetCommand`) prevents generating a secret.
    
    reproducer:
    
    ```
    $ rm config/secrets/prod/prod.decrypt.private.php
    $ export SYMFONY_DECRYPTION_SECRET=XXX
    $ ./bin/console secret:set FOO
    
    In SodiumVault.php line 50:
    
      Cannot generate keys when a decryption key has been provided while instantiating the vault.
    
    ```
    
    This PR converts the exception in a warning message.
    
    Commits
    -------
    
    2f608b4dfa Do not throw exception on valut generate key
Commits on Jan 8, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Jan 8, 2020
    * 5.0:
      [Debug] fix ClassNotFoundFatalErrorHandler
      [FrameworkBundle] Document the router.cache_class_prefix parameter removal
      [Routing] Fix using a custom matcher & generator dumper class
      [Notifier] Add more specific types at documentation level when php engine can't
      [Serializer] Fix cache in MetadataAwareNameConverter
      [Dotenv] Fixed infinite loop with missing quote followed by quoted value
      [HttpClient] Added missing sprintf
      [TwigBridge] button_widget now has its title attr translated even if its label = null or false
      [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
      [Messenger] Added check if json_encode succeeded
      [Messenger] Added check if json_encode succeeded
      [FrameworkBundle][ContainerLintCommand] Only skip .errored. services
      [HttpClient] fix exception in case of PSR17 discovery failure
      [DependencyInjection] Handle ServiceClosureArgument for callable in container linting
      fix processing chain adapter based cache pool
      [HttpKernel] release lock explicitly
      [Security] Prevent canceled remember-me cookie from being accepted
      [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
      [Security\Guard] Fix missing typehints
      do not render preferred choices as selected
  2. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 8, 2020
    * 4.4:
      [Debug] fix ClassNotFoundFatalErrorHandler
      [Routing] Fix using a custom matcher & generator dumper class
      [Serializer] Fix cache in MetadataAwareNameConverter
      [Dotenv] Fixed infinite loop with missing quote followed by quoted value
      [HttpClient] Added missing sprintf
      [TwigBridge] button_widget now has its title attr translated even if its label = null or false
      [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
      [Messenger] Added check if json_encode succeeded
      [Messenger] Added check if json_encode succeeded
      [FrameworkBundle][ContainerLintCommand] Only skip .errored. services
      [HttpClient] fix exception in case of PSR17 discovery failure
      [DependencyInjection] Handle ServiceClosureArgument for callable in container linting
      fix processing chain adapter based cache pool
      [HttpKernel] release lock explicitly
      [Security] Prevent canceled remember-me cookie from being accepted
      [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
      [Security\Guard] Fix missing typehints
      do not render preferred choices as selected
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 8, 2020
    * 4.3:
      [Debug] fix ClassNotFoundFatalErrorHandler
      [Routing] Fix using a custom matcher & generator dumper class
      [Dotenv] Fixed infinite loop with missing quote followed by quoted value
      [HttpClient] Added missing sprintf
      [TwigBridge] button_widget now has its title attr translated even if its label = null or false
      [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
      [Messenger] Added check if json_encode succeeded
      [Security] Prevent canceled remember-me cookie from being accepted
      [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
      [Security\Guard] Fix missing typehints
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 8, 2020
    * 3.4:
      [Debug] fix ClassNotFoundFatalErrorHandler
      [Dotenv] Fixed infinite loop with missing quote followed by quoted value
      [TwigBridge] button_widget now has its title attr translated even if its label = null or false
      [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
      [Security] Prevent canceled remember-me cookie from being accepted
      [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
Commits on Jan 4, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Jan 4, 2020
    * 5.0: (31 commits)
      [HttpClient] NativeHttpClient should not send >1.1 protocol version
      [HttpClient] fix support for non-blocking resource streams
      [Mailer] Make sure you can pass custom headers to Mailgun
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [Security-Guard] fixed 35203 missing name tag in param docblock
      [HttpClient] fix casting responses to PHP streams
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [FrameworkBundle] Fix getUser() phpdoc in AbstractController
      [Mailer] Fix addresses management in Sendgrid API payload
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      Update year in license files
      Update year in license files
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      ...
  2. minor #35186 [FrameworkBundle] Fix getUser() phpdoc in AbstractContro…

    nicolas-grekas committed Jan 4, 2020
    …ller (natewiebe13)
    
    This PR was merged into the 5.0 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix getUser() phpdoc in AbstractController
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.0
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #35185
    | License       | MIT
    | Doc PR        | N/A
    
    This imports the `Symfony\Component\Security\Core\User\UserInterface` as the docs state that it returns `UserInterface` but doesn't use a FQN or import the class. This makes `getUser()` appear to return `Symfony\Bundle\FrameworkBundle\Controller\UserInterface`
    
    Commits
    -------
    
    bba9fd6ccf [FrameworkBundle] Fix getUser() phpdoc in AbstractController
  3. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 4, 2020
    * 4.4: (26 commits)
      [HttpClient] NativeHttpClient should not send >1.1 protocol version
      [HttpClient] fix support for non-blocking resource streams
      [Mailer] Make sure you can pass custom headers to Mailgun
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [Security-Guard] fixed 35203 missing name tag in param docblock
      [HttpClient] fix casting responses to PHP streams
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [Mailer] Fix addresses management in Sendgrid API payload
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      Update year in license files
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      Update year in license files
      fix version when "anonymous: lazy" was introduced
      ...
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 4, 2020
    * 4.3:
      [Mailer] Remove line breaks in email attachment content
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
      [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
      [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
      [HttpClient] fix capturing SSL certificates with NativeHttpClient
      [TwigBridge][Form] Added missing help messages in form themes
      Update year in license files
      Update year in license files
      [HttpClient] fix typo
      [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
      [Routing] Fix i18n routing when the url contains the locale
      Fix BC issue in phpDoc Reflection library
      [Translator] Performance improvement in MessageCatalogue and catalogue operations.
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 4, 2020
    * 3.4:
      Update links to documentation
      [Validator] Add the missing translations for the Arabic (ar) locale
      ensure to expect no validation for the right reasons
      [PhpUnitBridge] Add test case for @expectedDeprecation annotation
      Update year in license files
      [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
      Fix BC issue in phpDoc Reflection library
      [Translator] Performance improvement in MessageCatalogue and catalogue operations.
You can’t perform that action at this time.