Permalink
Commits on Mar 25, 2017
  1. Revert "feature #20973 [DI] Add getter injection (nicolas-grekas)"

    This reverts commit 2183f98f5482096ead88e9d251c6283fca067174, reversing
    changes made to b465634a55c2faa0e7e52142adfdd742a3797f54.
    nicolas-grekas committed Mar 25, 2017
Commits on Mar 22, 2017
  1. fixed Yoda condition

    fabpot committed Mar 22, 2017
  2. minor #22043 Refactor stale-while-revalidate code in HttpCache, add a…

    … (first?) test for it (mpdude)
    
    This PR was squashed before being merged into the 3.3-dev branch (closes #22043).
    
    Discussion
    ----------
    
    Refactor stale-while-revalidate code in HttpCache, add a (first?) test for it
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    I came up with this while trying to hunt a production bug related to handling of stale cache entries under the condition of a busy backend (also see #22033).
    
    It's just a refactoring to make the code more readable plus a new test.
    
    Commits
    -------
    
    b14057c88a Refactor stale-while-revalidate code in HttpCache, add a (first?) test for it
    fabpot committed Mar 22, 2017
  3. feature #21771 [FrameworkBundle] Add new "controller.service_argument…

    …s" tag to inject services into actions (nicolas-grekas)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Add new "controller.service_arguments" tag to inject services into actions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | (no test yet)
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Talking with @simensen and @weaverryan, we wondered if we could leverage the `ArgumentResolver` mechanism to make it inject services on demand, using e.g. autowiring.
    
    ```php
    class PostController
    {
      public function indexAction(Request $request, PostRepository $postRepository)
      {
        // PostRepository comes from the container
        $postRepository->findAll(); // ...
      }
    }
    ```
    
    This PR achieves that, using a new "controller.service_arguments" tag. Typically:
    ```yaml
    services:
        AppBundle\Controller\PostController:
            autowire: true
            tags:
                - name: controller.service_arguments
    ```
    
    It also supports with explicit wiring (thus doesn't necessarily require autowiring if you don't want to use it):
    ```yaml
    services:
        AppBundle\Controller\PostController:
            tags:
                - name: controller.service_arguments
                  action: fooAction
                  argument: logger
                  id: my_logger
    ```
    
    ~~The attached diff is bigger than strictly required for now, until #21770 is merged.~~
    
    Todo:
    - [x] rebase on top of #21770 when merged
    - [x] add tests
    - [x] add cleaning pass to remove empty service locators
    
    Commits
    -------
    
    9c6e672780 [FrameworkBundle] Add new "controller.service_arguments" tag to inject services into actions
    fabpot committed Mar 22, 2017
  4. Merge branch '3.2'

    * 3.2:
      Fixed pathinfo calculation for requests starting with a question mark.
      [HttpFoundation] Fix missing handling of for/host/proto info from "Forwarded" header
      [Validator] Add object handling of invalid constraints in Composite
      [WebProfilerBundle] Remove uneeded directive in the form collector styles
      removed usage of $that
      HttpCache: New test for revalidating responses with an expired TTL
      [Serializer] [XML] Ignore Process Instruction
      [Security] simplify the SwitchUserListenerTest
      Revert "bug #21841 [Console] Do not squash input changes made from console.command event (chalasr)"
      [HttpFoundation] Fix Request::getHost() when having several hosts in X_FORWARDED_HOST
    nicolas-grekas committed Mar 22, 2017
  5. feature #20567 [WebProfilerBundle] Improved cookie traffic (ro0NL)

    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Improved cookie traffic
    
    | Q             | A
    | ------------- | ---
    | Branch?       | "master"
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    ![image](https://cloud.githubusercontent.com/assets/1047696/20455635/a033a814-ae60-11e6-8500-e60146f4619e.png)
    
    Relates to #20569 in terms of getting _all_ the cookies.
    
    Commits
    -------
    
    171c6d100e [WebProfilerBundle] Improved cookie traffic
    fabpot committed Mar 22, 2017
  6. Merge branch '2.8' into 3.2

    * 2.8:
      [HttpFoundation] Fix missing handling of for/host/proto info from "Forwarded" header
      [Validator] Add object handling of invalid constraints in Composite
      [WebProfilerBundle] Remove uneeded directive in the form collector styles
      Revert "bug #21841 [Console] Do not squash input changes made from console.command event (chalasr)"
      [HttpFoundation] Fix Request::getHost() when having several hosts in X_FORWARDED_HOST
    fabpot committed Mar 22, 2017
  7. [HttpFoundation] Add $trustedHeaderSet arg to Request::setTrustedProx…

    …ies() - deprecate not setting it
    nicolas-grekas committed Feb 12, 2017
Commits on Mar 21, 2017
  1. removed usage of $that

    fabpot committed Mar 21, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      HttpCache: New test for revalidating responses with an expired TTL
      [Serializer] [XML] Ignore Process Instruction
    fabpot committed Mar 21, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      HttpCache: New test for revalidating responses with an expired TTL
      [Serializer] [XML] Ignore Process Instruction
    fabpot committed Mar 21, 2017
  4. minor #22099 HttpCache: New test for revalidating responses with an e…

    …xpired TTL (mpdude)
    
    This PR was squashed before being merged into the 2.7 branch (closes #22099).
    
    Discussion
    ----------
    
    HttpCache: New test for revalidating responses with an expired TTL
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    See #22035, in particular [this and the following comments](symfony/symfony#22035 (comment)).
    
    Commits
    -------
    
    067ab52ba0 HttpCache: New test for revalidating responses with an expired TTL
    fabpot committed Mar 21, 2017
  5. Merge branch '3.2'

    * 3.2:
      Fixes a typo in the form collector styles
      [WebProfilerBundle] Fix content-security-policy compatibility
      [WebProfilerBundle] Drop dead code
      [HttpKernel] Fixed bug with purging of HTTPS URLs
      fix some risky tests
      [DI] [YamlFileLoader] change error message of a non existing file
      [WebProfilerBundle] Handle Content-Security-Policy-Report-Only header correctly
      [Security] Added option to return true in the method isRememberMeRequested
    fabpot committed Mar 21, 2017
  6. Merge branch '2.8' into 3.2

    * 2.8:
      Fixes a typo in the form collector styles
      [HttpKernel] Fixed bug with purging of HTTPS URLs
      fix some risky tests
      [DI] [YamlFileLoader] change error message of a non existing file
      [Security] Added option to return true in the method isRememberMeRequested
    fabpot committed Mar 21, 2017
  7. Merge branch '2.7' into 2.8

    * 2.7:
      [HttpKernel] Fixed bug with purging of HTTPS URLs
      fix some risky tests
      [DI] [YamlFileLoader] change error message of a non existing file
      [Security] Added option to return true in the method isRememberMeRequested
    fabpot committed Mar 21, 2017
  8. minor #22066 fix some risky tests (xabbuh)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    fix some risky tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    PHPUnit 6 marks tests as risky when they have no assertions (and are not marked as skipped or incomplete). This PR will update our test suite accordingly.
    
    Component that still need to be covered:
    
    - [ ] Config
    - [ ] Form
    - [ ] HttpFoundation
    - [ ] Security
    - [ ] Workflow
    
    Commits
    -------
    
    abf1787dcc fix some risky tests
    fabpot committed Mar 21, 2017
Commits on Mar 20, 2017
  1. fix some risky tests

    xabbuh committed Mar 18, 2017
Commits on Mar 17, 2017
Commits on Mar 13, 2017
Commits on Mar 10, 2017
  1. bumped Symfony version to 3.2.7

    fabpot committed Mar 10, 2017
  2. updated VERSION for 3.2.6

    fabpot committed Mar 10, 2017
Commits on Mar 9, 2017
  1. bumped Symfony version to 3.2.6

    fabpot committed Mar 9, 2017
  2. updated VERSION for 3.2.5

    fabpot committed Mar 9, 2017
Commits on Mar 7, 2017
  1. Merge branch '3.2'

    * 3.2:
      [travis] Disable HHVM JIT - makes tests twice as fast
      [hhvm] 3.18-related fix
    nicolas-grekas committed Mar 7, 2017
  2. [hhvm] 3.18-related fix

    nicolas-grekas committed Mar 7, 2017
  3. Merge branch '3.2'

    * 3.2:
      [Cache] Fix Redis pipelining/multi-ops
      [Yaml] Fix the tests
      [github] Add a reminder about CHANGELOG.md files
      respect the umask argument in dumpFile()
      dumpFile(), preserve existing file permissions
      [Form] Fixed overridden choices option in extended choice types
      Add validate method to mockec validator in form TypeTestCase
      bumped Symfony version to 2.8.19
      updated VERSION for 2.8.18
      updated CHANGELOG for 2.8.18
      bumped Symfony version to 2.7.26
      updated VERSION for 2.7.25
      update CONTRIBUTORS for 2.7.25
      updated CHANGELOG for 2.7.25
      [HttpKernel] fixed Kernel name when stored in a directory starting with a number
      context listener: hardening user provider handling
      [Console] Do not squash input changes made from console.command event
    nicolas-grekas committed Mar 7, 2017