Skip to content
Permalink
Branch: master
Commits on Aug 14, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Import return annotations from vendors
      [ErrorHandler] Handle return types in DebugClassLoader
      cs fix
  2. Merge branch '4.4'

    nicolas-grekas committed Aug 14, 2019
    * 4.4:
      Remove superfluous phpdoc tags
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      Remove superfluous phpdoc tags
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      Remove superfluous phpdoc tags
Commits on Aug 13, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
      [DI] deprecate support for non-object services
      [Translation] XliffLintCommand: allow .xliff file extension
      [Serializer] Encode empty objects as objects, not arrays
  2. feature #33137 [DI] deprecate support for non-object services (nicola…

    nicolas-grekas committed Aug 13, 2019
    …s-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] deprecate support for non-object services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32411
    | License       | MIT
    | Doc PR        | -
    
    Follows #32432 /cc @derrabus
    Prepares for adding the `?object` return-type on master.
    
    Commits
    -------
    
    7c01c4c80c [DI] deprecate support for non-object services
  3. feature #32845 [HttpKernel][FrameworkBundle] Add alternative conventi…

    nicolas-grekas committed Aug 13, 2019
    …on for bundle directories (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32845).
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/symfony#32453
    | License       | MIT
    | Doc PR        | TODO
    
    We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures.
    
    The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure.
    
    We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention.
    
    I've added some functional tests in which I've changed everything to this structure:
    ```
    -- ModernBundle
       |-- config/
       |-- public/
       |-- src/
           |-- ModernBundle.php
       |-- templates/
       |-- translations/
    ```
    WDYT?
    
    Commits
    -------
    
    6996e1cbe2 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  4. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add type declarations to private DefaultChoiceListFactory methods
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  5. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  6. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  7. Fix return statements

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 12, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 12, 2019
    * 4.4:
      [Form] fix return type on FormDataCollector
      [Cache][DI] cleanup
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 12, 2019
    * 4.3:
      [Form] fix return type on FormDataCollector
      [Cache][DI] cleanup
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 12, 2019
    * 3.4:
      [Form] fix return type on FormDataCollector
Commits on Aug 9, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 9, 2019
    * 4.4:
      [HttpKernel] fixed class having a leading \ in a route controller
      [HttpKernel] trim the leading backslash in the controller init
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
Commits on Aug 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [HttpFoundation] deprecate using $first in get and added key in all
  2. feature #32122 [HttpFoundation] deprecate HeaderBag::get() returning …

    nicolas-grekas committed Aug 8, 2019
    …an array and add all($key) instead (Simperfit)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] deprecate HeaderBag::get() returning an array and add all($key) instead
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | maybe <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #31317  <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | todo <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    the $first param has been deprecated in the get methid
    and we are adding a $key parameter to all to get all values from a key as arrays
    Do we deprecated the get method ? if so this will be a little bigger in terms of changes.
    
    Commits
    -------
    
    2c5a8f1bdf [HttpFoundation] deprecate using $first in get and added key in all
  3. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  6. minor #33051 [HttpKernel] Fix s-maxage=3 transient test (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel] Fix s-maxage=3 transient test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | NA
    | License       | MIT
    | Doc PR        | NA
    
    sometime the http server returns a `s-maxage=3` header (https://travis-ci.org/symfony/symfony/jobs/569326531)
    This PR fixes tests to allow both 2 and 3
    
    Commits
    -------
    
    f019b5214d Fix s-maxage=3 transient test
  7. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Improve some URLs
      cleanup remaining param  and internal Intl FulLTransformer
      [HttpClient] fix data loss when streaming as a PHP resource
      Fix test compatibility with 4.x components
      [Cache] cs fix
  8. minor #33056 cleanup remaining param $options and internal Intl FullT…

    nicolas-grekas committed Aug 8, 2019
    …ransformer (Tobion)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    cleanup remaining param $options and internal Intl FullTransformer
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets |#...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    Continuation of #33020 and #33019
    
    Commits
    -------
    
    5dbcdc6ff4 cleanup remaining param  and internal Intl FulLTransformer
  9. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  10. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  11. minor #32800 Improve some URLs (Arman-Hosseini)

    nicolas-grekas committed Aug 8, 2019
    This PR was squashed before being merged into the 3.4 branch (closes #32800).
    
    Discussion
    ----------
    
    Improve some URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    fab17a4487 Improve some URLs
  12. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Fix compatibility with PHPUnit 8
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  13. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  14. minor #33042 Disable typehint patch on PHPUnit (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Disable typehint patch on PHPUnit
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    This PR removes the `SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT` patch and adds a `: void` typehint on `setup` and `tearDown` methods in order to be compatible with PHPUnit 8
    
    Commits
    -------
    
    a5af6c4cd7 Disable phpunit typehint patch on 4.3 branch
  15. fix merge

    nicolas-grekas committed Aug 8, 2019
  16. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Remove unneeded phpdocs
  17. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Debug] Improve UPGRADE files
      remove wrongly added legacy group from test
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      add missing conflict rule
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      remove some more useless phpdocs
      Resilience against file_get_contents() race conditions.
      Turned return type annotations of private methods into php return types.
  18. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      Resilience against file_get_contents() race conditions.
Older
You can’t perform that action at this time.