Skip to content
Permalink
Branch: master
Commits on May 9, 2019
  1. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Doctrine\Bridge] fix tests
      [Intl] Revise timezone name generation
      Simplifying SyncTransport and fixing bug with handlers transport
      [DomCrawler] fix HTML5 parser integration
  2. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  3. Merge branch '4.2' into 4.3

    nicolas-grekas committed May 9, 2019
    * 4.2:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  4. Merge branch '3.4' into 4.2

    nicolas-grekas committed May 9, 2019
    * 3.4:
      [DI] Removes number of elements information in debug mode
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  5. minor #31432 [Intl] Add FallbackTrait for data generation (ro0NL)

    nicolas-grekas committed May 9, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Add FallbackTrait for data generation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    This is the last architectural change for the Intl data compilation. Promised.
    
    It fixes de-duplicating a locale from its fallback locale. The problem is it uses a while-loop, comparing the locale to each fallback locale.
    
    Given
    
    - `root` (val=A)
      - `ur` (val=B)
        - `ur_IN` (val=A)
    
    We have an edge case where a locale (ur_IN) override its fallback locale (ur), setting/restoring the value back to the root locale. This happens for the GMT format in the timezone bundle i know of ... in this case the `ur_IN` locale needs to write its own value.
    
    The current approach is a while-loop comparing each fallback locale (ur, root) to the current locale (ur_IN). Eventually comparing `ur_IN <> root`, which causes a wrong diff, as such `ur_IN` falls back to `ur` providing the wrong value (val=B, where val=A is expected).
    
    The new approach uses recursion so we only compare `ur <> ur_IN`, where `ur_IN` on itself is compared to `root`.
    
    4.2) ro0NL/symfony@e24d8e6
    4.3) ro0NL/symfony@31591d0
    
    Commits
    -------
    
    36ddfd58b9 [Intl] Add FallbackTrait for data generation
You can’t perform that action at this time.