Skip to content
Permalink
Branch: master
Commits on Aug 13, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 13, 2019
    * 4.4:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add type declarations to private DefaultChoiceListFactory methods
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  4. Fix return statements

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 10, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 10, 2019
    * 4.4:
      cleanups
      Disable PHPUnit result cache on the CI
      [Security] Cleanup "Digest nonce has expired." translation
      [Translation] Highlight invalid translation status
      Added translations in validator for Serbian Cyrillic
      Added translations in validator for Serbian Latin
      [EventDispatcher] wrong Request class
      [DependencyInjection] improved exception message
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 10, 2019
    * 4.3:
      cleanups
      Disable PHPUnit result cache on the CI
      [Security] Cleanup "Digest nonce has expired." translation
      [Translation] Highlight invalid translation status
      Added translations in validator for Serbian Cyrillic
      Added translations in validator for Serbian Latin
      [EventDispatcher] wrong Request class
      [DependencyInjection] improved exception message
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 10, 2019
    * 3.4:
      cleanups
      Disable PHPUnit result cache on the CI
      [Translation] Highlight invalid translation status
  4. cleanups

    nicolas-grekas committed Aug 10, 2019
Commits on Aug 9, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 9, 2019
    * 4.4:
      Fix typo
      Fix unitialized variable in DeprecationErrorHandler
      fix Danish translations
      Support ISO 3166-1 Alpha-3 country codes
      Added the missing translations for the Slovak 'sk' locale.
      Add deprecation for method signature
      Add compatibility trait for PHPUnit constraint classes
      [HttpFoundation] Clear invalid session cookie
      Fix tst patern to handle callstack with/without return typehint
      Fix negative DateInterval
      [Validator] Allow objects implementing __toString() to be used as violation messages
      [FrameworkBundle][Routing] Private service route loaders
      [DoctrineBridge] Allow invokable event listeners
Commits on Aug 8, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      [Intl] use strict comparisons
      Fix s-maxage=3 transient test
  4. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Improve some URLs
      cleanup remaining param  and internal Intl FulLTransformer
      [HttpClient] fix data loss when streaming as a PHP resource
      Fix test compatibility with 4.x components
      [Cache] cs fix
  5. minor #33056 cleanup remaining param $options and internal Intl FullT…

    nicolas-grekas committed Aug 8, 2019
    …ransformer (Tobion)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    cleanup remaining param $options and internal Intl FullTransformer
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets |#...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    Continuation of #33020 and #33019
    
    Commits
    -------
    
    5dbcdc6ff4 cleanup remaining param  and internal Intl FulLTransformer
  6. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  7. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      Improve some URLs
      Fix test compatibility with 4.x components
      [Cache] cs fix
  8. minor #32800 Improve some URLs (Arman-Hosseini)

    nicolas-grekas committed Aug 8, 2019
    This PR was squashed before being merged into the 3.4 branch (closes #32800).
    
    Discussion
    ----------
    
    Improve some URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    fab17a4487 Improve some URLs
  9. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Fix compatibility with PHPUnit 8
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  10. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      Disable phpunit typehint patch on 4.3 branch
      Fix deprecation on 4.3
  11. minor #33042 Disable typehint patch on PHPUnit (jderusse)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Disable typehint patch on PHPUnit
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    This PR removes the `SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT` patch and adds a `: void` typehint on `setup` and `tearDown` methods in order to be compatible with PHPUnit 8
    
    Commits
    -------
    
    a5af6c4cd7 Disable phpunit typehint patch on 4.3 branch
  12. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      Remove unneeded phpdocs
  13. Merge branch '4.4'

    nicolas-grekas committed Aug 8, 2019
    * 4.4:
      [Debug] Improve UPGRADE files
      remove wrongly added legacy group from test
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      add missing conflict rule
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      remove some more useless phpdocs
      Resilience against file_get_contents() race conditions.
      Turned return type annotations of private methods into php return types.
  14. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 8, 2019
    * 4.3:
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      Resilience against file_get_contents() race conditions.
  15. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 8, 2019
    * 3.4:
      consistently throw NotSupportException
      [HttpKernel] Clarify error handler restoring process again
      [Intl] fix nullable phpdocs and useless method visibility of internal class
      Resilience against file_get_contents() race conditions.
  16. minor #33018 remove some more useless phpdocs (Tobion)

    nicolas-grekas committed Aug 8, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    remove some more useless phpdocs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Fix some leftovers from #32974 and #32786
    
    Commits
    -------
    
    9be4d171e0 remove some more useless phpdocs
  17. minor #33020 [Intl] fix nullable phpdocs and useless method visibilit…

    nicolas-grekas committed Aug 8, 2019
    …y of internal class (Tobion)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] fix nullable phpdocs and useless method visibility of internal class
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Fix stuff found in #32525
    
    Commits
    -------
    
    63b71b5ade [Intl] fix nullable phpdocs and useless method visibility of internal class
Commits on Aug 7, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 7, 2019
    * 4.4:
      fix merge
      Fix inconsistent return points.
      pass translation parameters to the trans filter
      [Mime] fixed wrong mimetype
      [ProxyManagerBridge] Polyfill for unmaintained version
      [HttpClient] Declare `$active` first to prevent weird issue
      Remove deprecated assertContains
      [HttpClient] fix tests
      SCA: dropped unused mocks, duplicate import and a function alias usage
      Added correct plural for box -> boxes
      [Config] fix test
      Fix remaining tests
      fix getName() when transport is null
      [Console] Check for ErrorHandler classes
      Improve fa (persian) translation
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 7, 2019
    * 4.3:
      Fix inconsistent return points.
      pass translation parameters to the trans filter
      [Mime] fixed wrong mimetype
      [ProxyManagerBridge] Polyfill for unmaintained version
      [HttpClient] Declare `$active` first to prevent weird issue
      Remove deprecated assertContains
      [HttpClient] fix tests
      SCA: dropped unused mocks, duplicate import and a function alias usage
      Added correct plural for box -> boxes
      [Config] fix test
      Fix remaining tests
      Improve fa (persian) translation
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 7, 2019
    * 3.4:
      Fix inconsistent return points.
      Fix remaining tests
Commits on Aug 6, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 6, 2019
    * 4.4:
      bump phpunit-bridge cache-id
      removed unneeded phpdocs
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 6, 2019
    * 4.3:
      bump phpunit-bridge cache-id
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
  3. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 6, 2019
    * 3.4:
      bump phpunit-bridge cache-id
      Use assertStringContainsString when needed
      Use assert assertContainsEquals when needed
      Use assertEqualsWithDelta when required
  4. minor #32968 Use assertEqualsWithDelta when needed (jderusse)

    nicolas-grekas committed Aug 6, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Use assertEqualsWithDelta when needed
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32844
    | License       | MIT
    | Doc PR        | NA
    
    This PR replaces deprecated paramèter `$delta` of methods `assertEquals` by the dedicated method `assertEqualsWithDelta`
    
    Commits
    -------
    
    3a0a901fdb Use assertEqualsWithDelta when required
Commits on Aug 5, 2019
  1. Merge branch '4.4'

    nicolas-grekas committed Aug 5, 2019
    * 4.4:
      [Form] Fix inconsistencies
      Use Phpunit FQDN in tests comments
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 5, 2019
    * 4.3:
      [Form] Fix inconsistencies
      Use Phpunit FQDN in tests comments
Older
You can’t perform that action at this time.